RFR: JDK-8282532 Add option to explicitly set build platform and remove support for legacy cross compilation flags

2022-03-02 Thread TheShermanTanker
Currently the only other option for manually configuring the build platform while cross compiling are devkits, which don't work on certain systems and are also more focused on differentiating the build and target compilers instead. This patch adds the ability to explicitly set the build platform

Re: RFR: JDK-8282532: Add option to explicitly set build platform and remove support for legacy cross compilation flags

2022-03-02 Thread Thomas Stuefe
On Wed, 2 Mar 2022 08:11:51 GMT, TheShermanTanker wrote: >This also removes support for the legacy cross compilation flags as well. Hi, without reading through building.md and your patch, which legacy flags are would be removed by this? Thanks, Thomas Oh, and please describe whatever you do

Re: RFR: JDK-8282532: Add option to explicitly set build platform and remove support for legacy cross compilation flags

2022-03-02 Thread TheShermanTanker
On Wed, 2 Mar 2022 08:27:19 GMT, Thomas Stuefe wrote: > > This also removes support for the legacy cross compilation flags as well. > > Hi, > > without reading through building.md and your patch, which legacy flags are > would be removed by this? > > Thanks, Thomas Specifically the flags tha

Re: RFR: JDK-8282532: Add option to explicitly set build platform and remove support for legacy cross compilation flags

2022-03-02 Thread Thomas Stuefe
On Wed, 2 Mar 2022 08:33:58 GMT, TheShermanTanker wrote: > > > This also removes support for the legacy cross compilation flags as well. > > > > > > Hi, > > without reading through building.md and your patch, which legacy flags are > > would be removed by this? > > Thanks, Thomas > > Specific

Re: RFR: 8282507: Add LICENSE file for hsdis

2022-03-02 Thread Magnus Ihse Bursie
On Tue, 1 Mar 2022 20:18:11 GMT, Man Cao wrote: > Hi all, > > Could anyone help review the addition of LICENSE file to hsdis directory? > > -Man I'm not sure what the legal implications are of adding a separate general file like this, instead of marking each individual file. I'd need to get s

Re: RFR: JDK-8282532: Add option to explicitly set build platform and remove support for legacy cross compilation flags

2022-03-02 Thread Magnus Ihse Bursie
On Wed, 2 Mar 2022 08:11:51 GMT, TheShermanTanker wrote: > Currently the only other option for manually configuring the build platform > while cross compiling are devkits, which don't work on certain systems and > are also more focused on differentiating the build and target compilers > instea

Re: RFR: JDK-8282532: Add option to explicitly set build platform and remove support for legacy cross compilation flags

2022-03-02 Thread TheShermanTanker
On Wed, 2 Mar 2022 08:11:51 GMT, TheShermanTanker wrote: > Currently the only other option for manually configuring the build platform > while cross compiling are devkits, which don't work on certain systems and > are also more focused on differentiating the build and target compilers > instea

JDK-8282532

2022-03-02 Thread Jules W.
Apologies for not creating a thread consulting the mailing list before submitting the PR, I'm still getting used to the process (And also thought this would create unnecessary noise for people within this list). I initially believed that given how the legacy options had warnings when they were set

Re: JDK-8282532

2022-03-02 Thread Thomas Stüfe
Hi Jules, On Wed, Mar 2, 2022 at 1:29 PM Jules W. wrote: > Apologies for not creating a thread consulting the mailing list before > submitting the PR, I'm still getting used to the process (And also thought > this would create unnecessary noise for people within this list). > On the contrary, t

Re: JDK-8282532

2022-03-02 Thread Jules W.
Hi Thomas, I was referring to Magnus' issue with the markdown docs I edited when I submitted the PR. Thank you for the encouragement, it means a lot to me :) best regards, Julian On Wed, Mar 2, 2022 at 8:42 PM Thomas Stüfe wrote: > Hi Jules, > > On Wed, Mar 2, 2022 at 1:29 PM Jules W. wrote:

Re: JDK-8282532

2022-03-02 Thread Magnus Ihse Bursie
Hi Julian, Thanks for bringing this back in a discussion format. If I understand your problem correctly, it is that the --openjdk-target fully replaces the autoconf --build/--host/--target triplet, and assumes that it can autodetect the build platform. And if that autodetect fails, the only r

Re: RFR: 8209784: Include hsdis in the JDK [v2]

2022-03-02 Thread Magnus Ihse Bursie
> This PR adds a new configure argument, `--enable-hsdis-bundling`. Setting > this, together with a valid backend using `--with-hsdis`, will bundle the > generated hsdis library with the JDK. > > The PR also includes a refactoring of the hsdis handling in autoconf, > breaking it out to a separa

Re: RFR: 8209784: Include hsdis in the JDK [v2]

2022-03-02 Thread Erik Joelsson
On Wed, 2 Mar 2022 13:12:52 GMT, Magnus Ihse Bursie wrote: >> This PR adds a new configure argument, `--enable-hsdis-bundling`. Setting >> this, together with a valid backend using `--with-hsdis`, will bundle the >> generated hsdis library with the JDK. >> >> The PR also includes a refactoring

Re: RFR: 8282567: Improve source-date handling in build system

2022-03-02 Thread Magnus Ihse Bursie
On Wed, 2 Mar 2022 16:52:12 GMT, Magnus Ihse Bursie wrote: > When doing reproducible builds, controlling the build time is imperative. To > make this as easy as possible, some changes are needed in the build system. > > * If source-date is set to anything other than "updated" (meaning that it

RFR: 8282567: Improve source-date handling in build system

2022-03-02 Thread Magnus Ihse Bursie
When doing reproducible builds, controlling the build time is imperative. To make this as easy as possible, some changes are needed in the build system. * If source-date is set to anything other than "updated" (meaning that it should be determined at build time), then the default value of --wi

Re: RFR: 8282567: Improve source-date handling in build system

2022-03-02 Thread Erik Joelsson
On Wed, 2 Mar 2022 16:52:12 GMT, Magnus Ihse Bursie wrote: > When doing reproducible builds, controlling the build time is imperative. To > make this as easy as possible, some changes are needed in the build system. > > * If source-date is set to anything other than "updated" (meaning that it

Re: RFR: 8209784: Include hsdis in the JDK [v3]

2022-03-02 Thread Erik Joelsson
On Wed, 2 Mar 2022 14:30:43 GMT, Magnus Ihse Bursie wrote: >> This PR adds a new configure argument, `--enable-hsdis-bundling`. Setting >> this, together with a valid backend using `--with-hsdis`, will bundle the >> generated hsdis library with the JDK. >> >> The PR also includes a refactoring

Re: RFR: 8282567: Improve source-date handling in build system

2022-03-02 Thread Severin Gehwolf
On Wed, 2 Mar 2022 16:54:21 GMT, Magnus Ihse Bursie wrote: > To clarify, the end effect of these changes is that building OpenJDK will > basically be compliant with the method of just setting SOURCE_DATE_EPOCH. > (The caveat is that it must be set at configure time, not build time.) So > > ```

Integrated: 8209784: Include hsdis in the JDK

2022-03-02 Thread Magnus Ihse Bursie
On Tue, 22 Feb 2022 16:10:22 GMT, Magnus Ihse Bursie wrote: > This PR adds a new configure argument, `--enable-hsdis-bundling`. Setting > this, together with a valid backend using `--with-hsdis`, will bundle the > generated hsdis library with the JDK. > > The PR also includes a refactoring of

Re: RFR: 8282567: Improve source-date handling in build system

2022-03-02 Thread Erik Joelsson
On Wed, 2 Mar 2022 16:52:12 GMT, Magnus Ihse Bursie wrote: > When doing reproducible builds, controlling the build time is imperative. To > make this as easy as possible, some changes are needed in the build system. > > * If source-date is set to anything other than "updated" (meaning that it

Re: RFR: 8282507: Add LICENSE file for hsdis

2022-03-02 Thread Man Cao
On Tue, 1 Mar 2022 20:18:11 GMT, Man Cao wrote: > Hi all, > > Could anyone help review the addition of LICENSE file to hsdis directory? > > -Man Thank you for reaching out for confirmation. This doc might help: https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-fea

RFR: JDK-8280902 ResourceBundle::getBundle may throw NPE when invoked by JNI code with no caller frame

2022-03-02 Thread Tim Prinzing
The caller class returned by Reflection::getCallerClass was used to gain access to it's module in most cases and class loader in one case. I added a method to translate the caller class to caller module so that the decision of what module represents the caller with no stack frame is made in a si

Re: RFR: JDK-8280902 ResourceBundle::getBundle may throw NPE when invoked by JNI code with no caller frame

2022-03-02 Thread Naoto Sato
On Wed, 2 Mar 2022 18:56:40 GMT, Tim Prinzing wrote: > The caller class returned by Reflection::getCallerClass was used to gain > access to it's module in most cases and class loader in one case. I added a > method to translate the caller class to caller module so that the decision of > what m

Re: RFR: JDK-8280902 ResourceBundle::getBundle may throw NPE when invoked by JNI code with no caller frame

2022-03-02 Thread Mandy Chung
On Wed, 2 Mar 2022 18:56:40 GMT, Tim Prinzing wrote: > The caller class returned by Reflection::getCallerClass was used to gain > access to it's module in most cases and class loader in one case. I added a > method to translate the caller class to caller module so that the decision of > what m

Re: RFR: JDK-8280902 ResourceBundle::getBundle may throw NPE when invoked by JNI code with no caller frame [v2]

2022-03-02 Thread Tim Prinzing
> The caller class returned by Reflection::getCallerClass was used to gain > access to it's module in most cases and class loader in one case. I added a > method to translate the caller class to caller module so that the decision of > what module represents the caller with no stack frame is made

Re: RFR: JDK-8280902 ResourceBundle::getBundle may throw NPE when invoked by JNI code with no caller frame [v3]

2022-03-02 Thread Tim Prinzing
> The caller class returned by Reflection::getCallerClass was used to gain > access to it's module in most cases and class loader in one case. I added a > method to translate the caller class to caller module so that the decision of > what module represents the caller with no stack frame is made

Re: RFR: JDK-8280902 ResourceBundle::getBundle may throw NPE when invoked by JNI code with no caller frame [v3]

2022-03-02 Thread Mandy Chung
On Wed, 2 Mar 2022 21:53:01 GMT, Tim Prinzing wrote: >> The caller class returned by Reflection::getCallerClass was used to gain >> access to it's module in most cases and class loader in one case. I added a >> method to translate the caller class to caller module so that the decision >> of wh

Re: RFR: JDK-8282532: Add option to explicitly set build platform and remove support for legacy cross compilation flags [v2]

2022-03-02 Thread Julian Waters
> Currently the only other option for manually configuring the build platform > while cross compiling are devkits, which don't work on certain systems and > are also more focused on differentiating the build and target compilers > instead. This patch adds the ability to explicitly set the build

Re: RFR: JDK-8282532: Add option to explicitly set build platform and remove support for legacy cross compilation flags [v3]

2022-03-02 Thread Julian Waters
> Currently the only other option for manually configuring the build platform > while cross compiling are devkits, which don't work on certain systems and > are also more focused on differentiating the build and target compilers > instead. This patch adds the ability to explicitly set the build