Re: RFR: JDK-8282532: Add option to explicitly set build platform and remove support for legacy cross compilation flags [v4]

2022-03-03 Thread Julian Waters
> Currently the only other option for manually configuring the build platform > while cross compiling are devkits, which don't work on certain systems and > are also more focused on differentiating the build and target compilers > instead. This patch adds the ability to explicitly set the build

Re: RFR: JDK-8282532: Add option to explicitly set build platform and remove support for legacy cross compilation flags [v4]

2022-03-03 Thread Julian Waters
On Thu, 3 Mar 2022 08:12:37 GMT, Julian Waters wrote: >> Currently the only other option for manually configuring the build platform >> while cross compiling are devkits, which don't work on certain systems and >> are also more focused on differentiating the build and target compilers >> inste

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v4]

2022-03-03 Thread Magnus Ihse Bursie
On Thu, 3 Mar 2022 08:12:37 GMT, Julian Waters wrote: >> Currently the only other option for manually configuring the build platform >> while cross compiling are devkits, which don't work on certain systems and >> are also more focused on differentiating the build and target compilers >> inste

Windows confusing object file names for other file types

2022-03-03 Thread Julian Waters
Windows seems to commonly confuse object file names that are created during the build process, despite .obj being the normal file format for object files on it (Weirdly enough), which is pretty likely because of pre-defined registry entries and applications that come together with it with fresh ins

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v4]

2022-03-03 Thread Julian Waters
On Thu, 3 Mar 2022 13:16:08 GMT, Magnus Ihse Bursie wrote: >> Julian Waters has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Syntax > > make/autoconf/configure line 298: > >> 296: exit 1 >> 297: else >> 298: echo "Warning: You

Re: RFR: JDK-8280902 ResourceBundle::getBundle may throw NPE when invoked by JNI code with no caller frame [v3]

2022-03-03 Thread Tim Prinzing
On Wed, 2 Mar 2022 22:21:03 GMT, Mandy Chung wrote: >> Tim Prinzing has updated the pull request incrementally with one additional >> commit since the last revision: >> >> suggested changes > > test/jdk/java/util/ResourceBundle/exeNullCallerResourceBundle/exeNullCallerResourceBundle.c > line

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v4]

2022-03-03 Thread Magnus Ihse Bursie
On Thu, 3 Mar 2022 13:32:33 GMT, Julian Waters wrote: >> make/autoconf/configure line 298: >> >>> 296: exit 1 >>> 297: else >>> 298: echo "Warning: You are using unsafe autoconf cross-compilation >>> flags." >> >> The autoconf flags are not really unsafe, they are just misleadingly n

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v4]

2022-03-03 Thread Julian Waters
On Thu, 3 Mar 2022 08:12:37 GMT, Julian Waters wrote: >> Currently the only other option for manually configuring the build platform >> while cross compiling are devkits, which don't work on certain systems and >> are also more focused on differentiating the build and target compilers >> inste

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v5]

2022-03-03 Thread Julian Waters
> Currently the only other option for manually configuring the build platform > while cross compiling are devkits, which don't work on certain systems and > are also more focused on differentiating the build and target compilers > instead. This patch adds the ability to explicitly set the build

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v4]

2022-03-03 Thread Julian Waters
On Thu, 3 Mar 2022 15:54:44 GMT, Magnus Ihse Bursie wrote: >> Would it be better if I changed that to say the flags are misleading, or if >> I reverted it back to legacy in that case? (Since that seems to be the >> primary concern with using them) > > As the build documentation says, the standa

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v6]

2022-03-03 Thread Julian Waters
> Currently the only other option for manually configuring the build platform > while cross compiling are devkits, which don't work on certain systems and > are also more focused on differentiating the build and target compilers > instead. This patch adds the ability to explicitly set the build

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v7]

2022-03-03 Thread Julian Waters
> Currently the only other option for manually configuring the build platform > while cross compiling are devkits, which don't work on certain systems and > are also more focused on differentiating the build and target compilers > instead. This patch adds the ability to explicitly set the build

Re: RFR: JDK-8280902 ResourceBundle::getBundle may throw NPE when invoked by JNI code with no caller frame [v4]

2022-03-03 Thread Tim Prinzing
> The caller class returned by Reflection::getCallerClass was used to gain > access to it's module in most cases and class loader in one case. I added a > method to translate the caller class to caller module so that the decision of > what module represents the caller with no stack frame is made

Re: RFR: JDK-8280902 ResourceBundle::getBundle may throw NPE when invoked by JNI code with no caller frame [v4]

2022-03-03 Thread Mandy Chung
On Thu, 3 Mar 2022 16:55:46 GMT, Tim Prinzing wrote: >> The caller class returned by Reflection::getCallerClass was used to gain >> access to it's module in most cases and class loader in one case. I added a >> method to translate the caller class to caller module so that the decision >> of wh

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v7]

2022-03-03 Thread David Holmes
On Thu, 3 Mar 2022 16:48:40 GMT, Julian Waters wrote: >> Currently the only other option for manually configuring the build platform >> while cross compiling are devkits, which don't work on certain systems and >> are also more focused on differentiating the build and target compilers >> inste

Re: Windows confusing object file names for other file types

2022-03-03 Thread David Holmes
On 3/03/2022 11:29 pm, Julian Waters wrote: Windows seems to commonly confuse object file names that are created during the build process I don't understand what you mean by that, please elaborate. Thanks, David , despite .obj being the normal file format for object files on it (Weirdly enou

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v7]

2022-03-03 Thread Julian Waters
On Thu, 3 Mar 2022 16:48:40 GMT, Julian Waters wrote: >> Currently the only other option for manually configuring the build platform >> while cross compiling are devkits, which don't work on certain systems and >> are also more focused on differentiating the build and target compilers >> inste

Re: Windows confusing object file names for other file types

2022-03-03 Thread Julian Waters
Hi all, Yes, I was referring to what Magnus mentioned about the file associations. Hopefully this can be ignored, since I wasn't in a very clear state of mind when I posted this to the mailing lists :/ best regards, Julian On Fri, Mar 4, 2022 at 10:47 AM David Holmes wrote: > On 3/03/2022 11:2

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v8]

2022-03-03 Thread Julian Waters
> Currently the only other option for manually configuring the build platform > while cross compiling are devkits, which don't work on certain systems and > are also more focused on differentiating the build and target compilers > instead. This patch adds the ability to explicitly set the build

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v9]

2022-03-03 Thread Julian Waters
> Currently the only other option for manually configuring the build platform > while cross compiling are devkits, which don't work on certain systems and > are also more focused on differentiating the build and target compilers > instead. This patch adds the ability to explicitly set the build

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v10]

2022-03-03 Thread Julian Waters
> Currently the only other option for manually configuring the build platform > while cross compiling are devkits, which don't work on certain systems and > are also more focused on differentiating the build and target compilers > instead. This patch adds the ability to explicitly set the build

Re: RFR: JDK-8282532: Allow explicitly setting build platform alongside --openjdk-target [v10]

2022-03-03 Thread Julian Waters
On Fri, 4 Mar 2022 07:51:36 GMT, Julian Waters wrote: >> Currently the only other option for manually configuring the build platform >> while cross compiling are devkits, which don't work on certain systems and >> are also more focused on differentiating the build and target compilers >> inste