Re: RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port [v4]

2022-03-23 Thread Aleksey Shipilev
On Wed, 23 Mar 2022 02:03:26 GMT, Fei Yang wrote: >> This PR implements JEP 422: Linux/RISC-V Port [1]. >> The PR starts as a squashed merge of the >> https://openjdk.java.net/projects/riscv-port branch. >> >> This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive >> Unmatched

RFR: 8283323: libharfbuzz optimization level results in extreme build times

2022-03-23 Thread Magnus Ihse Bursie
[JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference linux machine. This was one of the four culprits that caused a 25-30% build time regression over the last two years. The problem here was that

Re: RFR: 8283323: libharfbuzz optimization level results in extreme build times

2022-03-23 Thread Erik Joelsson
On Wed, 23 Mar 2022 12:25:08 GMT, Magnus Ihse Bursie wrote: > [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade > HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference > linux machine. This was one of the four culprits that caused a 25-30% build

Re: RFR: 8283323: libharfbuzz optimization level results in extreme build times

2022-03-23 Thread Aleksey Shipilev
On Wed, 23 Mar 2022 12:25:08 GMT, Magnus Ihse Bursie wrote: > [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade > HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference > linux machine. This was one of the four culprits that caused a 25-30% build

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v5]

2022-03-23 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-424 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/424 Maurizio Cimadamore has updated the pull

RFR: 8283575: Check for GNU time fails for version >1.7

2022-03-23 Thread Erik Joelsson
The version output of GNU time changed from "GNU time" to "GNU Time" in version 1.8. We need to update our check for identifying GNU time to handle this. - Commit messages: - JDK-8283575 Changes: https://git.openjdk.java.net/jdk/pull/7925/files Webrev:

Re: RFR: 8283575: Check for GNU time fails for version >1.7

2022-03-23 Thread Aleksey Shipilev
On Wed, 23 Mar 2022 15:35:44 GMT, Erik Joelsson wrote: > The version output of GNU time changed from "GNU time" to "GNU Time" in > version 1.8. We need to update our check for identifying GNU time to handle > this. Looks okay, provided you tested with some version of GNU [Tt]ime. Is double

Re: RFR: 8283323: libharfbuzz optimization level results in extreme build times

2022-03-23 Thread Magnus Ihse Bursie
On Wed, 23 Mar 2022 12:25:08 GMT, Magnus Ihse Bursie wrote: > [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade > HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference > linux machine. This was one of the four culprits that caused a 25-30% build

Re: RFR: 8283323: libharfbuzz optimization level results in extreme build times

2022-03-23 Thread Erik Joelsson
On Wed, 23 Mar 2022 12:25:08 GMT, Magnus Ihse Bursie wrote: > [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade > HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference > linux machine. This was one of the four culprits that caused a 25-30% build

Re: RFR: 8283575: Check for GNU time fails for version >1.7

2022-03-23 Thread Erik Joelsson
On Wed, 23 Mar 2022 16:22:55 GMT, Aleksey Shipilev wrote: > Looks okay, provided you tested with some version of GNU [Tt]ime. Thanks! I hit this while trying to use GNU time on my mac to get LOG=profile to work, to profile compilation times of individual compilation units. I built latest

Re: RFR: 8283323: libharfbuzz optimization level results in extreme build times [v3]

2022-03-23 Thread Phil Race
On Wed, 23 Mar 2022 23:38:52 GMT, Sergey Bylokhov wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update comment to show we don't care about these files. > > Do we really want to change the product

Re: RFR: 8283323: libharfbuzz optimization level results in extreme build times

2022-03-23 Thread Phil Race
On Wed, 23 Mar 2022 12:25:08 GMT, Magnus Ihse Bursie wrote: > [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade > HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference > linux machine. This was one of the four culprits that caused a 25-30% build

Re: RFR: 8283323: libharfbuzz optimization level results in extreme build times

2022-03-23 Thread Phil Race
On Wed, 23 Mar 2022 12:25:08 GMT, Magnus Ihse Bursie wrote: > [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade > HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference > linux machine. This was one of the four culprits that caused a 25-30% build

Re: RFR: 8283323: libharfbuzz optimization level results in extreme build times [v2]

2022-03-23 Thread Magnus Ihse Bursie
On Wed, 23 Mar 2022 21:13:30 GMT, Magnus Ihse Bursie wrote: >> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade >> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my >> reference linux machine. This was one of the four culprits that caused a >> 25-30%

Re: RFR: 8283323: libharfbuzz optimization level results in extreme build times [v2]

2022-03-23 Thread Magnus Ihse Bursie
> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade > HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference > linux machine. This was one of the four culprits that caused a 25-30% build > time regression over the last two years. > > The problem

Re: RFR: 8283323: libharfbuzz optimization level results in extreme build times

2022-03-23 Thread Magnus Ihse Bursie
On Wed, 23 Mar 2022 19:35:22 GMT, Phil Race wrote: >> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade >> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my >> reference linux machine. This was one of the four culprits that caused a >> 25-30% build

Re: RFR: 8283575: Check for GNU time fails for version >1.7

2022-03-23 Thread Magnus Ihse Bursie
On Wed, 23 Mar 2022 15:35:44 GMT, Erik Joelsson wrote: > The version output of GNU time changed from "GNU time" to "GNU Time" in > version 1.8. We need to update our check for identifying GNU time to handle > this. I usually handle cases like this by prefixing with a comment: #

Re: RFR: 8283323: libharfbuzz optimization level results in extreme build times [v3]

2022-03-23 Thread Magnus Ihse Bursie
On Wed, 23 Mar 2022 23:38:52 GMT, Sergey Bylokhov wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update comment to show we don't care about these files. > > Do we really want to change the product

Re: RFR: 8283575: Check for GNU time fails for version >1.7 [v2]

2022-03-23 Thread Erik Joelsson
> The version output of GNU time changed from "GNU time" to "GNU Time" in > version 1.8. We need to update our check for identifying GNU time to handle > this. Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision: Update

Re: RFR: 8283323: libharfbuzz optimization level results in extreme build times [v3]

2022-03-23 Thread Phil Race
On Wed, 23 Mar 2022 23:17:38 GMT, Magnus Ihse Bursie wrote: >> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade >> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my >> reference linux machine. This was one of the four culprits that caused a >> 25-30%

Re: RFR: 8283323: libharfbuzz optimization level results in extreme build times [v2]

2022-03-23 Thread Phil Race
On Wed, 23 Mar 2022 23:13:04 GMT, Magnus Ihse Bursie wrote: >> make/modules/java.desktop/lib/Awt2dLibraries.gmk line 487: >> >>> 485: LIBFONTMANAGER_OPTIMIZATION := HIGHEST >>> 486: >>> 487: ifneq ($(filter $(TOOLCHAIN_TYPE), gcc clang), ) >> >> Can we have a note here that the de-opt is

Re: RFR: 8283323: libharfbuzz optimization level results in extreme build times [v2]

2022-03-23 Thread Phil Race
On Wed, 23 Mar 2022 21:13:30 GMT, Magnus Ihse Bursie wrote: >> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade >> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my >> reference linux machine. This was one of the four culprits that caused a >> 25-30%

Re: RFR: 8283323: libharfbuzz optimization level results in extreme build times [v3]

2022-03-23 Thread Magnus Ihse Bursie
> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade > HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference > linux machine. This was one of the four culprits that caused a 25-30% build > time regression over the last two years. > > The problem

Re: RFR: 8283323: libharfbuzz optimization level results in extreme build times [v2]

2022-03-23 Thread Magnus Ihse Bursie
On Wed, 23 Mar 2022 22:37:55 GMT, Phil Race wrote: >> Magnus Ihse Bursie has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Restore HIGHEST for entire lib, just set SIZE to two files > > make/modules/java.desktop/lib/Awt2dLibraries.gmk

Re: RFR: 8283323: libharfbuzz optimization level results in extreme build times [v3]

2022-03-23 Thread Sergey Bylokhov
On Wed, 23 Mar 2022 23:17:38 GMT, Magnus Ihse Bursie wrote: >> [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade >> HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my >> reference linux machine. This was one of the four culprits that caused a >> 25-30%