Re: RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port [v5]

2022-03-24 Thread Fei Yang
> This PR implements JEP 422: Linux/RISC-V Port [1]. > The PR starts as a squashed merge of the > https://openjdk.java.net/projects/riscv-port branch. > > This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive > Unmatched board. Dacapo, SPECjbb2015 and SPECjvm2008 benchmark tests a

Re: RFR: 8276799: Implementation of JEP 422: Linux/RISC-V Port [v4]

2022-03-24 Thread Fei Yang
On Wed, 23 Mar 2022 02:17:22 GMT, Vladimir Kozlov wrote: >> Fei Yang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix copyright header > > Update looks good. > Testing results are also good. @vnkozlov @shipilev : Thanks for reviewing

Re: RFR: 8283323: libharfbuzz optimization level results in extreme build times [v3]

2022-03-24 Thread Sergey Bylokhov
On Thu, 24 Mar 2022 03:53:52 GMT, Phil Race wrote: > And unless you're backing up your claim that this patch is changing runtime > characteristic with data, that's just a guess, just like the initial > optimization level of this library (and as most of the native libraries in > the JDK... :-()

Integrated: 8276799: Implementation of JEP 422: Linux/RISC-V Port

2022-03-24 Thread Fei Yang
On Mon, 8 Nov 2021 11:17:47 GMT, Fei Yang wrote: > This PR implements JEP 422: Linux/RISC-V Port [1]. > The PR starts as a squashed merge of the > https://openjdk.java.net/projects/riscv-port branch. > > This has been tested with jtreg tier{1,2,3,4} and jcstress on HiFive > Unmatched board. Da

Re: RFR: 8283323: libharfbuzz optimization level results in extreme build times [v3]

2022-03-24 Thread Magnus Ihse Bursie
On Thu, 24 Mar 2022 07:38:34 GMT, Sergey Bylokhov wrote: >>> @mrserb Phil said that we don't even use the subset part of harfbuzz. >>> >>> And unless you're backing up your claim that this patch is changing runtime >>> characteristic with data, that's just a guess, just like the initial >>> op

Re: RFR: 8283575: Check for GNU time fails for version >1.7 [v2]

2022-03-24 Thread Magnus Ihse Bursie
On Wed, 23 Mar 2022 22:06:49 GMT, Erik Joelsson wrote: >> The version output of GNU time changed from "GNU time" to "GNU Time" in >> version 1.8. We need to update our check for identifying GNU time to handle >> this. > > Erik Joelsson has updated the pull request incrementally with one additio

Integrated: 8283323: libharfbuzz optimization level results in extreme build times

2022-03-24 Thread Magnus Ihse Bursie
On Wed, 23 Mar 2022 12:25:08 GMT, Magnus Ihse Bursie wrote: > [JDK-8247872](https://bugs.openjdk.java.net/browse/JDK-8247872) (upgrade > HarfBuzz to 2.7.2) caused build time to go up with 24 seconds on my reference > linux machine. This was one of the four culprits that caused a 25-30% build >

Integrated: 8283575: Check for GNU time fails for version >1.7

2022-03-24 Thread Erik Joelsson
On Wed, 23 Mar 2022 15:35:44 GMT, Erik Joelsson wrote: > The version output of GNU time changed from "GNU time" to "GNU Time" in > version 1.8. We need to update our check for identifying GNU time to handle > this. This pull request has now been integrated. Changeset: 1c4f5fcb Author:Erik

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v5]

2022-03-24 Thread Jorn Vernee
On Wed, 23 Mar 2022 14:06:56 GMT, Maurizio Cimadamore wrote: >> This PR contains the API and implementation changes for JEP-424 [1]. A more >> detailed description of such changes, to avoid repetitions during the review >> process, is included as a separate comment. >> >> [1] - https://openjd

Re: Failing jdk11u AIX build on Adoptium servers

2022-03-24 Thread Thomas Stüfe
cc build-dev. Hi Tyler, makes sense to me. Wrt the documentation, probably we should change the minimum requirement of jdk12 too then. Cheers, Thomas On Thu, Mar 24, 2022 at 4:05 PM Tyler Steele wrote: > Hi all, > > In regards to the new Harfbuzz version bump (and the work done to prepare

Re: Failing jdk11u AIX build on Adoptium servers

2022-03-24 Thread Thomas Stüfe
Hi Matthias, On Thu, Mar 24, 2022 at 4:55 PM Baesken, Matthias wrote: > Hi , > > > > >My expected course of action is as follows: > >- Bump the minimum requirements in our Supported Builds document > >[https://wiki.openjdk.java.net/display/Build/Supported+Build+Platforms] > >- Open an issue with

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v6]

2022-03-24 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-424 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/424 Maurizio Cimadamore has updated the pull request

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v5]

2022-03-24 Thread Maurizio Cimadamore
On Thu, 24 Mar 2022 13:10:20 GMT, Jorn Vernee wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Drop redundant javadoc statements re. handling of nulls >> (handling of nulls is specified once and for all in

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v5]

2022-03-24 Thread Maurizio Cimadamore
On Thu, 24 Mar 2022 13:00:12 GMT, Jorn Vernee wrote: >> Maurizio Cimadamore has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Drop redundant javadoc statements re. handling of nulls >> (handling of nulls is specified once and for all in

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v7]

2022-03-24 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-424 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/424 Maurizio Cimadamore has updated the pull request

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v5]

2022-03-24 Thread Jorn Vernee
On Thu, 24 Mar 2022 17:48:23 GMT, Maurizio Cimadamore wrote: >> make/test/BuildMicrobenchmark.gmk line 97: >> >>> 95: SRC := $(MICROBENCHMARK_SRC), \ >>> 96: BIN := $(MICROBENCHMARK_CLASSES), \ >>> 97: JAVAC_FLAGS := --add-exports >>> java.base/sun.security.util=ALL-UNNAMED --enabl

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v8]

2022-03-24 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-424 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/424 Maurizio Cimadamore has updated the pull request

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v9]

2022-03-24 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-424 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/424 Maurizio Cimadamore has updated the pull request

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v10]

2022-03-24 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-424 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/424 Maurizio Cimadamore has updated the pull request

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v11]

2022-03-24 Thread Jorn Vernee
On Thu, 24 Mar 2022 19:19:34 GMT, Maurizio Cimadamore wrote: >> This PR contains the API and implementation changes for JEP-424 [1]. A more >> detailed description of such changes, to avoid repetitions during the review >> process, is included as a separate comment. >> >> [1] - https://openjd

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v5]

2022-03-24 Thread Jorn Vernee
On Thu, 24 Mar 2022 18:35:12 GMT, Jorn Vernee wrote: >> Sure, this is problematic - but at the same time I don't think there's a >> better way to deal with this? I'd prefer to defer this to a separate issue >> (and I think the build team is in a much better position to suggest a better >> fix)

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v5]

2022-03-24 Thread Maurizio Cimadamore
On Thu, 24 Mar 2022 19:17:40 GMT, Jorn Vernee wrote: >> I'd suggest at least adding `--enable-preview` as an argument when running >> benchmarks through the build system in that case. I think this should do the >> trick: >> >> >> diff --git a/make/RunTests.gmk b/make/RunTests.gmk >> index 815

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v11]

2022-03-24 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-424 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/424 Maurizio Cimadamore has updated the pull request