RFR: 8284507: GHA: Only check test results if testing was not skipped

2022-04-07 Thread Christoph Langer
In GitHub Actions the step "Check that all tests executed successfully" will be marked as failing when the "Run tests" step did not run but some earlier step already failed. This is irritating and it can be corrected by doing the test check only if testing was not skipped. Here is a link to suc

Re: RFR: 8284507: GHA: Only check test results if testing was not skipped

2022-04-07 Thread Aleksey Shipilev
On Thu, 7 Apr 2022 07:53:38 GMT, Christoph Langer wrote: > In GitHub Actions the step "Check that all tests executed successfully" will > be marked as failing when the "Run tests" step did not run but some earlier > step already failed. This is irritating and it can be corrected by doing the >

Re: RFR: 8284507: GHA: Only check test results if testing was not skipped

2022-04-07 Thread Christoph Langer
On Thu, 7 Apr 2022 07:53:38 GMT, Christoph Langer wrote: > In GitHub Actions the step "Check that all tests executed successfully" will > be marked as failing when the "Run tests" step did not run but some earlier > step already failed. This is irritating and it can be corrected by doing the >

Re: RFR: JDK-8281006 Module::getResourceAsStream should check if the resource is open unconditionally when caller is null [v2]

2022-04-07 Thread Erik Joelsson
On Thu, 7 Apr 2022 00:56:42 GMT, Tim Prinzing wrote: >> Created a test called NullCallerGetResource to test >> Module::getResourceAsStream and Class::getResourceAsStream from the native >> level. >> >> At the java level the test builds a test module called 'n' which opens the >> package 'open

Re: RFR: JDK-8281006 Module::getResourceAsStream should check if the resource is open unconditionally when caller is null [v2]

2022-04-07 Thread Tim Prinzing
On Thu, 7 Apr 2022 05:52:24 GMT, Alan Bateman wrote: > Tim - this creates a conflict between the spec and implementation, the > changes to the 2-arg isOpen method need to be dropped so that it continues to > throw NPE if module is null. okay - PR: https://git.openjdk.java.net/jdk

Re: RFR: 8284507: GHA: Only check test results if testing was not skipped

2022-04-07 Thread Magnus Ihse Bursie
On Thu, 7 Apr 2022 07:53:38 GMT, Christoph Langer wrote: > In GitHub Actions the step "Check that all tests executed successfully" will > be marked as failing when the "Run tests" step did not run but some earlier > step already failed. This is irritating and it can be corrected by doing the >

Re: RFR: 8284437: Building from different users/workspace is not always deterministic [v2]

2022-04-07 Thread Magnus Ihse Bursie
On Wed, 6 Apr 2022 13:30:28 GMT, Andrew Leonard wrote: >> This PR fixes the non-deterministic behavior when building on linux with >> different userids or within >> different workspace folders. >> It fixes the following issues: >> - MakeZipReproducible.java used to produce reproducible src.zip r

Re: RFR: 8284437: Building from different users/workspace is not always deterministic [v2]

2022-04-07 Thread Erik Joelsson
On Thu, 7 Apr 2022 15:51:30 GMT, Magnus Ihse Bursie wrote: >> Andrew Leonard has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Trigger checks > > make/common/NativeCompilation.gmk line 1159: > >> 1157: ifeq ($(call isTargetOs, linux

Re: RFR: 8284437: Building from different users/workspace is not always deterministic [v2]

2022-04-07 Thread Andrew Leonard
On Thu, 7 Apr 2022 18:10:29 GMT, Andrew Leonard wrote: >> You are correct for the linking command line. All the compilation command >> lines are still handled with flags instead. > > What is CWD ? Current working dir ! - PR: https://git.openjdk.java.net/jdk/pull/8124

Re: RFR: 8284437: Building from different users/workspace is not always deterministic [v2]

2022-04-07 Thread Andrew Leonard
On Thu, 7 Apr 2022 16:33:44 GMT, Erik Joelsson wrote: >> make/common/NativeCompilation.gmk line 1159: >> >>> 1157: ifeq ($(call isTargetOs, linux), true) >>> 1158: ifeq ($$($1_COMPILE_WITH_DEBUG_SYMBOLS), true) >>> 1159: $1_LINK_OBJS_RELATIVE := true >> >> I realize this

Re: RFR: 8284437: Building from different users/workspace is not always deterministic [v2]

2022-04-07 Thread Andrew Leonard
On Thu, 7 Apr 2022 15:51:30 GMT, Magnus Ihse Bursie wrote: >> Andrew Leonard has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Trigger checks > > make/common/NativeCompilation.gmk line 1159: > >> 1157: ifeq ($(call isTargetOs, linux

Re: RFR: 8284437: Building from different users/workspace is not always deterministic [v2]

2022-04-07 Thread Erik Joelsson
On Thu, 7 Apr 2022 18:17:57 GMT, Andrew Leonard wrote: >> make/common/NativeCompilation.gmk line 1159: >> >>> 1157: ifeq ($(call isTargetOs, linux), true) >>> 1158: ifeq ($$($1_COMPILE_WITH_DEBUG_SYMBOLS), true) >>> 1159: $1_LINK_OBJS_RELATIVE := true >> >> I realize thi

Re: RFR: JDK-8281006 Module::getResourceAsStream should check if the resource is open unconditionally when caller is null [v3]

2022-04-07 Thread Tim Prinzing
> Created a test called NullCallerGetResource to test > Module::getResourceAsStream and Class::getResourceAsStream from the native > level. > > At the java level the test builds a test module called 'n' which opens the > package 'open' to everyone. There is also a package 'closed' which is neit

RFR: 8265315: Support for CLDR version 41

2022-04-07 Thread Naoto Sato
This is to upgrade the CLDR data from version 39 to version 41 which was released yesterday. The vast majority of the changes are basically replacing the CLDR data, along with tools/testcase alignments. Here is the link to CLDR v41's release notes: https://cldr.unicode.org/index/downloads/cldr-4

Re: RFR: 8265315: Support for CLDR version 41

2022-04-07 Thread Joe Wang
On Thu, 7 Apr 2022 21:20:20 GMT, Naoto Sato wrote: > This is to upgrade the CLDR data from version 39 to version 41 which was > released yesterday. The vast majority of the changes are basically replacing > the CLDR data, along with tools/testcase alignments. Here is the link to CLDR > v41's r

Re: RFR: 8265315: Support for CLDR version 41

2022-04-07 Thread Iris Clark
On Thu, 7 Apr 2022 21:20:20 GMT, Naoto Sato wrote: > This is to upgrade the CLDR data from version 39 to version 41 which was > released yesterday. The vast majority of the changes are basically replacing > the CLDR data, along with tools/testcase alignments. Here is the link to CLDR > v41's r