Re: RFR: 8285743: Ensure each IntegerPolynomial object is only created once [v2]

2022-04-29 Thread Weijun Wang
> All `IntegerPolynimial`s are singletons now. Also, hand-coded implementations > for Ed25519 and Ed448 are removed. They were not used since `FieldGen` starts > generating classes for them. > > No new regression test. This is a clean-up. Weijun Wang has updated the pull request incrementally

RFR: 8282828: CDS uncompressed oops archive is not deterministic

2022-04-29 Thread Ioi Lam
During `java -Xshare:dump -XX:-UseCompressedOops`, the location of the Java heap is chosen by the OS. Due to Address Space Layout Randomization, the heap will always start at a different location. This causes the archive for uncompressed oops ($JAVA_HOME/lib/server/classes_nocoops.jsa) to be

RFR: 8285743: Ensure each IntegerPolynomial object is only created once

2022-04-29 Thread Weijun Wang
All `IntegerPolynimial`s are singletons now. Also, hand-coded implementations for Ed25519 and Ed448 are removed. They were not used since `FieldGen` starts generating classes for them. No new regression test. This is a clean-up. - Commit messages: - the fix Changes:

Re: RFR: 8282828: CDS uncompressed oops archive is not deterministic

2022-04-29 Thread Ioi Lam
On Fri, 29 Apr 2022 22:50:45 GMT, Ioi Lam wrote: > During `java -Xshare:dump -XX:-UseCompressedOops`, the location of the Java > heap is chosen by the OS. Due to Address Space Layout Randomization, the heap > will always start at a different location. This causes the archive for >

Re: RFR: 8285915: failure_handler: gather the contents of /etc/hosts file

2022-04-29 Thread Daniel Fuchs
On Fri, 29 Apr 2022 11:28:32 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which addresses > https://bugs.openjdk.java.net/browse/JDK-8285915? > > With this change, the environment details collected by the failure handler > will now include the contents of the

Re: RFR: 8285915: failure_handler: gather the contents of /etc/hosts file

2022-04-29 Thread Jaikiran Pai
On Fri, 29 Apr 2022 11:28:32 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which addresses > https://bugs.openjdk.java.net/browse/JDK-8285915? > > With this change, the environment details collected by the failure handler > will now include the contents of the

Re: RFR: 8285915: failure_handler: gather the contents of /etc/hosts file

2022-04-29 Thread Erik Joelsson
On Fri, 29 Apr 2022 11:28:32 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which addresses > https://bugs.openjdk.java.net/browse/JDK-8285915? > > With this change, the environment details collected by the failure handler > will now include the contents of the

RFR: 8285919: Remove debug printout from JDK-8285093

2022-04-29 Thread Magnus Ihse Bursie
A debug printout in configure was introduced in JDK-8285093. It should be removed. - Commit messages: - 8285919: Remove debug printout from JDK-8285093 Changes: https://git.openjdk.java.net/jdk/pull/8467/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=8467=00 Issue:

Re: RFR: 8285915: failure_handler: gather the contents of /etc/hosts file

2022-04-29 Thread Erik Joelsson
On Fri, 29 Apr 2022 12:51:21 GMT, Jaikiran Pai wrote: > Quick question - the path you note, is that even applicable for x64? I see > that it has a "System32" so just curious. Yes, System32 is not related to 32 vs 64 bit. As I understand it, that name was introduced when moving from 16 to 32

Re: RFR: 8285919: Remove debug printout from JDK-8285093

2022-04-29 Thread Erik Joelsson
On Fri, 29 Apr 2022 12:43:02 GMT, Magnus Ihse Bursie wrote: > A debug printout in configure was introduced in JDK-8285093. It should be > removed. Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/8467

Integrated: 8285919: Remove debug printout from JDK-8285093

2022-04-29 Thread Magnus Ihse Bursie
On Fri, 29 Apr 2022 12:43:02 GMT, Magnus Ihse Bursie wrote: > A debug printout in configure was introduced in JDK-8285093. It should be > removed. This pull request has now been integrated. Changeset: 64225e19 Author:Magnus Ihse Bursie URL:

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v34]

2022-04-29 Thread Maurizio Cimadamore
On Fri, 29 Apr 2022 00:44:01 GMT, Guoxiong Li wrote: > Remind: please use the command `/jep JEP-424` [1] to mark this PR. > > [1] > https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands#PullRequestCommands-/jep Question: I'm willing to try it out. If something goes wrong - would a

Re: RFR: JDK-8285730: unify _WIN32_WINNT settings

2022-04-29 Thread Matthias Baesken
On Fri, 29 Apr 2022 05:09:35 GMT, David Holmes wrote: > That only seems to be half of the issue though. If we are defining > _WIN32_WINNT=0x0601 because the minimum required OS API support level is > Windows 7, then don't we need a check that the build platform is also at > least Windows 7?

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v35]

2022-04-29 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-424 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/424 Maurizio Cimadamore has updated the pull

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v34]

2022-04-29 Thread Guoxiong Li
On Fri, 29 Apr 2022 08:06:24 GMT, Maurizio Cimadamore wrote: > would a jep unneeded be enough to "unstuck" this PR? Yes if no bug. Conceptually, the `/jep unneeded` will behave as no jep command. - PR: https://git.openjdk.java.net/jdk/pull/7888