RFR: 8282060: RemoteRuntimeImageTest is not actually testing on JDK 8

2022-05-05 Thread Athijegannathan Sundararajan
This test requires jdk8 to be available while running jdk tests. But JDK8_HOME is defined to be BOOT_JDK and so version check fails in the test. The test vacuously passes just printing a message. There are already tests that exercise jrt-fs.jar on the same JDK being tested and so basic jrt-fs.ja

Re: RFR: 8282060: RemoteRuntimeImageTest is not actually testing on JDK 8

2022-05-05 Thread Alan Bateman
On Thu, 5 May 2022 09:00:47 GMT, Athijegannathan Sundararajan wrote: > This test requires jdk8 to be available while running jdk tests. But > JDK8_HOME is defined to be BOOT_JDK and so version check fails in the test. > The test vacuously passes just printing a message. There are already tests

Re: RFR: 8282060: RemoteRuntimeImageTest is not actually testing on JDK 8

2022-05-05 Thread Erik Joelsson
On Thu, 5 May 2022 09:00:47 GMT, Athijegannathan Sundararajan wrote: > This test requires jdk8 to be available while running jdk tests. But > JDK8_HOME is defined to be BOOT_JDK and so version check fails in the test. > The test vacuously passes just printing a message. There are already tests

Integrated: 8282060: RemoteRuntimeImageTest is not actually testing on JDK 8

2022-05-05 Thread Athijegannathan Sundararajan
On Thu, 5 May 2022 09:00:47 GMT, Athijegannathan Sundararajan wrote: > This test requires jdk8 to be available while running jdk tests. But > JDK8_HOME is defined to be BOOT_JDK and so version check fails in the test. > The test vacuously passes just printing a message. There are already tests

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v37]

2022-05-05 Thread Mandy Chung
On Wed, 4 May 2022 23:44:08 GMT, Maurizio Cimadamore wrote: >> Another option would be to treat calls to `ensureNativeAccess` with `null` >> caller class as coming from unnamed module. > > Looking deeper, `System::loadLibrary` seems to search the boot loader > libraries when invoked with a `nu

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v37]

2022-05-05 Thread Mandy Chung
On Thu, 5 May 2022 16:22:41 GMT, Mandy Chung wrote: >> Looking deeper, `System::loadLibrary` seems to search the boot loader >> libraries when invoked with a `null` caller class, so replicating that >> behavior should be safe. > > `BootLoader` is what you want in this case - it defines the stat

RFR: 8284675: "jpackage.exe" creates application launcher without Windows Application Manfiest

2022-05-05 Thread Alexey Semenyuk
Copy missing manifest-related parameters to `SetupJdkExecutable` calls building app launchers from `SetupBuildLauncher` function:https://github.com/openjdk/jdk/blob/0c3094c8186b4d53e8bad80e2369fc7b9ae9e201/make/common/modules/LauncherCommon.gmk#L174-L175 - Commit messages: - 828467

Re: RFR: 8284675: "jpackage.exe" creates application launcher without Windows Application Manfiest

2022-05-05 Thread Erik Joelsson
On Thu, 5 May 2022 19:02:51 GMT, Alexey Semenyuk wrote: > Copy missing manifest-related parameters to `SetupJdkExecutable` calls > building app launchers from `SetupBuildLauncher` > function:https://github.com/openjdk/jdk/blob/0c3094c8186b4d53e8bad80e2369fc7b9ae9e201/make/common/modules/Launche

Integrated: 8284675: "jpackage.exe" creates application launcher without Windows Application Manfiest

2022-05-05 Thread Alexey Semenyuk
On Thu, 5 May 2022 19:02:51 GMT, Alexey Semenyuk wrote: > Copy missing manifest-related parameters to `SetupJdkExecutable` calls > building app launchers from `SetupBuildLauncher` > function:https://github.com/openjdk/jdk/blob/0c3094c8186b4d53e8bad80e2369fc7b9ae9e201/make/common/modules/Launche

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v39]

2022-05-05 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-424 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/424 Maurizio Cimadamore has updated the pull request

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v37]

2022-05-05 Thread Maurizio Cimadamore
On Thu, 5 May 2022 16:39:08 GMT, Mandy Chung wrote: >> `BootLoader` is what you want in this case - it defines the static methods >> to access resources, packages etc defined to the boot loader (aka null >> `ClassLoader`). >> >> To find a symbol defined in the native libraries loaded by the bo

Re: RFR: 8282191: Implementation of Foreign Function & Memory API (Preview) [v39]

2022-05-05 Thread Mandy Chung
On Thu, 5 May 2022 20:54:53 GMT, Maurizio Cimadamore wrote: >> This PR contains the API and implementation changes for JEP-424 [1]. A more >> detailed description of such changes, to avoid repetitions during the review >> process, is included as a separate comment. >> >> [1] - https://openjdk

Withdrawn: 8282944: GHA: Add Alpine Linux x86_64 pre-integration check

2022-05-05 Thread duke
On Thu, 10 Mar 2022 09:57:17 GMT, George Adams wrote: > Adds Alpine build CI job to the GitHub actions submit.yml. I can add tests > too if people think that would be useful but for now I've left it as just > build. This pull request has been closed without being integrated. - PR