On Wed, 11 May 2022 16:00:32 GMT, Maxim Kartashev
wrote:
> This change seem to have made this group of declarations obsolete:
> `src/java.desktop/windows/native/libawt/windows/awt_Toolkit.h:157` (follow
> the
> [link](https://github.com/openjdk/jdk/blob/89de756ffbefac452c7df559e2a4eb50bf71368
On Wed, 11 May 2022 11:38:31 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which fixes build failures on macos
> when using `--with-zlib=bundled`?
>
> With this change the build now passes (tested both with bundled and system
> zlib variants).
>
> tier1, tier2 and tier3
Can I please get a review of this change to the build system which now makes
bundled zlib as the default for macos aarch64 systems?
We have been running into various intermittent failures on macos aarch64
systems for several months now. After investigation we have been able to
ascertain that t
On Thu, 12 May 2022 08:43:56 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change to the build system which now makes
> bundled zlib as the default for macos aarch64 systems?
>
> We have been running into various intermittent failures on macos aarch64
> systems for several mont
On Wed, 11 May 2022 20:55:29 GMT, Adam Farley wrote:
> These warnings are ignored while building the build+full jdks with gcc,
> but only ignored while building the full JDK if using clang. This
> produces tons of warnings we normally ignore, e.g. unused parameter.
>
> I suggest that if we're ig
(cc:ing build-dev.)
On 2022-05-12 00:17, Michael Hall wrote:
Is this restricted somehow to Mac App Store applications?
Is a warning issued as stripping native commands may break application
functionality?
Is it not possible for the user to provide their own Info.plist with a
different bund
On Thu, 12 May 2022 08:43:56 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change to the build system which now makes
> bundled zlib as the default for macos aarch64 systems?
>
> We have been running into various intermittent failures on macos aarch64
> systems for several mont
On Thu, 12 May 2022 08:43:56 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change to the build system which now makes
> bundled zlib as the default for macos aarch64 systems?
>
> We have been running into various intermittent failures on macos aarch64
> systems for several mont
On Thu, 12 May 2022 04:25:24 GMT, David Holmes wrote:
>> This change seem to have made this group of declarations obsolete:
>> `src/java.desktop/windows/native/libawt/windows/awt_Toolkit.h:157` (follow
>> the [link](
>> https://github.com/openjdk/jdk/blob/89de756ffbefac452c7df559e2a4eb50bf71368
On Thu, 12 May 2022 01:29:13 GMT, Yasumasa Suenaga wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Calculate char offset before realloc()
>
> Thanks for all to review this PR! I think we should separate this is
> On May 12, 2022, at 4:42 AM, Magnus Ihse Bursie
> wrote:
>
>> Some further spelunking reveals the issue. Consider this:
>>
>> % otool -s __TEXT __info_plist -v
>> APP_NAME.app/Contents/runtime/Contents/Home/bin/java
>> …
>>
>> CFBundleIdentifier
>> net.java.openjdk.java
>> …
>>
On 2022-05-12 13:17, Michael Hall wrote:
I had read this but possibly didn’t grok the issue myself. If I
understand correctly now the conflict isn’t within the application but
across applications to some other application that has already been
added to the Mac App Store that included the comman
On Wed, 11 May 2022 20:55:29 GMT, Adam Farley wrote:
> These warnings are ignored while building the build+full jdks with gcc,
> but only ignored while building the full JDK if using clang. This
> produces tons of warnings we normally ignore, e.g. unused parameter.
>
> I suggest that if we're ig
>
> My primary suggestion would to be to use an UUID for the unique ID. They are
> of fixed length, are for all intents and purposes unique and you can conjure
> them up from your hat. (An alternative is that the user needs to specify a
> unique ID, but that is probably a less ideal solution
On Thu, 12 May 2022 08:43:56 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change to the build system which now makes
> bundled zlib as the default for macos aarch64 systems?
>
> We have been running into various intermittent failures on macos aarch64
> systems for several mont
On 2022-05-12 04:58, Magnus Ihse Bursie wrote:
On 2022-05-12 13:17, Michael Hall wrote:
A solution like including a bundle identifier something like
net.java.openjdk.MYAPP.java would be possible at packaging time but
not at build time.
To fix this at build time you would need to generate a na
> On May 12, 2022, at 8:10 AM, Michael Hall wrote:
>
>
>
>>
>> My primary suggestion would to be to use an UUID for the unique ID. They are
>> of fixed length, are for all intents and purposes unique and you can conjure
>> them up from your hat. (An alternative is that the user needs to
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.java.net/jeps/424
Maurizio Cimadamore has updated the pull request
On Fri, 29 Apr 2022 08:29:52 GMT, Guoxiong Li wrote:
>>> Remind: please use the command `/jep JEP-424` [1] to mark this PR.
>>>
>>> [1]
>>> https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands#PullRequestCommands-/jep
>>
>> Question: I'm willing to try it out. If something goes wr
On Mon, 21 Mar 2022 10:45:27 GMT, Maurizio Cimadamore
wrote:
> This PR contains the API and implementation changes for JEP-424 [1]. A more
> detailed description of such changes, to avoid repetitions during the review
> process, is included as a separate comment.
>
> [1] - https://openjdk.jav
On Thu, 12 May 2022 04:15:50 GMT, Alexander Matveev
wrote:
>> - It is not possible to support native JDK commands such as "java" inside
>> Mac App Store bundles due to embedded info.plist. Workarounds suggested in
>> JDK-8286122 does not seems to be visible.
>> - With proposed fix we will enf
Aren't we embedding this bundle ID in every launcher, so you would
need a .template for each possible launcher that could be
included in an app?
I naively assumed that only the java launcher was needed, since this is
about packaging a Java app, so all you'd need is an entry to your main
clas
On Thu, 12 May 2022 01:29:13 GMT, Yasumasa Suenaga wrote:
>> Yasumasa Suenaga has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Calculate char offset before realloc()
>
> Thanks for all to review this PR! I think we should separate this is
>
> What you say sounds good, although I feel I only partially understand it. :-)
If it’s correct that normal applications don’t need the executable included
Info.plist and jpackage can somehow get versions that don’t include it that
seems the easiest and most hack free solution.
Apple DTS d
> What you say sounds good, although I feel I only partially understand it. :-)
If it’s correct that normal applications don’t need the executable included
Info.plist and jpackage can somehow get versions that don’t include it that
seems the easiest and most hack free solution.
Apple DTS did s
On Thu, 12 May 2022 01:27:30 GMT, Yasumasa Suenaga wrote:
>> I saw some compiler warnings when I tried to build OpenJDK with GCC 12.0.1
>> on Fedora 36.
>> As you can see, the warnings spreads several areas. Let me know if I should
>> separate them by area.
>>
>> * -Wstringop-overflow
>> *
On Thu, 12 May 2022 04:15:50 GMT, Alexander Matveev
wrote:
>> - It is not possible to support native JDK commands such as "java" inside
>> Mac App Store bundles due to embedded info.plist. Workarounds suggested in
>> JDK-8286122 does not seems to be visible.
>> - With proposed fix we will enf
> On May 12, 2022, at 3:13 PM, Magnus Ihse Bursie wrote:
>
> On Thu, 12 May 2022 04:15:50 GMT, Alexander Matveev
> wrote:
>
>>> - It is not possible to support native JDK commands such as "java" inside
>>> Mac App Store bundles due to embedded info.plist. Workarounds suggested in
>>> JDK-
On Thu, 12 May 2022 20:59:53 GMT, Michael Hall wrote:
> However, I don't know how the app is supposed to be started without a
> launcher...
jpackage supplies an alternative launcher that doesn't have plist.
-
PR: https://git.openjdk.java.net/jdk/pull/8666
On Thu, 12 May 2022 08:43:56 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change to the build system which now makes
> bundled zlib as the default for macos aarch64 systems?
>
> We have been running into various intermittent failures on macos aarch64
> systems for several mont
On Thu, 12 May 2022 08:43:56 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change to the build system which now makes
> bundled zlib as the default for macos aarch64 systems?
>
> We have been running into various intermittent failures on macos aarch64
> systems for several mont
31 matches
Mail list logo
