Re: [8u] RFR: JDK-8139813: Base heap size on type of boot jdk, not architecture of build machine

On 2015-10-19 13:54, Erik Joelsson wrote: Hello, Please review this minor configure fix. The logic in configure for setting up proper mx flags for the bootjdk is flawed in that it assumes a 64bit bootjdk if the build machine is 64bit. This patch fixes this by instead testing if the bootjdk

RFR: JDK-8139951 Do not store debug level in OPT part of Verona string

After discussion, it was decided that debug level information should not be a part of the new version string as implemented in Verona. Instead, this information should be propagated using other means. (Follow-up bugs will be filed for this). This bug removes the debug-level from the opt part

Re: RFR: 8139272: Add configure variable to set concurrency for jtreg tests

On 2015-10-14, Magnus Ihse Bursie wrote: > On 2015-10-09 14:09, Erik Helin wrote: > >Hi all, > > > >this patch adds a new configure variable: --with-test-jobs. The new > >variable configures how many tests jobs we run concurrently (aka the > >-concurrency flag to JTReg). Today --with-jobs is

Re: hardcoding -m32/-m64 is more harmful than using the toolchain defaults

On 20.10.2015 09:36, David Holmes wrote: On 20/10/2015 6:50 AM, Matthias Klose wrote: I'm working around some build failures for zero targets, which fail to build because the configury in openjdk tries to set -m32/-m64 on it's own. I assume this behaviour was added for sun/oracle product

Re: [patch] fix the build with a toolchain with a linker defaulting to ld --as-needed

On 20.10.2015 10:28, Erik Joelsson wrote: Hello Matthias, I think this looks good and can sponsor the push for you. Have you signed the OCA? see http://www.oracle.com/technetwork/community/oca-486395.html#k /Erik On 2015-10-19 22:06, Matthias Klose wrote: Toolchains for some Linux

Re: hardcoding -m32/-m64 is more harmful than using the toolchain defaults

On 2015-10-20 14:14, Matthias Klose wrote: On 20.10.2015 09:36, David Holmes wrote: On 20/10/2015 6:50 AM, Matthias Klose wrote: I'm working around some build failures for zero targets, which fail to build because the configury in openjdk tries to set -m32/-m64 on it's own. I assume this

Re: hardcoding -m32/-m64 is more harmful than using the toolchain defaults

On 20/10/2015 6:50 AM, Matthias Klose wrote: I'm working around some build failures for zero targets, which fail to build because the configury in openjdk tries to set -m32/-m64 on it's own. I assume this behaviour was added for sun/oracle product builds to build x86 and x86_64 targets on a

Re: [patch] fix the build with a toolchain with a linker defaulting to ld --as-needed

Hello Matthias, I think this looks good and can sponsor the push for you. Have you signed the OCA? /Erik On 2015-10-19 22:06, Matthias Klose wrote: Toolchains for some Linux distributions (e.g. Ubuntu, OpenSuse) are configured to pass --as-needed to the linker by default, only linking with

Re: RFR: 8139271: Add top-level Makefile target to run hotspots jtreg tests

On 2015-10-09, Magnus Ihse Bursie wrote: > Looks good to me. Thanks! Erik > /Magnus > > > 9 okt 2015 kl. 14:23 skrev Erik Helin : > > > > Hi all, > > > > this patch adds a new top-level Makefile to run the hotspot jtreg tests. > > This is already possible today by

Re: [8u] RFR: JDK-8139813: Base heap size on type of boot jdk, not architecture of build machine

On 10/20/15 05:59, Magnus Ihse Bursie wrote: On 2015-10-20 10:20, Erik Joelsson wrote: Hello, New webrevs implementing the suggestion by Magnus. Webrev JDK 9: http://cr.openjdk.java.net/~erikj/8139813/webrev.jdk9.02/ Webrev JDK 8u: http://cr.openjdk.java.net/~erikj/8139813/webrev.jdk8u.02/

Re: RFR: JDK-8139951 Do not store debug level in OPT part of Verona string

Looks good to me as well. /Tim On 10/20/15 02:45, Erik Joelsson wrote: Looks good to me. Nice to see all that nastiness disappear. /Erik On 2015-10-20 11:11, Magnus Ihse Bursie wrote: After discussion, it was decided that debug level information should not be a part of the new version

RFR (XXS): 8139935: Bootcycle builds are broken on jdk9/hs due to JVMCI changes

https://bugs.openjdk.java.net/browse/JDK-8139935 The reason this “works” for a non-bootcycle build is because a JDK 9 javac won't enforce the “hidden packages” rules when running on a non-JDK 9 platform. diff -r a8a8604f890f make/gensrc/Gensrc-jdk.vm.ci.gmk ---

Re: [patch] correctly detect 32bit platforms

On 2015-10-19 22:16, Matthias Klose wrote: Sorry if this is the wrong ML, but this results in hotspot build failures on various 32bit zero targets. As you're probably aware by now, build questions should be directed to build-dev@openjdk.java.net. :-) common/autoconf/boot-jdk.m4 uses

Re: hardcoding -m32/-m64 is more harmful than using the toolchain defaults

On 20/10/2015 10:14 PM, Matthias Klose wrote: On 20.10.2015 09:36, David Holmes wrote: On 20/10/2015 6:50 AM, Matthias Klose wrote: I'm working around some build failures for zero targets, which fail to build because the configury in openjdk tries to set -m32/-m64 on it's own. I assume this

Re: [8u] RFR: JDK-8139813: Base heap size on type of boot jdk, not architecture of build machine

On 2015-10-20 10:20, Erik Joelsson wrote: Hello, New webrevs implementing the suggestion by Magnus. Webrev JDK 9: http://cr.openjdk.java.net/~erikj/8139813/webrev.jdk9.02/ Webrev JDK 8u: http://cr.openjdk.java.net/~erikj/8139813/webrev.jdk8u.02/ Looks good. This version was even better than I

Re: hardcoding -m32/-m64 is more harmful than using the toolchain defaults

On 10/20/2015 01:57 PM, Magnus Ihse Bursie wrote: > What does x86_64-linux-gnux32 imply? Some sort of mix between 32 and 64-bit? I think that's a 32-bit ABI running on a 64-bit processor. https://en.wikipedia.org/wiki/X32_ABI If so, I'm surprised it works at all. Andrew.