Re: [9] RFR (xs) 8168317: [JVMCI] use reflection instead of jdk 9 Module API in Services.java

2016-10-24 Thread Christian Thalinger
> On Oct 24, 2016, at 3:48 AM, Erik Joelsson wrote: > > Adding build-dev, which should be included when discussing build issues. For > any new readers, please see [1] for the full discussion. > In theory it is possible to compile against and run on the exploded image

Re: [9] RFR (xs) 8168317: [JVMCI] use reflection instead of jdk 9 Module API in Services.java

2016-10-24 Thread Vladimir Kozlov
Thank you, Erik, for explanation. Then I will go with the reflection solution. We can revert/simplify it in JDK 10 when jdk 9 will be used as boot JDK. Thanks, Vladimir On 10/24/16 6:48 AM, Erik Joelsson wrote: Adding build-dev, which should be included when discussing build issues. For any

Re: RFR: 8167600 jib make run-test for langtools and intermittent failures on windows-x86

2016-10-24 Thread Tim Bell
Erik: Hello, Isn't it the sun.arch.data.model of TESTJAVA that we are actually interested in? You are correct. JDK-8168369 is the follow-up bug report. Tim

Re: [9] RFR (xs) 8168317: [JVMCI] use reflection instead of jdk 9 Module API in Services.java

2016-10-24 Thread Erik Joelsson
Adding build-dev, which should be included when discussing build issues. For any new readers, please see [1] for the full discussion. In theory it is possible to compile against and run on the exploded image during the build, but I do not recommend it. Igor is correct in the build team being

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

2016-10-24 Thread Erik Joelsson
The last change looks good and simple to me. /Erik On 2016-10-21 06:55, Pete Brunet wrote: Please see the latest update http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.02/ The fix now is to simply remove the copy of the AccessBridgeCalls.c file into the JDK. AccessBridgeCalls.c is

Re: Fwd: the Minimum set when install jdk8u

2016-10-24 Thread Erik Joelsson
Hello, In jdk8u you can build the compact profiles using "make profiles". In the outputdir, you then get 3 levels of stripped down versions of the JRE. You will need to figure out which one you need depending on what parts of the class libraries you actually use in your application. The

Re: RFR: 8165804: Revisit the way of loading BreakIterator rules/dictionaries

2016-10-24 Thread Erik Joelsson
Build change looks good. /Erik On 2016-10-20 10:33, Masayoshi Okutsu wrote: Hi, Please review the changes for JDK-8165804 which is a follow-up of JDK-8076757. Some notes on the changes. - Removed INCLUDES := $(TEXT_PKG_LD) from make/gendata/GendataBreakIterator.gmk in order to avoid

Re: RFR: 8167600 jib make run-test for langtools and intermittent failures on windows-x86

2016-10-24 Thread Erik Joelsson
Hello, Isn't it the sun.arch.data.model of TESTJAVA that we are actually interested in? /Erik On 2016-10-19 15:00, Magnus Ihse Bursie wrote: On 2016-10-18 06:44, Tim Bell wrote: Magnus: Thank you for the feedback. See below: On 2016-10-15 03:23, Tim Bell wrote: Please review this

Re: RFR(S): 8168483 Remove jtreg timeout handler timeout

2016-10-24 Thread Staffan Larsen
Thank David! > On 22 Oct 2016, at 02:24, David Holmes wrote: > > Looks fine. > > Thanks, > David > > On 21/10/2016 11:24 PM, Staffan Larsen wrote: >> When we run jtreg in the hotspot, jdk and nashorn folders we run it with the >> timeout handler found under

Re: RFR(S): 8168483 Remove jtreg timeout handler timeout

2016-10-24 Thread Staffan Larsen
Thanks Tim! > On 22 Oct 2016, at 05:21, Tim Bell wrote: > > Looks good to me as well. > > Tim > > On 10/21/16 17:24, David Holmes wrote: >> Looks fine. >> >> Thanks, >> David >> >> On 21/10/2016 11:24 PM, Staffan Larsen wrote: >>> When we run jtreg in the hotspot, jdk