Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

Updated build webrevs (webrev.2) http://cr.openjdk.java.net/~kvn/aot/top.webrev.2/ http://cr.openjdk.java.net/~kvn/aot/hs.make.webrev.2/ Use one ENABLE_AOT variable in all config and make files (removed NEEDS_LIB_JELFSHIM). Moved HOTSPOT_SETUP_JVM_FEATURES after LIB_SETUP_LIBRARIES. First,

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

> On Oct 28, 2016, at 3:19 PM, Vladimir Kozlov > wrote: > The alternative is to declare `uses` and `provides` in module-info.java in the source repo so that a reader can see the module descriptor content without needing to do a build. >>> What

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

> On Oct 28, 2016, at 1:59 PM, Philip Race wrote: > > If it is not in the image then there is no point in the file existing. > Maybe this could just be a comment at the top of the include file. > This works for me. Mandy > -phil. > > On 10/28/16, 12:42 PM, Mandy

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

The alternative is to declare `uses` and `provides` in module-info.java in the source repo so that a reader can see the module descriptor content without needing to do a build. What is "a reader”? A person reading the code. I don't think it will help "reader" to have 174 lines which are

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

> On Oct 28, 2016, at 11:23 AM, Mandy Chung wrote: > >> >> On Oct 28, 2016, at 1:52 PM, Vladimir Kozlov >> wrote: >> >> Thank you, Mandy >> >> On 10/28/16 1:31 PM, Mandy Chung wrote: >>> On Oct 26, 2016, at 5:45 PM, Vladimir Kozlov

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

> On Oct 28, 2016, at 1:52 PM, Vladimir Kozlov > wrote: > > Thank you, Mandy > > On 10/28/16 1:31 PM, Mandy Chung wrote: >> >>> On Oct 26, 2016, at 5:45 PM, Vladimir Kozlov >>> wrote: >>> >>>

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

If it is not in the image then there is no point in the file existing. Maybe this could just be a comment at the top of the include file. -phil. On 10/28/16, 12:42 PM, Mandy Chung wrote: On Oct 28, 2016, at 11:32 AM, Pete Brunet wrote: Hi Mandy, That simplifies

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

> On Oct 26, 2016, at 5:45 PM, Vladimir Kozlov > wrote: > > http://cr.openjdk.java.net/~kvn/aot/hs.make.webrev/ make/gensrc/Gensrc-jdk.vm.compiler.gmk This generates module-info.java.extra at build time to augment module-info.java with `uses` and `provides`.

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

It's in the image so users of the headers in the image will know where to go find the .c file. Users might be able to figure out how to use the API without having to hunt down the documentation. But please discuss with Phil. I will also be updating the documentation via

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

> On Oct 28, 2016, at 11:32 AM, Pete Brunet wrote: > > Hi Mandy, That simplifies things. The new patch is at: > http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.08/ Looks better. I only notice now that the readme.html is in the include directory. That

Re: RfR JDK-8167213 Move include/bridge/AccessBridgeCalls.c to the source directory

Hi Mandy, That simplifies things. The new patch is at: http://cr.openjdk.java.net/~ptbrunet/JDK-8167213/webrev.08/ Pete On 10/27/16 6:51 PM, Mandy Chung wrote: >> On Oct 27, 2016, at 4:31 PM, Pete Brunet wrote: >> >> I moved the source to >>

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

I got some data. It is about 10% increase size with -g: product build, no -g for AOT modules 191173 Oct 28 09:15 build/product/images/jmods/jdk.aot.jmod 4893583 Oct 28 09:16 build/product/images/jmods/jdk.vm.compiler.jmod 352073 Oct 28 09:15 build/product/images/jmods/jdk.vm.ci.jmod

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

Thank you, Andrew, for verifying that build changes do not break AArch64. But it would be nice if you can also apply Hotspot changes (revert hs.make.webrev changes before that since hs.webrev have them): http://cr.openjdk.java.net/~kvn/aot/hs.webrev/ and jaotc sources (which are located in

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

Volker, Patch for aot sources is tracked by: 8166415: Integrate AOT tool JAOTC http://cr.openjdk.java.net/~kvn/aot/jaotc.webrev/ JAOTC code is in Hotspot, not in JDK, repo. Vladimir On 10/28/16 2:09 AM, Volker Simonis wrote: On Fri, Oct 28, 2016 at 10:57 AM, Erik Joelsson

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

On 28/10/16 08:56, Vladimir Kozlov wrote: > Webrevs updated in place (please, reload webpage to get new version). > generated-configure.sh changes are included. > > http://cr.openjdk.java.net/~kvn/aot/top.webrev/ > http://cr.openjdk.java.net/~kvn/aot/jdk.webrev/ >

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

On 2016-10-28 11:09, Volker Simonis wrote: On Fri, Oct 28, 2016 at 10:57 AM, Erik Joelsson wrote: Hello, On 2016-10-28 09:56, Vladimir Kozlov wrote: Webrevs updated in place (please, reload webpage to get new version). generated-configure.sh changes are included.

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

On Fri, Oct 28, 2016 at 10:57 AM, Erik Joelsson wrote: > Hello, > > > On 2016-10-28 09:56, Vladimir Kozlov wrote: >> >> Webrevs updated in place (please, reload webpage to get new version). >> generated-configure.sh changes are included. >> >>

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

Hello, On 2016-10-28 09:56, Vladimir Kozlov wrote: Webrevs updated in place (please, reload webpage to get new version). generated-configure.sh changes are included. http://cr.openjdk.java.net/~kvn/aot/top.webrev/ http://cr.openjdk.java.net/~kvn/aot/jdk.webrev/

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

On 28/10/2016 09:34, Erik Joelsson wrote: but maybe jlink is able to strip the debug info from java classes now? In that case we could consider globally enabling -g for product builds. Yes, it can, `jlink --strip-debug` (or `-G`). A good test would be to build with `javac -g` and then strip

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

On 2016-10-27 20:18, Doug Simon wrote: On 27 Oct 2016, at 20:12, Vladimir Kozlov wrote: On 10/27/16 10:55 AM, Christian Thalinger wrote: On Oct 27, 2016, at 2:40 AM, Erik Joelsson wrote: On 2016-10-27 02:45, Vladimir Kozlov wrote:

Re: [9] RFR(M) 8166416: [AOT] Integrate JDK build changes and launcher 'jaotc' for AOT compiler

Webrevs updated in place (please, reload webpage to get new version). generated-configure.sh changes are included. http://cr.openjdk.java.net/~kvn/aot/top.webrev/ http://cr.openjdk.java.net/~kvn/aot/jdk.webrev/ http://cr.openjdk.java.net/~kvn/aot/hs.make.webrev/ libelfshim generation is guarded