Re: RFR: JDK-8170632 Stop modifying VERSION_OPT for adhoc builds on reconfigure

2016-12-01 Thread David Holmes
On 2/12/2016 8:39 AM, Magnus Ihse Bursie wrote: Our current default is to create a version-opt string on the format '..' during configure. The problem with this is that each time the configure script has change, a reconfigure is triggered. This will create a new version-opt, and hence a new

RFR: JDK-8170632 Stop modifying VERSION_OPT for adhoc builds on reconfigure

2016-12-01 Thread Magnus Ihse Bursie
Our current default is to create a version-opt string on the format '..' during configure. The problem with this is that each time the configure script has change, a reconfigure is triggered. This will create a new version-opt, and hence a new version string. This in turn will trigger a

Re: RFR: JDK-8056215 AWT source dirs should only point to java2d, not below

2016-12-01 Thread Erik Joelsson
Looks good. /Erik On 2016-12-01 12:42, Magnus Ihse Bursie wrote: On 2016-11-28 11:01, Erik Joelsson wrote: It looks like this will result in the same files being built, but just to be sure, have you verified the result to be equal? I thought I had done that, but it turned out I used an

Re: RFR: JDK-8056215 AWT source dirs should only point to java2d, not below

2016-12-01 Thread Magnus Ihse Bursie
On 2016-11-28 11:01, Erik Joelsson wrote: It looks like this will result in the same files being built, but just to be sure, have you verified the result to be equal? I thought I had done that, but it turned out I used an incorrect command line so I didn't verify anything. A proper verification

Re: RFR: JDK-8170576 Silence error message in compare.sh when selecting images

2016-12-01 Thread Erik Joelsson
Looks good /Erik On 2016-12-01 09:31, Magnus Ihse Bursie wrote: If compare.sh does not find any images, as the last test it will look for licensee-src, using $(ls .../*/...). If this does not match any directories, ls will write an error message to stderr which will leak through. Bug:

Re: RFR: JDK-8164304: JDK should build with Oracle Developer Studio

2016-12-01 Thread Magnus Ihse Bursie
On 2016-11-30 17:14, Erik Joelsson wrote: This patch slightly adjusts the matching pattern which identifies the C/C++ compilers as Solaris Studio/Oracle Developer Studio so that the new output of 12.5 is also matched. Note that this only makes configure accept the new version as a valid

RFR: JDK-8170576 Silence error message in compare.sh when selecting images

2016-12-01 Thread Magnus Ihse Bursie
If compare.sh does not find any images, as the last test it will look for licensee-src, using $(ls .../*/...). If this does not match any directories, ls will write an error message to stderr which will leak through. Bug: https://bugs.openjdk.java.net/browse/JDK-8170576 Patch inline: diff