Re: RFR JDK-8173140: To upgrade bundled zlib version from 1.2.8 to 1.2.11

2017-01-21 Thread Xueming Shen
Erik, Alan Here is the webrev that dropped the version number from the name. http://cr.openjdk.java.net/~sherman/8173140/webrev Thanks, Sherman On 1/21/17, 12:30 AM, Erik Joelsson wrote: Hello, Build changes look ok. I'm in favor with dropping the version number from the path. There is a

Re: RFR: 8160881: Remove jvisualvm from JDK9

2017-01-21 Thread Kumar Srinivasan
Looks good On 2017-01-18 18:57, Henry Jen wrote: Hi, Please review the webrev to remove jvisualvm from JDK9. http://cr.openjdk.java.net/~henryjen/jdk9/8160881/jdk/webrev/ Looks good to me. /Magnus

Re: RFR JDK-8173140: To upgrade bundled zlib version from 1.2.8 to 1.2.11

2017-01-21 Thread Alan Bateman
On 20/01/2017 20:15, Xueming Shen wrote: Hi, Please review the change to upgrade the zlib bundled in jdk repo from v1.2.8 to v1.2.11. jdk9 by default has been configured to build by using the native/ platform/os's zlib on all non-windows platform [1] So the change will only have effect on

Re: RFR JDK-8173140: To upgrade bundled zlib version from 1.2.8 to 1.2.11

2017-01-21 Thread Thomas Stüfe
Hi, On Sat, Jan 21, 2017 at 9:30 AM, Erik Joelsson wrote: > Hello, > > Build changes look ok. I'm in favor with dropping the version number from > the path. There is a README that clearly states the current version and we > don't keep multiple versions in the repo

Re: RFR JDK-8173140: To upgrade bundled zlib version from 1.2.8 to 1.2.11

2017-01-21 Thread Erik Joelsson
Hello, Build changes look ok. I'm in favor with dropping the version number from the path. There is a README that clearly states the current version and we don't keep multiple versions in the repo anyway. Doing so would also reduce repo meta data bloat from doing these upgrades in the future