Re: RFR: JDK-8029942: Update VERSION_MAJOR for JDK 10

2017-01-26 Thread David Holmes
Hi Erik, As now discovered the version can't be updated until quite a few changes are made in hotspot due to deprecated/obsolete option handling. https://bugs.openjdk.java.net/browse/JDK-8173421 I would suggest that this bug be taken over by hotspot team (maybe me :) ) and that everything

Re: configure - gcc >4.6 needed for JDK9 build

2017-01-26 Thread Mike Burton
OK so I tried bash configure --with-stdc++lib=dynamic --disable-warnings-as-errors --disable-hotspot-gtest make clean images And it worked OK. Mike > On 26 Jan 2017, at 17:36, Andrew Haley wrote: > > On 26/01/17 17:33, Mike Burton wrote: >> /usr/bin/ld:

Re: RFR: JDK-8170483: Remove modules_src_jake workaround for JavaFX transition to new module-info syntax

2017-01-26 Thread Mandy Chung
> On Jan 26, 2017, at 6:36 AM, Erik Joelsson wrote: > > When the last jake->jdk9 push was done, a temporary workaround for dealing > with Javafx was needed. Javafx has now been fully updated to only deliver the > new format so the workaround should be removed. > >

Re: configure - gcc >4.6 needed for JDK9 build

2017-01-26 Thread Andrew Haley
On 26/01/17 17:33, Mike Burton wrote: > /usr/bin/ld: /usr/lib/gcc/x86_64-linux-gnu/4.6/libstdc++.a(ctype.o): > relocation R_X86_64_32S against `vtable for std::ctype' can not be > used when making a shared object; recompile with -fPIC > /usr/lib/gcc/x86_64-linux-gnu/4.6/libstdc++.a: could not

Re: configure - gcc >4.6 needed for JDK9 build

2017-01-26 Thread Mike Burton
I get the same error as before, eventually: 1. First of all failed writing to failure-logs/ This seems to happen on every clean” build, could it be fixed? I needed to mkdir -p /home/openjdk/dev/jdk9/build/linux-x86_64-normal-server-release/make-support/failure-logs 2. The error from 1. was:

RE: RFR: JDK-8029942: Update VERSION_MAJOR for JDK 10

2017-01-26 Thread Iris Clark
Hi, Erik. Your change looks good. Thanks, iris -Original Message- From: Erik Joelsson Sent: Thursday, January 26, 2017 5:57 AM To: build-dev Subject: RFR: JDK-8029942: Update VERSION_MAJOR for JDK 10 The default major version for the jdk 10 repos needs to be updated from 9 to 10.

Re: configure - gcc >4.6 needed for JDK9 build

2017-01-26 Thread Erik Joelsson
The option is --disable-hotspot-gtest. /Erik On 2017-01-26 16:55, Mike Burton wrote: When I do `bash configure —disable-gtest` it errors with: unrecognised options: —disable-gtest Mike On 26 Jan 2017, at 15:36, Magnus Ihse Bursie wrote: This is an issue

Re: configure - gcc >4.6 needed for JDK9 build

2017-01-26 Thread Mike Burton
When I do `bash configure —disable-gtest` it errors with: unrecognised options: —disable-gtest Mike > On 26 Jan 2017, at 15:36, Magnus Ihse Bursie > wrote: > > This is an issue with gtest, which is a bit special. > > If you use --disable-gtest with configure,

Re: configure - gcc >4.6 needed for JDK9 build

2017-01-26 Thread Magnus Ihse Bursie
This is an issue with gtest, which is a bit special. If you use --disable-gtest with configure, can you build successfully then? /Magnus > 25 jan. 2017 kl. 09:34 skrev Mike Burton : > > >>> On 24 Jan 2017, at 21:25, Kim Barrett wrote: >>> >>>

Re: RFR: JDK-8170483: Remove modules_src_jake workaround for JavaFX transition to new module-info syntax

2017-01-26 Thread Alan Bateman
On 26/01/2017 14:36, Erik Joelsson wrote: When the last jake->jdk9 push was done, a temporary workaround for dealing with Javafx was needed. Javafx has now been fully updated to only deliver the new format so the workaround should be removed. Bug:

RFR: JDK-8170483: Remove modules_src_jake workaround for JavaFX transition to new module-info syntax

2017-01-26 Thread Erik Joelsson
When the last jake->jdk9 push was done, a temporary workaround for dealing with Javafx was needed. Javafx has now been fully updated to only deliver the new format so the workaround should be removed. Bug: https://bugs.openjdk.java.net/browse/JDK-8170483 Webrev:

Re: RFR: JDK-8081694 Remove DISABLED_WARNINGS_gcc for libsctp

2017-01-26 Thread Chris Hegarty
I’m not sure of the latest status of warnings in the build, but just to say, libstcp was always built with 0 warnings being emitted ( the JNI code has unused this/class parameters that cannot be removed ). If you remove this suppression won’t the compilation of code from libsctp now produce a

Re: RFR: JDK-8029942: Update VERSION_MAJOR for JDK 10

2017-01-26 Thread Philip Race
+1 -phil. On 1/26/17, 5:56 AM, Erik Joelsson wrote: The default major version for the jdk 10 repos needs to be updated from 9 to 10. Bug: https://bugs.openjdk.java.net/browse/JDK-8029942 Patch: diff -r 07f6f1f4140e common/autoconf/version-numbers --- a/common/autoconf/version-numbers +++

Re: RFR: JDK-8081694 Remove DISABLED_WARNINGS_gcc for libsctp

2017-01-26 Thread Erik Joelsson
Looks good. /Erik On 2017-01-26 14:54, Magnus Ihse Bursie wrote: When fixing JDK-8081616 , it turned out that DISABLED_WARNINGS_gcc := unused-parameter seemed to be needed for libsctp in make/lib/Lib-jdk.sctp.gmk. This is not be needed

RFR: JDK-8029942: Update VERSION_MAJOR for JDK 10

2017-01-26 Thread Erik Joelsson
The default major version for the jdk 10 repos needs to be updated from 9 to 10. Bug: https://bugs.openjdk.java.net/browse/JDK-8029942 Patch: diff -r 07f6f1f4140e common/autoconf/version-numbers --- a/common/autoconf/version-numbers +++ b/common/autoconf/version-numbers @@ -25,7 +25,7 @@ #

RFR: JDK-8081694 Remove DISABLED_WARNINGS_gcc for libsctp

2017-01-26 Thread Magnus Ihse Bursie
When fixing JDK-8081616 , it turned out that DISABLED_WARNINGS_gcc := unused-parameter seemed to be needed for libsctp in make/lib/Lib-jdk.sctp.gmk. This is not be needed anymore (and possibly never was). Bug:

Re: RFR [9] Warning notice for types in Incubator Modules

2017-01-26 Thread Magnus Ihse Bursie
On 2017-01-25 13:51, Chris Hegarty wrote: On 24 Jan 2017, at 16:44, Erik Joelsson wrote: Hello, Build changes look good except for one thing. In Javadoc.gmk, the dependency on $(BUILD_TOOLS_JDK) needs to be set for $$($1_INDEX_FILE) (on line 317), where the actual