Re: Building hsdis?

2017-12-20 Thread David Buck
Hi Ted! For Windows, I have found the instructions listed here to be the most helpful: https://dropzone.nfshost.com/hsdis.htm I recommend building on Cygwin as described above. You will need the MinGW packages installed in your Cygwin environment (also described in the above post). We

Re: Building hsdis?

2017-12-20 Thread Ted Neward
OK, built flawlessly. Couple of notes: (*) When I tried to do "make both", as mentioned in the README, it failed in the configure step: "C compiler cannot create executables". This was after "make all64" worked flawlessly. (Both have the BINUTILS variable set via the command-line; I'm eliding

Re: RFR: 8192837 Need new test for release file info

2017-12-20 Thread David Holmes
On 21/12/2017 2:51 AM, Randy Crihfield wrote: Could this be it? http://cr.openjdk.java.net/~shurailine/8192837/webrev.04/ 29 * @run testing NegReleaseSOURCE If you are going to write a jtreg test you have to actually run it under jtreg! That @run line is invalid - "testing" is not an @run

Re: RFR: 8192837 Need new test for release file info

2017-12-20 Thread Randy Crihfield
Could this be it? http://cr.openjdk.java.net/~shurailine/8192837/webrev.04/ Thanks! Randy On 12/20/17 04:51 AM, David Holmes wrote: On 20/12/2017 2:23 AM, Randy Crihfield wrote: This ought to be what you were asking for. http://cr.openjdk.java.net/~shurailine/8192837/webrev.03/ Closer

Re: RFR [jdk8] : 8193807 : AIX: avoid UnsatisfiedLinkError by providing empty basic implementations of getSystemCpuLoad and getProcessCpuLoad

2017-12-20 Thread Erik Joelsson
Looks ok to me. /Erik On 2017-12-20 10:32, Volker Simonis wrote: Hi Matthias, the change looks good! I can sponsor it once we get the approval. Also forwarded to buil-dev for the minimal build change. Thank you and best regards, Volker On Wed, Dec 20, 2017 at 9:50 AM, Baesken, Matthias

Re: Building hsdis?

2017-12-20 Thread Volker Simonis
On Wed, Dec 20, 2017 at 10:40 AM, David Buck wrote: > Hi Ted! > >> BTW, I'm sure there's a good reason for this, but why doesn't >> OpenJDK/Oracle offer pre-built versions of hsdis for a variety of common >> platforms? Is there a licensing issue? > > Yes, binutils is GPL 3,

Re: RFR: 8192837 Need new test for release file info

2017-12-20 Thread David Holmes
On 20/12/2017 2:23 AM, Randy Crihfield wrote: This ought to be what you were asking for. http://cr.openjdk.java.net/~shurailine/8192837/webrev.03/ Closer :) A few nits: - the test needs a proper @run tag - NegSOURCE is hardly informative - how about CheckReleaseFile? - there are a couple of

Re: Building hsdis?

2017-12-20 Thread David Buck
Hi Ted! > BTW, I'm sure there's a good reason for this, but why doesn't OpenJDK/Oracle offer pre-built versions of hsdis for a variety of common platforms? Is there a licensing issue? Yes, binutils is GPL 3, and OpenJDK is under GPL 2. We are very aware of this as a pain point and are

Re: Building hsdis?

2017-12-20 Thread Ted Neward
Sorry--I was cribbing from here (https://www.chrisnewland.com/building-hsdis-on-linux-amd64-on-debian-369) and it references using 2.23, which memory transposed to 2.32, I think. I'm not sure what was going wrong (well, I can tell you what the errors were, but I dunno what was causing them),

Re: RFR [jdk8] : 8193807 : AIX: avoid UnsatisfiedLinkError by providing empty basic implementations of getSystemCpuLoad and getProcessCpuLoad

2017-12-20 Thread Volker Simonis
Hi Matthias, the change looks good! I can sponsor it once we get the approval. Also forwarded to buil-dev for the minimal build change. Thank you and best regards, Volker On Wed, Dec 20, 2017 at 9:50 AM, Baesken, Matthias wrote: > Hello , Mark reported this issue

Re: Building hsdis?

2017-12-20 Thread David Buck
Hi Ted! > the version of binutils (I was using 2.32) Not sure what that is. Latest binutils is 2.29.1. > I was doing make BINUTILS= ARCH=amd64 That should also work, but I'd still keep things simple and just specify the "all64" make target. As always, whatever is documented in the README

Re: Building hsdis?

2017-12-20 Thread Ted Neward
I will give this a shot tomorrow; I can see two things already that I did that was different, the version of binutils (I was using 2.32) and the make command (I was doing make BINUTILS= ARCH=amd64 from the hsdis directory itself inside the jdk source. Do I need to clone the hs repo on its own?

Re: RFR: JDK-8193512: remove remnants of javah from jdk/jdk10 repo

2017-12-20 Thread Alan Bateman
On 19/12/2017 21:52, Jonathan Gibbons wrote: Please review these changes to remove the remnants of javah (and in a couple of tests, some remnants of apt and an earlier version of javap) from the repo, now that the tool itself has been removed. JBS:

Re: Building hsdis?

2017-12-20 Thread David Buck
Hi Ted! No blog to point you to, but building on non-Windows platforms should be pretty painless these days. > then tried again with the JDK source Yes, that is the one to use. The makefile had a number of issues that I fixed recently but have not (yet) backported to 8u-dev. I was able to