Re: bash configure fails on missing VS tools dir

2018-01-04 Thread Nir Lisker
Great. I don't think I can Watch or comment on the JIRA issue because I don't have an account, and also I'm not registered on build-dev mailing list, so if some system or build/configure info is needed I can be contacted in this email. - Nir On Thu, Jan 4, 2018 at 6:09 PM, Erik Joelsson

Re: bash configure fails on missing VS tools dir

2018-01-04 Thread Erik Joelsson
Thanks! I've filed https://bugs.openjdk.java.net/browse/JDK-8194645 /Erik On 2018-01-04 16:30, Nir Lisker wrote: Yeah, make also completed successfully: Finished building target 'default (exploded-image)' in configuration 'windows-x86_64-normal-server-release' This is what I did in

Re: bash configure fails on missing VS tools dir

2018-01-04 Thread Nir Lisker
Yeah, make also completed successfully: Finished building target 'default (exploded-image)' in configuration 'windows-x86_64-normal-server-release' This is what I did in toolchain_windows.m4: if test "x$OPENJDK_TARGET_CPU_BITS" = x32; then VCVARSFILE="vc/bin/vcvars32.bat" else #

Re: bash configure fails on missing VS tools dir

2018-01-04 Thread Erik Joelsson
If this works for you, we should update configure to look for both. /Erik On 2018-01-04 14:51, Nir Lisker wrote: It seems to have accepted vcvarsx86_amd64.bat quietly. Configure succeeded: Tools summary: * Environment:    cygwin version 2.9.0(0.318/5/3) (root at /cygdrive/c/cygwin64) *

Re: bash configure fails on missing VS tools dir

2018-01-04 Thread Nir Lisker
It seems to have accepted vcvarsx86_amd64.bat quietly. Configure succeeded: Tools summary: * Environment:cygwin version 2.9.0(0.318/5/3) (root at /cygdrive/c/cygwin64) * Boot JDK: java version "9" Java(TM) SE Runtime Environment (build 9+181) Java HotSpot(TM) 64-Bit Server VM (build

Re: bash configure fails on missing VS tools dir

2018-01-04 Thread Erik Joelsson
On 2018-01-04 12:45, Nir Lisker wrote: Yes, that did it, autegen.sh completed successfully. Thanks. Now the next problem with "bash configure": configure: error: Target CPU mismatch. We are building for x86_64 but CL is for "x86"; expected "x64". If that's the cl.exe which is in the same

Re: bash configure fails on missing VS tools dir

2018-01-04 Thread Nir Lisker
Yes, that did it, autegen.sh completed successfully. Thanks. Now the next problem with "bash configure": configure: error: Target CPU mismatch. We are building for x86_64 but CL is for "x86"; expected "x64". If that's the cl.exe which is in the same folder as vcvars, I noticed that in

Re: bash configure fails on missing VS tools dir

2018-01-04 Thread Erik Joelsson
I think you also need the "Wrapper scripts for autoconf commands". Was a long time since I did this. /Erik On 2018-01-04 11:40, Nir Lisker wrote: I get "-bash: autoconf: command not found". Here's an image of the autoconf packages in the cygwin installer in case I didn't install the right

Re: bash configure fails on missing VS tools dir

2018-01-04 Thread Nir Lisker
I get "-bash: autoconf: command not found". Here's an image of the autoconf packages in the cygwin installer in case I didn't install the right one: https://i.imgur.com/V3GMg9Y.png Do I need to add some directory to the PATH env variable? I'd imagine cygwin would know where it installed it. -

Re: RFR: JDK-8194141: Remove JDK9Wrappers

2018-01-04 Thread Erik Joelsson
Looks good to me. /Erik On 2018-01-03 23:42, Jonathan Gibbons wrote: Updated webrev, reverting unnecessary change to generated-configure.sh http://cr.openjdk.java.net/~jjg/8194141/webrev.01/ -- Jon On 01/03/2018 01:44 PM, Jonathan Gibbons wrote: Please review this code to remove a

Re: bash configure fails on missing VS tools dir

2018-01-04 Thread Erik Joelsson
Can you run "autoconf --version" on the command line? /Erik On 2018-01-03 16:33, Nir Lisker wrote: Hello Erik, I installed autoconf 2.69-3 through cygwin (indeed it was listed as 2.5). However, running "bash autogen.sh" still gives: You need autoconf installed to be able to regenerate the

Re: RFR: JDK-8194141: Remove JDK9Wrappers

2018-01-04 Thread Alan Bateman
On 03/01/2018 22:42, Jonathan Gibbons wrote: Updated webrev, reverting unnecessary change to generated-configure.sh http://cr.openjdk.java.net/~jjg/8194141/webrev.01/ This cleanup looks good to me. -Alan