Re: RFR: [OpenJDK 2D-Dev] JDK-8215296 do not disable c99 on Solaris

2018-12-19 Thread David Holmes
On 20/12/2018 1:31 am, Baesken, Matthias wrote: Sounds like a simpler change, at least for now. Does it pass jdk-submit? Hello Magnus , pushed it to jdk/submit , however I do not expect much info from it because David told me Solaris is not tested there I was incorrect. (and the

Re: RFR: [OpenJDK 2D-Dev] JDK-8215296 do not disable c99 on Solaris

2018-12-19 Thread David Holmes
Correction: jdk-submit does test Solaris. David On 18/12/2018 8:02 am, David Holmes wrote: Hi Matthias, On 17/12/2018 11:12 pm, Baesken, Matthias wrote: Hello,  please review http://cr.openjdk.java.net/~mbaesken/webrevs/8215296.0/ in my change just -xc99=%none  is removed, so we do not

RE: [PATCH] Support for building using WSL (Windows Subsystem for Linux) on Windows

2018-12-19 Thread Andrew Luo
Hi Erik, Which target are you using (make exploded-image?)? I never saw this error while building on my machine (I've built about 10 times now, I'm on Windows 10 1809 for what it's worth). Perhaps I can try to reproduce this on my system as well... Thanks, -Andrew -Original

Re: [PATCH] Support for building using WSL (Windows Subsystem for Linux) on Windows

2018-12-19 Thread Erik Joelsson
I'm now seeing intermittent build failures that look like this: make[3]: *** No rule to make target '/mnt/d/erik/jdk-sandbox/open/src/java.security.jgss/share/classes/sun/security/krb5/internal/TGSReq.java', needed by

Re: RFR: JDK-8215635: Pandoc check in Docs.gmk does not work on Windows

2018-12-19 Thread Tim Bell
Erik: In JDK-8214910 a check for if the PANDOC variable had a value was added to Docs.gmk. This check does not work correctly on Windows where PANDOC will always have the fixpath prefix. This patch adds a separate ENABLE_PANDOC variable that make can check. Bug:

Re: [12] RFR for JDK-8214122: JDWP is broken on 32 bit Windows: transport library missing onLoad entry

2018-12-19 Thread Alexey Ivanov
Thank you, Daniel, for your quick review. On 19/12/2018 15:05, Daniel D. Daugherty wrote: On 12/19/18 9:23 AM, Alexey Ivanov wrote: Any volunteers from core-libs and serviceability to review? How about former Serviceability Team members? :-) Alan B. and I both used to be on the

RE: RFR: [OpenJDK 2D-Dev] JDK-8215296 do not disable c99 on Solaris

2018-12-19 Thread Baesken, Matthias
> > Sounds like a simpler change, at least for now. Does it pass jdk-submit? > Hello Magnus , pushed it to jdk/submit , however I do not expect much info from it because David told me Solaris is not tested there (and the other platforms are not affected by my path). However David tested

Re: [12] RFR for JDK-8214122: JDWP is broken on 32 bit Windows: transport library missing onLoad entry

2018-12-19 Thread Daniel D. Daugherty
On 12/19/18 9:23 AM, Alexey Ivanov wrote: Any volunteers from core-libs and serviceability to review? How about former Serviceability Team members? :-) Alan B. and I both used to be on the Serviceability Team... And Alan B. is a current member of Core Libs... > webrev:

Re: [12] RFR for JDK-8214122: JDWP is broken on 32 bit Windows: transport library missing onLoad entry

2018-12-19 Thread Alexey Ivanov
Any volunteers from core-libs and serviceability to review? Regards, Alexey On 12/12/2018 16:43, Magnus Ihse Bursie wrote: On 2018-12-12 17:38, Alexey Ivanov wrote: Hi all, I have updated the summary of JDK-8214122 and the subject accordingly. Could you please review the following fix?

Re: [PATCH] Support for building using WSL (Windows Subsystem for Linux) on Windows

2018-12-19 Thread Erik Joelsson
I can also report that on the Windows 10 machine I'm testing this on, "make bundles" on Cygwin took 12m56s and in WSL 8m39s, so a pretty big improvement! /Erik On 2018-12-19 03:45, Erik Joelsson wrote: Hello, On 2018-12-19 00:19, Erik Joelsson wrote: Hello Andrew, On 2018-12-18 12:45,

Re: [PATCH] Support for building using WSL (Windows Subsystem for Linux) on Windows

2018-12-19 Thread Erik Joelsson
Hello, On 2018-12-19 00:19, Erik Joelsson wrote: Hello Andrew, On 2018-12-18 12:45, Andrew Luo wrote: Hi Erik/Magnus, I've attached my latest changes: 1. Fixed a file I forgot to revert in my previous change while trying something out... 2. Added information about case sensitivity of the

RFR: JDK-8215635: Pandoc check in Docs.gmk does not work on Windows

2018-12-19 Thread Erik Joelsson
Hello, In JDK-8214910 a check for if the PANDOC variable had a value was added to Docs.gmk. This check does not work correctly on Windows where PANDOC will always have the fixpath prefix. This patch adds a separate ENABLE_PANDOC variable that make can check. Bug:

Re: [PATCH] Support for building using WSL (Windows Subsystem for Linux) on Windows

2018-12-19 Thread Erik Joelsson
Hello Andrew, On 2018-12-18 12:45, Andrew Luo wrote: Hi Erik/Magnus, I've attached my latest changes: 1. Fixed a file I forgot to revert in my previous change while trying something out... 2. Added information about case sensitivity of the OpenJDK build directory (yes, I did use the make