8227652: SetupOperatorNewDeleteCheck should discuss deleting destructors

2019-07-15 Thread Kim Barrett
Please review this explanatory comment being added to the description of the check for using global operator new/delete in Hotspot code. The described situation is somewhat obscure, and encountering it for the first time (or again after a long time, as happened to me recently) can be quite

Re: [Ping?] RFR: 8227397: Add --with-extra-asflags configure option

2019-07-15 Thread Hohensee, Paul
In CompileJvm.gmk, I'd replace -ASFLAGS := $(JVM_ASFLAGS), \ +ASFLAGS := $(JVM_ASFLAGS) $(EXTRA_ASFLAGS), \ with adding EXTRA_ASFLAGS to JVM_ASFLAGS right after where JVM_LDFLAGS is finalized, vis JVM_LDFLAGS += \ $(SHARED_LIBRARY_FLAGS) \ $(JVM_LDFLAGS_FEATURES) \

Re: JLI_Launch has mangled name in jli.dll when building for win32

2019-07-15 Thread Robert Lichtenberger
Thanks for pointing me into the right direction. So it looks as if this kind of mangling is to be expected on win32, which is also shown by the fact that multiple JDK-builds for win32, eg AdoptOpenJDK or Liberica JDK have their jli.dll that way. But that in turn means that jpackage should be

Re: [Ping?] RFR: 8227397: Add --with-extra-asflags configure option

2019-07-15 Thread Severin Gehwolf
Anyone? On Mon, 2019-07-08 at 17:56 +0200, Severin Gehwolf wrote: > Hi, > > Could I please get a review for this patch which adds a new configure > option --with-extra-asflags? The issue at hand is that we, Red Hat, > need to pass certain extra flags to the assembler when OpenJDK is being >