Re: RFR(S) [13] : 8226910 : make it possible to use jtreg's -match via run-test framework

Hi Igor, This seems fine to me. Thanks, David On 17/07/2019 7:35 am, Igor Ignatyev wrote: can I get a review for this patch? http://cr.openjdk.java.net/~iignatyev//8226910/webrev.01/index.html Thanks, -- Igor On Jul 6, 2019, at 11:50 AM, Igor Ignatyev >

Re: 8227652: SetupOperatorNewDeleteCheck should discuss deleting destructors

Looks fine and trivial to me. Thanks, David On 16/07/2019 5:51 am, Kim Barrett wrote: Please review this explanatory comment being added to the description of the check for using global operator new/delete in Hotspot code. The described situation is somewhat obscure, and encountering it for

Re: RFR [XS] 8227834: build.log output from failing commands : include the hs_error file path in case of crashes in build - was :RE: build.log: Output from failing command(s) repeated here - do not m

Hello Matthias: Hello I prepared a small change to address the mentioned issue . Please review ! Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8227834 http://cr.openjdk.java.net/~mbaesken/webrevs/8227834.0/ Looks good. Tim

RFR [XS] 8227834: build.log output from failing commands : include the hs_error file path in case of crashes in build - was :RE: build.log: Output from failing command(s) repeated here - do not miss

Hello I prepared a small change to address the mentioned issue . Please review ! Bug/webrev : https://bugs.openjdk.java.net/browse/JDK-8227834 http://cr.openjdk.java.net/~mbaesken/webrevs/8227834.0/ Best regards, Matthias > Hi Matthias, > > I would second that. > > Best regards >

RE: [CAUTION] build.log: Output from failing command(s) repeated here - do not miss the hs_error file in case of crashes

Hi Matthias, I would second that. Best regards Christoph > -Original Message- > From: build-dev On Behalf Of > Baesken, Matthias > Sent: Dienstag, 16. Juli 2019 16:40 > To: 'build-dev@openjdk.java.net' > Subject: [CAUTION] build.log: Output from failing command(s) repeated > here - do