Re: RFR: JDK-8230067: Add optional automatic retry when running jtreg tests

2019-08-23 Thread Erik Joelsson
There seems to be a bug in the new jtreg version, so need to hold off on this. /Erik On 2019-08-22 14:22, Erik Joelsson wrote: For some notoriously unstable client tests, we need the ability to automatically retry them a few times. This can be achieved with a simple loop around running jtreg

Re: [11u] RFR: 8214003: Limit default test jobs based on memory size

2019-08-23 Thread Severin Gehwolf
On Fri, 2019-08-23 at 08:33 -0700, Erik Joelsson wrote: > Looks good to me. Thanks, Erik. Appreciate the review! Cheers, Severin

Re: [11u] RFR: 8211727: Adjust default concurrency settings for running tests on Sparc

2019-08-23 Thread Severin Gehwolf
On Fri, 2019-08-23 at 08:33 -0700, Erik Joelsson wrote: > Looks good to me. Thank you, Erik! Cheers, Severin

Re: RFR: 8230043: Lazily load libverify

2019-08-23 Thread Claes Redestad
On 2019-08-23 17:29, Erik Joelsson wrote: Build change looks good. /Erik Thanks for reviewing! /Claes

Re: [11u] RFR: 8211727: Adjust default concurrency settings for running tests on Sparc

2019-08-23 Thread Erik Joelsson
Looks good to me. /Erik On 2019-08-23 06:59, Severin Gehwolf wrote: Hi, Please review this dependency patch of a bug I'd like to backport (JDK- 8214003). It does not apply cleanly - due to JDK-8212028 missing in jdk11u[1], but the changes needed are quite trivial: 1) JTREG_TIMEOUT_FACTOR =>

Re: [11u] RFR: 8214003: Limit default test jobs based on memory size

2019-08-23 Thread Erik Joelsson
Looks good to me. /Erik On 2019-08-23 08:15, Severin Gehwolf wrote: Hi, Please review this backport of a reliability fix for running tests. Currently on certain machines where num_cores/2 > mem_in_gb/2 there is a risk of tests failing due to memory issues. JTREG's -concurrency setting will

Re: RFR: 8230043: Lazily load libverify

2019-08-23 Thread Erik Joelsson
Build change looks good. /Erik On 2019-08-23 06:08, Claes Redestad wrote: Hi, please review this cleanup to untangle the old bytecode verifier (libverify). It's currently linked and loaded eagerly and early during bootstrap. Webrev: http://cr.openjdk.java.net/~redestad/8230043/webrev.00/

Re: Update test document by changing "TIMEOUT" to "TIMEOUT_FACTOR"

2019-08-23 Thread Erik Joelsson
Looks good! /Erik On 2019-08-22 19:54, Wang Xue wrote: Hi all, The test document has not been updated completely when changing "TIMEOUT" to "TIMEOUT_FACTOR" (JDK-8217634). It needs to be updated. Bug: https://bugs.openjdk.java.net/browse/JDK-8230079 Webrev:

[11u] RFR: 8214003: Limit default test jobs based on memory size

2019-08-23 Thread Severin Gehwolf
Hi, Please review this backport of a reliability fix for running tests. Currently on certain machines where num_cores/2 > mem_in_gb/2 there is a risk of tests failing due to memory issues. JTREG's -concurrency setting will currently be num_cures/2 and the available memory for this might not be

[11u] RFR: 8211727: Adjust default concurrency settings for running tests on Sparc

2019-08-23 Thread Severin Gehwolf
Hi, Please review this dependency patch of a bug I'd like to backport (JDK- 8214003). It does not apply cleanly - due to JDK-8212028 missing in jdk11u[1], but the changes needed are quite trivial: 1) JTREG_TIMEOUT_FACTOR => JTREG_TIMEOUT 2)

RFR: 8230043: Lazily load libverify

2019-08-23 Thread Claes Redestad
Hi, please review this cleanup to untangle the old bytecode verifier (libverify). It's currently linked and loaded eagerly and early during bootstrap. Webrev: http://cr.openjdk.java.net/~redestad/8230043/webrev.00/ Bug:https://bugs.openjdk.java.net/browse/JDK-8230043 - removes dependency