Re: RFR: JDK-8231594: Configure fails on some Linux systems

2019-09-27 Thread Martin Buchholz
Looks good, ... although I question whether any Unix program other than the shell itself should be trying to do tilde-path-expansion. Consider fixing the code by deleting it. On Fri, Sep 27, 2019 at 3:42 PM Erik Joelsson wrote: > In my recent change JDK-8206125, I introduced a bash conditional

Re: RFR: JDK-8231594: Configure fails on some Linux systems

2019-09-27 Thread Tim Bell
Erik: In my recent change JDK-8206125, I introduced a bash conditional that checks if a string starts with ~. That check seems to fail on some Linux systems unless the ~ is quoted. That's a very dark corner for the shell to be in... Bug: https://bugs.openjdk.java.net/browse/JDK-8231594

RFR: JDK-8231594: Configure fails on some Linux systems

2019-09-27 Thread Erik Joelsson
In my recent change JDK-8206125, I introduced a bash conditional that checks if a string starts with ~. That check seems to fail on some Linux systems unless the ~ is quoted. Bug: https://bugs.openjdk.java.net/browse/JDK-8231594 Webrev: http://cr.openjdk.java.net/~erikj/8231594/webrev.01

[8u] RFR: 8227397: Add --with-extra-asflags configure option

2019-09-27 Thread Severin Gehwolf
Hi, Could I please get a review of this 8u build change backport which adds --with-extra-asflags to OpenJDK 8u. At Red Hat, we need to pass certain assembler only flags for some builds. For example "-Wa,--generate- missing-build-notes=yes", to assembly files only. As the build system is different