Done.
/Erik
On 2019-10-11 05:09, Jorn Vernee wrote:
Hi Magnus,
I've created a JBS ticket for it:
https://bugs.openjdk.java.net/browse/JDK-8232167
But, I'm not a committer on the jdk project, so I would need a
sponsor. Could you push the patch?
Thanks,
Jorn
On 11/10/2019 09:06, Magnus
On 2019-10-10 15:25, Kim Barrett wrote:
On Oct 10, 2019, at 2:27 PM, Erik Joelsson wrote:
Updating defaults in devkit creator makefiles. Also remembering to update
building.md this time.
Webrev: http://cr.openjdk.java.net/~erikj/8232133/webrev.01/
Bug:
Hi Magnus,
I've created a JBS ticket for it:
https://bugs.openjdk.java.net/browse/JDK-8232167
But, I'm not a committer on the jdk project, so I would need a sponsor.
Could you push the patch?
Thanks,
Jorn
On 11/10/2019 09:06, Magnus Ihse Bursie wrote:
9 okt. 2019 kl. 16:00 skrev Jorn
I ran the `clean images` targets with the different toolchains but
didn't really notice any significant difference.
FWIW, for older versions of VS the x64 toolchain does seem to be preferred:
VCVARSFILES="vc/bin/amd64/vcvars64.bat
vc/bin/x86_amd64/vcvarsx86_amd64.bat \
On Thu, 2019-10-10 at 13:47 +, Langer, Christoph wrote:
> Adjusted webrev:
> http://cr.openjdk.java.net/~clanger/webrevs/8212028.11u-dev.1/
Seems OK to me.
Thanks,
Severin
> 9 okt. 2019 kl. 16:00 skrev Jorn Vernee :
>
> Hi,
>
> I was testing with different versions of Visual Studio to try and nail down
> the source of a deprecation warning. I was using the --with-tools-dir config
> option to quickly switch between installations but noticed the VS install
>
> 10 okt. 2019 kl. 20:31 skrev Erik Joelsson :
>
> Removed some hard coded version values from the creator script which are now
> generated dynamically instead anyway. Also updating the building doc.
>
> Webrev: http://cr.openjdk.java.net/~erikj/8232134/webrev.01/
Looks good to me.
/Magnus
> 10 okt. 2019 kl. 20:27 skrev Erik Joelsson :
>
> Updating defaults in devkit creator makefiles. Also remembering to update
> building.md this time.
>
> Webrev: http://cr.openjdk.java.net/~erikj/8232133/webrev.01/
Looks good to me.
/Magnus
>
> Bug: