Re: RFR 8234697: Generate sun.security.util.math.intpoly classes during build

2019-11-25 Thread Weijun Wang
> On Nov 26, 2019, at 12:36 AM, Erik Joelsson wrote: > > Build change looks good. Thanks. One question: I see the output to stdout from FieldGen.java shown in build. Is it possible to hide it but still store the output in the log file? I copied everything from CLDR_GEN_DONE but that one

Re: binary Hardening on linux using Relocation Read-Only (relro)

2019-11-25 Thread Claes Redestad
On 2019-11-25 18:30, Florian Weimer wrote: That being said, relocation processing for libjvm.so adds a couple of milliseconds to startup, and it looks like their number is growing with each release. This piqued my interest, so I took a quick look: readelf --relocs libjvm.so | wc -l 8:

Re: RFR: JEP 367: Remove the Pack200 Tools and API

2019-11-25 Thread Mandy Chung
On 11/22/19 1:30 PM, Vicente Romero wrote: [1] http://cr.openjdk.java.net/~vromero/8234542/webrev.03/ make/lib/Lib-jdk.pack.gmk should be removed. make/scripts/compare_exceptions.sh.incl     Should ./lib/libunpack.so also be removed? make/scripts/compare.sh     line 535-543 invokes

Re: binary Hardening on linux using Relocation Read-Only (relro)

2019-11-25 Thread Florian Weimer
* Matthias Baesken: > For "-Wl,-z,now" some startup performance hits are mentioned in > articles/blogs - any experiences / performance-measurements with this > in the OpenJDK context ? While libjvm.so needs a staggering amount of relocations, most of them are relative. They are not eligible for

Re: [OpenJDK 2D-Dev] build fails on macOS 10.12 after 8214578: [macos] Problem with backslashes on macOS/JIS keyboard: Java ignores system settings

2019-11-25 Thread Phil Race
I expect we could as it would help with backports but how much longer can we support 10.12 SDK to build ? Project Lanai is already finding it hard to keep to the 10.13 SDK ... and 10.12 as an O/S is already EOSL. So it should just be a stop gap measure. -phil. On 11/25/19 4:48 AM, Baesken,

Re: binary Hardening on linux using Relocation Read-Only (relro)

2019-11-25 Thread Erik Joelsson
Hello, I wasn't directly involved in introducing these flags, but my understanding is that it's always a performance compromise. I would involve at least hotspot-dev for a wider discussion on this as libjvm is the most affected library. /Erik On 2019-11-25 06:42, Baesken, Matthias wrote:

Re: RFR 8234697: Generate sun.security.util.math.intpoly classes during build

2019-11-25 Thread Erik Joelsson
Build change looks good. /Erik On 2019-11-22 18:59, Weijun Wang wrote: Please review the change at http://cr.openjdk.java.net/~weijun/8234697/webrev.00/ The new lines in Gensrc-java.base.gmk mimics the one for CLDR_GEN_DONE at the beginning of the same file. I changed the BigInteger

Re: build fails on macOS 10.12 after 8214578: [macos] Problem with backslashes on macOS/JIS keyboard: Java ignores system settings

2019-11-25 Thread Erik Joelsson
If there is a simple fix, I would very much like to see it done. I'm not familiar enough with this area to know what the implications would be though. /Erik On 2019-11-25 04:48, Baesken, Matthias wrote: Hello, any comments on the issue ? Could we maybe switch from using

binary Hardening on linux using Relocation Read-Only (relro)

2019-11-25 Thread Baesken, Matthias
Hello, I wonder why the binary hardening on linux using Relocation Read-Only (relro) is not enabled by default. Some info can be found here : https://wiki.debian.org/Hardening https://www.redhat.com/en/blog/hardening-elf-binaries-using-relocation-read-only-relro Currently I notice

RE: build fails on macOS 10.12 after 8214578: [macos] Problem with backslashes on macOS/JIS keyboard: Java ignores system settings

2019-11-25 Thread Baesken, Matthias
Hello, any comments on the issue ? Could we maybe switch from using NSTextInputSourceIdentifier to String (NSString* ?) , because https://developer.apple.com/documentation/appkit/nstextinputsourceidentifier says NSTextInputSourceIdentifieris a typealias for String ? Best