Re: RFR JDK-8237042: Switch to JCov build which supports byte code version 59
Looks good. /Erik On 2020-01-13 10:48, Alexandre (Shura) Iline wrote: Hi. Can you please review this simple change: --- $ hg diff diff -r f7edb9ca045c make/conf/jib-profiles.js --- a/make/conf/jib-profiles.js Fri Jan 10 15:38:25 2020 +0100 +++ b/make/conf/jib-profiles.js Mon Jan 13 10:42:27 2020 -0800 @@ -1066,7 +1066,7 @@ // build_number: "b07", // file: "bundles/jcov-3_0.zip", organization: common.organization, -revision: "3.0-58-support+1.0", +revision: "3.0-59-support+1.0", ext: "zip", environment_name: "JCOV_HOME", }, --- Thank you. Shura
RFR JDK-8237042: Switch to JCov build which supports byte code version 59
Hi. Can you please review this simple change: --- $ hg diff diff -r f7edb9ca045c make/conf/jib-profiles.js --- a/make/conf/jib-profiles.js Fri Jan 10 15:38:25 2020 +0100 +++ b/make/conf/jib-profiles.js Mon Jan 13 10:42:27 2020 -0800 @@ -1066,7 +1066,7 @@ // build_number: "b07", // file: "bundles/jcov-3_0.zip", organization: common.organization, -revision: "3.0-58-support+1.0", +revision: "3.0-59-support+1.0", ext: "zip", environment_name: "JCOV_HOME", }, --- Thank you. Shura
Re: RFR: 8236921: Add build target to produce a JDK image suitable for a Graal/SVM build
> On Jan 13, 2020, at 3:42 AM, Severin Gehwolf wrote: > > On Fri, 2020-01-10 at 13:19 -0800, Erik Joelsson wrote: >> Hello Severin, >> >> Looks good. > > Thanks for the review, Erik! > >> /Erik >> >> On 2020-01-10 09:28, Bob Vandette wrote: >>> I like it! >>> >>> I have to manually copy the libs each time. >>> >>> BTW: I have a PR in our internal queue to update the graal repo so >>> it can build with the latest JDK 14. > > I'd love to see that patch pushed to graal master! :) My changes have been integrated into the internal graal repo. [GR-20168] Add new JDK14 methods and bump JDK version support to JDK 15. MERGED Hopefully it will be in the github mirror soon. I’m not sure how long that takes. Bob. > > Thanks, > Severin > >>> Bob. >>> >>> On Jan 10, 2020, at 10:45 AM, Severin Gehwolf < sgehw...@redhat.com> wrote: Hi, Currently there is no easy way to produce an OpenJDK build which could subsequently be used to build Substrate VM (part of Graal CE). Basic building blocks are there, but no actual JDK image is getting produced with the static libs along side their dynamic counterparts. This patch addresses this by adding a new target called 'graal-builder- image' which produces a jdk image in $IMAGES/graal-builder-jdk. It basically copies over libs from static-libs folder and the jdk folder to assemble the desired result. Bug: https://bugs.openjdk.java.net/browse/JDK-8236921 webrev: http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8236921/02/webrev/ I've tested this works for some snapshot of JDK 14 (rev 3009b27660be) and graal at revision d9fb0b7dc35a9a7eb559a5e468bcc4c99e918449. Thoughts? Thanks, Severin >
Re: RFR: 8236921: Add build target to produce a JDK image suitable for a Graal/SVM build
On Fri, 2020-01-10 at 13:19 -0800, Erik Joelsson wrote: > Hello Severin, > > Looks good. Thanks for the review, Erik! > /Erik > > On 2020-01-10 09:28, Bob Vandette wrote: > > I like it! > > > > I have to manually copy the libs each time. > > > > BTW: I have a PR in our internal queue to update the graal repo so > > it can build with the latest JDK 14. I'd love to see that patch pushed to graal master! :) Thanks, Severin > > Bob. > > > > > > > On Jan 10, 2020, at 10:45 AM, Severin Gehwolf < > > > sgehw...@redhat.com> wrote: > > > > > > Hi, > > > > > > Currently there is no easy way to produce an OpenJDK build which > > > could > > > subsequently be used to build Substrate VM (part of Graal CE). > > > Basic > > > building blocks are there, but no actual JDK image is getting > > > produced > > > with the static libs along side their dynamic counterparts. This > > > patch > > > addresses this by adding a new target called 'graal-builder- > > > image' > > > which produces a jdk image in $IMAGES/graal-builder-jdk. It > > > basically > > > copies over libs from static-libs folder and the jdk folder to > > > assemble > > > the desired result. > > > > > > Bug: https://bugs.openjdk.java.net/browse/JDK-8236921 > > > webrev: > > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8236921/02/webrev/ > > > > > > I've tested this works for some snapshot of JDK 14 (rev > > > 3009b27660be) > > > and graal at revision d9fb0b7dc35a9a7eb559a5e468bcc4c99e918449. > > > > > > Thoughts? > > > > > > Thanks, > > > Severin > > >
