Hi Matthias,
This also needs to be a configurable option not one done by default as
there can be non-technical issues relating to shipping symbol files in a
product.
Thanks,
David
On 17/01/2020 6:44 pm, Baesken, Matthias wrote:
Hello, please review this change related to stripped/"public"
LGTM
On Fri, Jan 17, 2020 at 2:59 AM Severin Gehwolf wrote:
> Hi,
>
> Could I get a second review from an JDK 8u Reviewer, please?
>
> Thanks,
> Severin
>
> On Mon, 2019-09-30 at 11:36 +0200, Magnus Ihse Bursie wrote:
> > On 2019-09-27 17:48, Severin Gehwolf wrote:
> > > Hi,
> > >
> > > Could I
Hello Matthias,
Providing these stripped pdb files in the distribution is a good idea,
but finding a good solution in the build is unfortunately more
complicated than this. The JDK image we ship should (with very few
exceptions) be the result of running jlink on all the jmods. If a user
runs
Hello Matthias,
Using BUILDING_MULTIPLE_JVM_VARIANTS as condition is clever and happens
to coincide with the set of variants that also support CDS, but I would
say this correlation is incidental. I would still prefer an explicit
test for if any of the variants that do support CDS is in the
Looks good.
/Erik
On 2020-01-16 22:47, Baesken, Matthias wrote:
Hello, please review this very small change .
It removes file that are not present any more from the OPT_SPEED_SRC file list
in JvmFeatures.gmk .
( this is a list of files to be optimized for speed when we otherwise optimize
* Matthias: Have a look at some recently added option to get an indication
of the best practice in adding new options. There are some ways to easily make
this incorrect
Hi Magnus, do you have a good/”best practice” example (not that I catch a bad
one ) ?
Best regards, Matthias
Hi,
Could I get a second review from an JDK 8u Reviewer, please?
Thanks,
Severin
On Mon, 2019-09-30 at 11:36 +0200, Magnus Ihse Bursie wrote:
> On 2019-09-27 17:48, Severin Gehwolf wrote:
> > Hi,
> >
> > Could I please get a review of this 8u build change backport which
> > adds
> >
On 2020-01-16 10:30, David Holmes wrote:
Hi Matthias,
On 16/01/2020 6:10 pm, Baesken, Matthias wrote:
Hi David, sure we can introduce a way to switch this on/off.
Thanks.
There is already something similar for the link-time optimization
(flto) , see the feature
JvmFeatures.gmk
180 ifeq
Hello, my example product build (64 bit Windows / VS2017) shows the following
sizes for the uncompressed pdb files :
sum of size of all full pdbs : 117 MB (jvm.pdb is 73,1 MB )
sum of size of all stripped pdbs: 18,2 MB (jvm.pdb is 9,46 MB = ~ 50 % of all)
Best regards, Matthias
On 2020-01-17
On 2020-01-17 09:44, Baesken, Matthias wrote:
Hello, please review this change related to stripped/"public" pdb file
generation on Windows .
Currently the JDK bundle on Windows does not contain pdb files (full pdb files
are in a separate symbols bundle).
This leads currently to bad native
Hello, please review this change related to stripped/"public" pdb file
generation on Windows .
Currently the JDK bundle on Windows does not contain pdb files (full pdb files
are in a separate symbols bundle).
This leads currently to bad native stack traces e.g. when crashes occur.
One reason
Hello, please review this small patch .
When building 2 VM variants minimal and server in one build and using
--with-jvm-variants=minimal,server
to configure this setup , the build works nicely. But I notice that in the
server VM, cds is removed.
Instead of
checking if cds should be
12 matches
Mail list logo
