Patch looks fine (although you might want to update the comment).
It's more concerning that I didn't catch this (seems all tests of
mine were with --enable-preview), and we'll still inconvenience users
who need to run the jar file directly. So it seems we should consider
fixing so that only
Forgot to attach the JBS link:
https://bugs.openjdk.java.net/browse/JDK-8248429
Jorn
On 27/06/2020 00:14, Jorn Vernee wrote:
Hi,
https://bugs.openjdk.java.net/browse/JDK-8248135 added
--enable-preview to the javac options when building micro benchmarks.
We should also add it to the set of
Hi,
https://bugs.openjdk.java.net/browse/JDK-8248135 added --enable-preview
to the javac options when building micro benchmarks.
We should also add it to the set of default VM arguments passed to the
microbenchmark jar so it doesn't need to be passed manually.
If --enable-preview is not
Hi,
I propose to split the data update (for JDK 15 and for backports) and
the tool/CreateSymbols update (for JDK 16+). So I've created:
https://bugs.openjdk.java.net/browse/JDK-8248405
for the latter. Lets keep JDK-8244763 only for the former, i.e. for this
patch:
HI David and Martin, thanks for the reviews !
>
>Hi Matthias,
>
>Looks good. Thanks for fixing it.
>
>Best regards,
>Martin
>>
>> Hi Matthias,
>>
>> That all seems fine to me.
>>
>> David
>>
Hi Matthias,
Looks good. Thanks for fixing it.
Best regards,
Martin
> Am 26.06.2020 um 09:59 schrieb David Holmes :
>
> Hi Matthias,
>
> That all seems fine to me.
>
> David
>
>> On 26/06/2020 5:06 pm, Baesken, Matthias wrote:
>> Hello, please review this small patch that fixes the
Hi,
I didn't get the RFR mails. Probably the known hotspot-dev Mailing List
Problem?
But I saw the RFR in the pipermail archive.
I had a look at the change. It looks good, and
I consider it trivial.
Best regards,
Goetz.
Hi Matthias,
That all seems fine to me.
David
On 26/06/2020 5:06 pm, Baesken, Matthias wrote:
Hello, please review this small patch that fixes the ppc64(le) and s390x
builds .
( They started to break since the 24th June, looks like some inclusions were
missing after recent HS
Hello, please review this small patch that fixes the ppc64(le) and s390x
builds .
( They started to break since the 24th June, looks like some inclusions were
missing after recent HS changes )
Bug/webrev :
https://bugs.openjdk.java.net/browse/JDK-8248334
