Re: [8u] RFR: 8252395: [8u] --with-native-debug-symbols=external doesn't include debuginfo files for binaries

2020-08-31 Thread Severin Gehwolf
Sorry, wrong webrev. Now corrected.

On Mon, 2020-08-31 at 10:02 +0200, Severin Gehwolf wrote:
> Hi,
> 
> Could I get a reivew of this 8u specific bug please? When configured
> --with-native-debug-symbols=external,zipped the resulting external
> debuginfo files for binaries (in images/bin folder) aren't there.
> 
> In OpenJDK 8u there is some special casing involved for bin/java and
> bin/unpack200. Thus, I had to special case them for the debuginfo
> variant files too otherwise those files would be missing in the images
> folders (j2sdk-image, j2re-image).
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8252395

webrev: https://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8252395/02/webrev/

> 
> Testing: Build in configs 
> --with-native-debugsymbols={zipped,external,internal,none}
>  on Linux x86 and manually debugging some launcher code. Works now
>  with symbols. Symbols were missing before this patch.
> 

Thanks,
Severin



[8u] RFR: 8252395: [8u] --with-native-debug-symbols=external doesn't include debuginfo files for binaries

2020-08-31 Thread Severin Gehwolf
Hi,

Could I get a reivew of this 8u specific bug please? When configured
--with-native-debug-symbols=external,zipped the resulting external
debuginfo files for binaries (in images/bin folder) aren't there.

In OpenJDK 8u there is some special casing involved for bin/java and
bin/unpack200. Thus, I had to special case them for the debuginfo
variant files too otherwise those files would be missing in the images
folders (j2sdk-image, j2re-image).

Bug: https://bugs.openjdk.java.net/browse/JDK-8252395
webrev: https://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8252395/01/webrev/

Testing: Build in configs 
--with-native-debugsymbols={zipped,external,internal,none}
 on Linux x86 and manually debugging some launcher code. Works now
 with symbols. Symbols were missing before this patch.

Thanks,
Severin