Re: RFR: 8279505: Update documentation for RETRY_COUNT and REPEAT_COUNT
On Wed, 5 Jan 2022 08:42:41 GMT, Aleksey Shipilev wrote: > Following up on suggestion here: > https://github.com/openjdk/jdk/pull/6720#discussion_r778457819 Thank you! - Marked as reviewed by serb (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6964
Re: RFR: 8268081: Upgrade Unicode Data Files to 14.0.0
On Wed, 5 Jan 2022 22:42:38 GMT, Naoto Sato wrote: > Please review the changes for upgrading the Unicode support in the JDK, from > version 13 to version 14. Corresponding CSR has also been drafted. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6974
Re: RFR: 8268081: Upgrade Unicode Data Files to 14.0.0
On Wed, 5 Jan 2022 22:42:38 GMT, Naoto Sato wrote: > Please review the changes for upgrading the Unicode support in the JDK, from > version 13 to version 14. Corresponding CSR has also been drafted. I like how they changed dizzy face to face with crossed-out eyes. Pistol to water pistol, that's even better, just to avoid any confusion ;-) - PR: https://git.openjdk.java.net/jdk/pull/6974
Re: RFR: 8268081: Upgrade Unicode Data Files to 14.0.0
On Wed, 5 Jan 2022 22:42:38 GMT, Naoto Sato wrote: > Please review the changes for upgrading the Unicode support in the JDK, from > version 13 to version 14. Corresponding CSR has also been drafted. Marked as reviewed by joehw (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6974
RFR: 8268081: Support for Unicode 14
Please review the changes for upgrading the Unicode support in the JDK, from version 13 to version 14. Corresponding CSR has also been drafted. - Commit messages: - Amend unicode.md and icu.md files - Minor fixup - Merge branch 'master' into unicode - Copyright year to 2022 - ICU4J 70.1 - 18 -> 19 - Merge branch 'master' into unicode - Unicode 14.0.0 (final) - UCD ver. 14.0 (beta) / Unicode Text Segmentation rev. 38 (draft) - ICU4J 69.1 Changes: https://git.openjdk.java.net/jdk/pull/6974/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=6974=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8268081 Stats: 3443 lines in 41 files changed: 2353 ins; 101 del; 989 mod Patch: https://git.openjdk.java.net/jdk/pull/6974.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6974/head:pull/6974 PR: https://git.openjdk.java.net/jdk/pull/6974
Integrated: JDK-8277515: Update --release 18 symbol information for JDK 18 build 29
On Mon, 3 Jan 2022 18:26:24 GMT, Joe Darcy wrote: > Usual update to the JDK 19 symbol files for changes in JDK 18; this time > JDK-8276660 in JDK 18 build 28. This pull request has now been integrated. Changeset: 9a0e8900 Author:Joe Darcy URL: https://git.openjdk.java.net/jdk/commit/9a0e890056fb8ae4e28e656118e73fae33ba5e2a Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod 8277515: Update --release 18 symbol information for JDK 18 build 29 Reviewed-by: iris - PR: https://git.openjdk.java.net/jdk/pull/6948
Re: RFR: 8279505: Update documentation for RETRY_COUNT and REPEAT_COUNT
On Wed, 5 Jan 2022 08:42:41 GMT, Aleksey Shipilev wrote: > Following up on suggestion here: > https://github.com/openjdk/jdk/pull/6720#discussion_r778457819 Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6964
Integrated: 8279445: Update JMH devkit to 1.34
On Tue, 4 Jan 2022 12:15:10 GMT, Aleksey Shipilev wrote: > Brings lots of goodies, including automatic enablement of Compiler > Blackholes: > https://mail.openjdk.java.net/pipermail/jmh-dev/2021-December/003406.html > > Additional testing: > - [x] Devkit creation works > - [x] Sample benchmarks runs with new devkit This pull request has now been integrated. Changeset: 0f98efbf Author:Aleksey Shipilev URL: https://git.openjdk.java.net/jdk/commit/0f98efbf2f0e47bb398fe7ca5235853e1d98df3a Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8279445: Update JMH devkit to 1.34 Reviewed-by: aph, erikj - PR: https://git.openjdk.java.net/jdk/pull/6955
Re: RFR: 8279445: Update JMH devkit to 1.34
On Tue, 4 Jan 2022 12:15:10 GMT, Aleksey Shipilev wrote: > Brings lots of goodies, including automatic enablement of Compiler > Blackholes: > https://mail.openjdk.java.net/pipermail/jmh-dev/2021-December/003406.html > > Additional testing: > - [x] Devkit creation works > - [x] Sample benchmarks runs with new devkit Thanks for reviews! - PR: https://git.openjdk.java.net/jdk/pull/6955
RFR: 8279505: Update documentation for RETRY_COUNT and REPEAT_COUNT
Following up on suggestion here: https://github.com/openjdk/jdk/pull/6720#discussion_r778457819 - Commit messages: - Fix Changes: https://git.openjdk.java.net/jdk/pull/6964/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=6964=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8279505 Stats: 8 lines in 2 files changed: 4 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/jdk/pull/6964.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6964/head:pull/6964 PR: https://git.openjdk.java.net/jdk/pull/6964
Re: RFR: 8244602: Add JTREG_REPEAT_COUNT to repeat execution of a test
On Wed, 5 Jan 2022 08:31:54 GMT, Aleksey Shipilev wrote: >> doc/testing.html line 198: >> >>> 196: Retry failed tests up to a set number of times. Defaults to 0. >>> 197: REPEAT_COUNT >>> 198: Repeat the tests for a set number of times. Defaults to 0. >> >> Don't we need to mention that the goal of the repeat_count is to run a test >> until it fails first (to reproduce intermittent issues)? > > We can. Current docs copy-pasted the form of `RETRY_COUNT` above. Both should > be updated with some mention for use cases. Let me do that... See #6964. - PR: https://git.openjdk.java.net/jdk/pull/6720
Re: RFR: 8244602: Add JTREG_REPEAT_COUNT to repeat execution of a test
On Tue, 4 Jan 2022 23:39:45 GMT, Sergey Bylokhov wrote:
>> This adds the test repeat feature in the build system. This is convenient to
>> follow-up on intermittently failing tests: the `REPEAT_COUNT > 0` would run
>> the test multiple times, until we run out of repeats or the tests fail.
>>
>> With this sample test:
>>
>>
>> /*
>> * @test
>> * @run driver IntermittentTest
>> */
>> public class IntermittentTest {
>> public static void main(String... args) {
>> if (Math.random() < 0.05) {
>> throw new IllegalStateException("Oops");
>> }
>> }
>> }
>>
>>
>> ...a lucky run looks like this:
>>
>>
>> $ CONF=linux-x86_64-server-fastdebug make run-test
>> TEST=sanity/IntermittentTest.java JTREG="REPEAT_COUNT=5"
>> Building target 'run-test' in configuration 'linux-x86_64-server-fastdebug'
>> Running tests using JTREG control variable 'REPEAT_COUNT=5'
>> Test selection 'sanity/IntermittentTest.java', will run:
>> * jtreg:test/hotspot/jtreg/sanity/IntermittentTest.java
>>
>> Running test 'jtreg:test/hotspot/jtreg/sanity/IntermittentTest.java'
>>
>> Repeating Jtreg run: 1 out of 5
>> Passed: sanity/IntermittentTest.java
>> Test results: passed: 1
>> Report written to ...
>> Results written to ...
>>
>> Repeating Jtreg run: 2 out of 5
>> Passed: sanity/IntermittentTest.java
>> Test results: passed: 1
>> Report written to ...
>> Results written to ...
>>
>> Repeating Jtreg run: 3 out of 5
>> Passed: sanity/IntermittentTest.java
>> Test results: passed: 1
>> Report written to ...
>> Results written to ...
>>
>> Repeating Jtreg run: 4 out of 5
>> Passed: sanity/IntermittentTest.java
>> Test results: passed: 1
>> Report written to ...
>> Results written to ...
>>
>> Repeating Jtreg run: 5 out of 5
>> Passed: sanity/IntermittentTest.java
>> Test results: passed: 1
>> Report written to ...
>> Results written to ...
>> Finished running test 'jtreg:test/hotspot/jtreg/sanity/IntermittentTest.java'
>> Test report is stored in ...
>>
>> ==
>> Test summary
>> ==
>>TEST TOTAL PASS FAIL ERROR
>>
>>jtreg:test/hotspot/jtreg/sanity/IntermittentTest.java
>> 1 1 0 0
>>
>> ==
>> TEST SUCCESS
>>
>>
>> ...and unlucky run looks like this:
>>
>>
>> $ CONF=linux-x86_64-server-fastdebug make run-test
>> TEST=sanity/IntermittentTest.java JTREG="REPEAT_COUNT=50"
>> Building target 'run-test' in configuration 'linux-x86_64-server-fastdebug'
>> Running tests using JTREG control variable 'REPEAT_COUNT=50'
>> Test selection 'sanity/IntermittentTest.java', will run:
>> * jtreg:test/hotspot/jtreg/sanity/IntermittentTest.java
>> ...
>> Repeating Jtreg run: 9 out of 50
>> Passed: sanity/IntermittentTest.java
>> Test results: passed: 1
>> Report written to ...
>> Results written to ...
>>
>> Repeating Jtreg run: 10 out of 50
>> --
>> TEST: sanity/IntermittentTest.java
>> TEST JDK: ...
>>
>> ...
>>
>> STDERR:
>> java.lang.IllegalStateException: Oops
>> at IntermittentTest.main(IntermittentTest.java:8)
>> at
>> java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
>> at java.base/java.lang.reflect.Method.invoke(Method.java:577)
>> at
>> com.sun.javatest.regtest.agent.MainActionHelper$AgentVMRunnable.run(MainActionHelper.java:312)
>> at java.base/java.lang.Thread.run(Thread.java:833)
>>
>> JavaTest Message: Test threw exception: java.lang.IllegalStateException
>> JavaTest Message: shutting down test
>>
>>
>> TEST RESULT: Failed. Execution failed: `main' threw exception:
>> java.lang.IllegalStateException: Oops
>> --
>> Test results: failed: 1
>> Report written to ...
>> Results written to ...
>> Error: Some tests failed or other problems occurred.
>>
>> Failures detected, no more repeats.
>> Finished running test 'jtreg:test/hotspot/jtreg/sanity/IntermittentTest.java'
>> Test report is stored in ...
>>
>> ==
>> Test summary
>> ==
>>TEST TOTAL PASS FAIL ERROR
>>
>>jtreg:test/hotspot/jtreg/sanity/IntermittentTest.java
1 0 1 0
<<
>> ==
>> TEST FAILURE
>
> doc/testing.html line 198:
>
>> 196: Retry failed tests up to a set number of times. Defaults to 0.
>> 197: REPEAT_COUNT
>> 198: Repeat the tests for a set number of times. Defaults to 0.
>
> Don't we need to mention that the goal of the repeat_count is to run a test
> until it fails first (to reproduce intermittent issues)?
We can. Current docs copy-pasted the form of `RETRY_COUNT` above. Both should
be updated with some mention for use
