github PR fails to send RFR email

Hi all, I found my PR [1] fails to send RFR email. Is there anything wrong? Or am I missing something? Thanks. Best regards, Jie [1] https://github.com/openjdk/jdk/pull/3941

Re: github PR fails to send RFR email(Internet mail)

Got it. Thanks for your kind reply. Best regards, Jie From: Guoxiong Li Date: Monday, May 10, 2021 at 3:04 PM To: "jiefu(傅杰)" Cc: build-dev , "[email protected]" Subject: Re: github PR fails to send RFR email(Internet mail) Hi jie, The same problem occurred i

RFR: 8241034: Fix a configuring error with "-Xmx2048M: command not found"

Hi all, JBS:https://bugs.openjdk.java.net/browse/JDK-8241034 Webrev: http://cr.openjdk.java.net/~jiefu/8241034/webrev.00/ A shell command error was observed during the jdk configuration. ``` jdk/build/.configure-support/generated-configure.sh: line 91505: -Xmx2048M: command not found `

Re: 8241034: Fix a configuring error with "-Xmx2048M: command not found"(Internet mail)

[1] https://bugs.openjdk.java.net/browse/JDK-8241035 > On Mar 13, 2020, at 5:13 PM, jiefu(傅杰) wrote: > > Hi all, > > JBS:https://bugs.openjdk.java.net/browse/JDK-8241034 > Webrev: http://cr.openjdk.java.net/~jiefu/8241034/webrev.00/ > >

Re: 8241034: Fix a configuring error with "-Xmx2048M: command not found"(Internet mail)

Thanks Erik for your review. Pushed. Best regards, Jie On 2020/3/16, 8:46 PM, "Erik Joelsson" wrote: Looks good. /Erik On 2020-03-13 17:13, jiefu(傅杰) wrote: > Hi all, > > JBS:https://bugs.openjdk.java.net/browse/JDK-8241034

RFR: 8244097: make bootcycle-images fails after JDK-8244036

Hi all, May I get reviews for this fix? JBS: https://bugs.openjdk.java.net/browse/JDK-8244097 Webrev: http://cr.openjdk.java.net/~jiefu/8244097/webrev.00/ Thanks a lot. Best regards, Jie

Re: 8244097: make bootcycle-images fails after JDK-8244036(Internet mail)

gards, Jie On 2020/4/29, 7:49 PM, "Magnus Ihse Bursie" wrote: On 2020-04-29 13:23, Magnus Ihse Bursie wrote: > On 2020-04-29 13:02, jiefu(傅杰) wrote: >> Hi all, >> >> May I get reviews for this fix? >> >> JBS: https://bugs

Re: 8244097: make bootcycle-images fails after JDK-8244036(Internet mail)

onsor the patch? /Magnus > 29 apr. 2020 kl. 14:25 skrev jiefu(傅杰) : > > Thanks Magnus for your review and nice help. > It seems that your patch didn't fix the build failure when configure --with-boot-jdk=jdk15. > > I've made : http://c

RFR: 8247396: PCH should be disabled for opt-size feature with clang after JDK-8246751

Hi all, JBS:https://bugs.openjdk.java.net/browse/JDK-8247396 Webrev: http://cr.openjdk.java.net/~jiefu/8247396/webrev.00/ -O3 is used for clang on MacOS after JDK-8246751. But it breaks the builds of VMs with opt-size feature when PCH is enabled. The reason is that the PCH was built with -Os

Re: RFR: 8247396: PCH should be disabled for opt-size feature with clang after JDK-8246751

E(opt-size). /Erik On 2020-06-11 02:25, jiefu(傅杰) wrote: > Hi all, > > JBS:https://bugs.openjdk.java.net/browse/JDK-8247396 > Webrev: http://cr.openjdk.java.net/~jiefu/8247396/webrev.00/ > > -O3 is used for clang on MacOS after JDK-8246

Re: 8247396: PCH should be disabled for opt-size feature with clang after JDK-8246751(Internet mail)

> /Erik > > On 2020-06-11 02:25, jiefu(傅杰) wrote: >> Hi all, >> >> JBS:https://bugs.openjdk.java.net/browse/JDK-8247396 >> Webrev: http://cr.openjdk.java.net/~jiefu/8247396/webrev.00/ >> >> -O3 is used for clang on Ma

Re: RFR: 8247396: PCH should be disabled for opt-size feature with clang after JDK-8246751

m precompiled header. We could just add $(OPT_SPEED_SRC) to this list (as that variable is defined earlier in JvmFeatures.gmk). OPT_SPEED_SRC is empty unless opt-size is true, so just adding it to the list should be fine. /Erik > /Magnus >> &g

Re: 8247396: PCH should be disabled for opt-size feature with clang after JDK-8246751(Internet mail)

Thanks Magnus for your review and help. I can push it myself and will do it later. Best regards, Jie On 2020/6/12, 5:08 PM, "Magnus Ihse Bursie" wrote: On 2020-06-12 04:58, jiefu(傅杰) wrote: > Hi Erik and Magnus, > > Thanks for your help. &g

Re: RFR[16] 8248495: [macos] zerovm is broken due to libffi headers location

Hi Vladimir and Magnus, How about configuring with --with-libffi=... like this: --with-libffi=/usr/local/Cellar/libffi/3.2.1/lib/libffi-3.2.1 --disable-warnings-as-errors I can compile zero vm on our macos platforms with that configuration. Thanks. Best regards, Jie On 2020/7/1, 3

RFR: 8248612: Back quotes and double quotes must not be escaped in: Cannot convert \"$unix_path\" to Windows path

Hi all, May I get reviews for this fix? JBS:https://bugs.openjdk.java.net/browse/JDK-8248612 Webrev: http://cr.openjdk.java.net/~jiefu/8248612/webrev.00/ Thanks a lot. Best regards, Jie

Re: RFR: 8248612: Back quotes and double quotes must not be escaped in: Cannot convert \"$unix_path\" to Windows path

Thanks Magnus for your review. I will push it tonight. Best regards, Jie On 2020/7/1, 4:39 PM, "Magnus Ihse Bursie" wrote: On 2020-07-01 04:29, jiefu(傅杰) wrote: > Hi all, > > May I get reviews for this fix? > > JBS:https://bugs.openjdk.ja

RFR: 8249704: UTIL_DEPRECATED_ARG_ENABLE dumps incorrect warning message

Hi all, May I get reviews for this change? JBS:https://bugs.openjdk.java.net/browse/JDK-8249704 Webrev: http://cr.openjdk.java.net/~jiefu/8249704/webrev.00/ Thanks a lot. Best regards, Jie

Re: RFR: 8249704: UTIL_DEPRECATED_ARG_ENABLE dumps incorrect warning message

on user option (as enabled was default). /Erik On 2020-07-17 23:17, jiefu(傅杰) wrote: > Hi all, > > May I get reviews for this change? > > JBS:https://bugs.openjdk.java.net/browse/JDK-8249704 > Webrev: http://cr.openjdk.java.net/~j