Replaces usages of articles that follow each other in all combinations: a/the,
an?/an?, the/the…
It's the last issue in the series, and it still touches different areas of the
code.
-
Commit messages:
- 8284209: Replace remaining usages of 'the a' in source code
- 8284209: Replac
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
Alexey Ivanov has updated the pull request with a new target base due to a
me
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
Alexey Ivanov has updated the pull request incrementally with one additional
c
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
This pull request has
Update the link to JBS in `vcs.xml` template to https://bugs.openjdk.org/
It will affect newly generated project files only.
Edit `vcs.xml` manually or in UI to update in existing projects.
-
Commit messages:
- 8288114: Update JIRA link in vcs.xml
Changes: https://git.openjdk.org
On Fri, 10 Jun 2022 17:11:41 GMT, Alexey Ivanov wrote:
> Update the link to JBS in `vcs.xml` template to https://bugs.openjdk.org/
>
> It will affect newly generated project files only.
> Edit `vcs.xml` manually or in UI to update in existing projects.
Bot, wake up!
On Fri, 10 Jun 2022 17:11:41 GMT, Alexey Ivanov wrote:
> Update the link to JBS in `vcs.xml` template to https://bugs.openjdk.org/
>
> It will affect newly generated project files only.
> Edit `vcs.xml` manually or in UI to update in existing projects.
This pull request
Hi Magnus, Matthias,
I tried to build 32 bit Windows but it fails to run for me with
Corrupted ZIP library:
c:\work\jdk-dev\build\windows-x86-normal-server-release\jdk\bin\zip.dll
The problem is that zip.dll exports all symbols as C++ rather than C.
For example, ZIP_CRC32 is exported as _ZIP_C
rectly,
that is).
so I wonder which added JNICALL decoration you are refering to .
Best regards, Matthias
-Original Message-
From: Magnus Ihse Bursie [mailto:[email protected]]
Sent: Montag, 9. April 2018 13:29
To: Baesken, Matthias
Cc: Alexey Ivanov ; build-dev ; Doerr
JNIEXPORT and JNICALL from main().
It wasn't exported, and it shouldn't be.
Regards,
Alexey
Best regards , Matthias
-Original Message-
From: Alexey Ivanov [mailto:[email protected]]
Sent: Montag, 9. April 2018 15:52
To: Magnus Ihse Bursie ; Baesken,
Mat
anks again to Alexey to provide the incorporated patch .
You can reference both yourself and me as
Contributed-by: mbaesken, aivanov
when pushing the changeset if you don't mind.
Regards,
Alexey
Best regards, Matthias
-Original Message-----
From: Alexey Ivanov [ma
,
Alexey
You can reference both yourself and me as
Contributed-by: mbaesken, aivanov
when pushing the changeset if you don't mind.
Sure .
Best regards, Matthias
-Original Message-
From: Alexey Ivanov [mailto:[email protected]]
Sent: Dienstag, 10. April 2018 21:34
To: B
JNIEXPORT is better left untouched to keep main() exported.
Regards,
Alexey
Best regards, Matthias
-Original Message-
From: Alexey Ivanov [mailto:[email protected]]
Sent: Mittwoch, 11. April 2018 11:11
To: Baesken, Matthias ; Magnus Ihse Bursie
Cc: build-dev ; Doerr, Martin
Subject
I guess we also need to get an approval from core-libs (cc'd) as libzip
and libjimage are modified.
Regards,
Alexey
On 11/04/2018 10:56, Alexey Ivanov wrote:
The change looks good to me.
On 11/04/2018 10:20, Baesken, Matthias wrote:
Was main() exported via map files?
Seems mai
On 11/04/2018 11:38, Magnus Ihse Bursie wrote:
11 apr. 2018 kl. 11:10 skrev Alexey Ivanov :
On 11/04/2018 08:44, Baesken, Matthias wrote:
JIMAGE_FindResource doesn't have JNICALL modifier now, does it?
Hi Alexey, yes that's true .
Please remove JNIEXPORT from main():
src/java.
.
Anyway, I've just submitted a build job with your changeset and am
running 32 bit Windows build.
Regards,
Alexey
[1] http://openjdk.java.net/census#mbaesken
Best regards , Matthias
-Original Message-
From: Baesken, Matthias
Sent: Mittwoch, 11. April 2018 11:20
To: 'Ale
Hi Matthias,
On 12/04/2018 11:12, Alexey Ivanov wrote:
Hi Matthias,
On 12/04/2018 08:49, Baesken, Matthias wrote:
Hi, could someone please sponsor the change now ?
According to OpenJDK Census page [1], you have committer rights to JDK
project.
And could someone please check what
nge , but
no response so far .
Maybe the submit repo is not working currently , not sure about it .
Best regards , Matthias
-Original Message-
From: Baesken, Matthias
Sent: Mittwoch, 11. April 2018 11:20
To: 'Alexey Ivanov' ; Magnus Ihse Bursie
Cc: build-dev ; D
ken, Matthias wrote:
Hi Alan , this is the up to date webrev .
However we want to add Alexey Ivanov as additional author .
As I read it, this changes the calling convention of these functions on
32-bit Windows but it will have no impact on 64-bit Windows (as
__stdcall is ignored) or other pl
rk as
intended?
Do you have any suggestion on how to address this issue?
/Magnus
On 2018-04-06 00:39, Alexey Ivanov wrote:
Hello,
Could you please review the fix for jdk11?
bug: https://bugs.openjdk.java.net/browse/JDK-8199627
webrev: http://cr.openjdk.java.net/~aivanov/8199627/webrev.0/
Window
st regards, Matthias
-Original Message-----
From: Alexey Ivanov [mailto:[email protected]]
Sent: Donnerstag, 12. April 2018 23:53
To: Phil Race ; Baesken, Matthias
; Alan Bateman ;
Magnus Ihse Bursie
Cc: [email protected]; [email protected]; Doerr,
Martin ;
Hi,
Could you please review the following backport of the build fix for Windows:
jbs: https://bugs.openjdk.java.net/browse/JDK-8179079
review:
http://mail.openjdk.java.net/pipermail/build-dev/2017-April/019045.html
changeset: http://hg.openjdk.java.net/jdk10/jdk10/rev/6426c94ee05f
The patch d
Hi,
Could you please approve this backport to 8u?
Regards,
Alexey
On 18/04/2018 16:27, Erik Joelsson wrote:
Looks good. Thanks for taking care of this backport!
/Erik
On 2018-04-18 05:06, Alexey Ivanov wrote:
Hi,
Could you please review the following backport of the build fix for
Sorry for duplicate request.
Kevin proposes the same changeset, I'll let Kevin proceed as he has many
other build tweaks.
--
Regards,
Alexey
On 18/04/2018 18:13, Alexey Ivanov wrote:
Hi,
Could you please approve this backport to 8u?
Regards,
Alexey
On 18/04/2018 16:27, Erik Joe
Hi,
Could you please review the following fix for jdk11?
bug: https://bugs.openjdk.java.net/browse/JDK-8202476
webrev: http://cr.openjdk.java.net/~aivanov/8202476/jdk11/webrev.0/
This is a follow-up fix for JDK-8201226 which enabled building JDK for
32 bit Windows, its code review:
http://mai
Hi,
Could you please review the following fix for jdk11?
bug: https://bugs.openjdk.java.net/browse/JDK-8202544
webrev: http://cr.openjdk.java.net/~aivanov/8202544/jdk11/webrev.0/
The following exported functions in libzip are not used:
ZIP_GetEntry, ZIP_FreeEntry, ZIP_Lock, ZIP_Unlock, ZIP_Read
t team
as well.
/Magnus
2 maj 2018 kl. 11:52 skrev Alexey Ivanov :
Hi,
Could you please review the following fix for jdk11?
bug: https://bugs.openjdk.java.net/browse/JDK-8202476
webrev: http://cr.openjdk.java.net/~aivanov/8202476/jdk11/webrev.0/
This is a follow-up fix for JDK-8201226 whi
Hi Phil,
Just to confirm: do you approve the change?
Thank you,
Alexey
On 02/05/2018 19:24, Alexey Ivanov wrote:
Hi Phil,
Thank you for your review.
On 02/05/2018 17:28, Phil Race wrote:
So ... the original change that removed the mapfiles broke the 32 bit
build
because of inconsistency
Thank you!
--
Alexey
On 04/05/2018 18:53, Phil Race wrote:
Yes, your confirmation on the testing was all that was needed.
-phil.
On 5/4/2018 10:45 AM, Alexey Ivanov wrote:
Hi Phil,
Just to confirm: do you approve the change?
Thank you,
Alexey
On 02/05/2018 19:24, Alexey Ivanov wrote:
Hi
Any volunteers from core-libs and/or hotspot?
Thank you,
Alexey
On 02/05/2018 13:02, Magnus Ihse Bursie wrote:
Looks good to me, FWIW.
/Magnus
2 maj 2018 kl. 13:52 skrev Alexey Ivanov :
Hi,
Could you please review the following fix for jdk11?
bug: https://bugs.openjdk.java.net/browse/JDK
se).
Best regards
Christoph
-Original Message-
From: build-dev [mailto:[email protected]] On Behalf Of
Alexey Ivanov
Sent: Mittwoch, 9. Mai 2018 16:35
To: core-libs ; hotspot-dev
Cc: build-dev
Subject: Re: [11] RFR for JDK-8202544: Hide unused exports in libzip
Any
Hi,
Could you please review the following fix for 8u-dev?
jbs: https://bugs.openjdk.java.net/browse/JDK-8203790
webrev: http://cr.openjdk.java.net/~aivanov/8203790/jdk8/webrev.0/
There's a missing ‘C‘ in the name, and the compiler flags were not added
which led to the dependency.
Thank you,
Thank you Magnus and Kevin for your quick reviews.
Regards,
Alexey
On 25/05/2018 09:49, Kevin Walls wrote:
Thanks Alexey - my build with this change completed OK too and the
MSVCP dependency in awt.dll has gone, great!
Thanks
Kevin
On 25/05/2018 09:27, Alexey Ivanov wrote:
Hi,
Could
Hi,
Could you please approve the following backport to 8u-dev?
JBS: https://bugs.openjdk.java.net/browse/JDK-8079788
jdk9 changeset: http://hg.openjdk.java.net/jdk9/dev/rev/d57780478145
Code review:
http://mail.openjdk.java.net/pipermail/build-dev/2016-August/017566.html
The patch applies cle
I can fix it before pushing.
Regards,
Alexey
On 29/05/2018 15:13, Erik Joelsson wrote:
Looks good (except for my spelling error in the comment "siutations".
Not sure what the policy is for fixing such in backports.)
/Erik
On 2018-05-29 05:27, Alexey Ivanov wrote:
Hi,
Could
Hi,
Could you please review the following fix for 8u-dev?
JBS: https://bugs.openjdk.java.net/browse/JDK-8179675
webrev: cr.openjdk.java.net/~aivanov/8179675/jdk8/webrev.0/
The problem is that newer grep v3.0 does not match the end-of-line if
the input uses Windows line endings.
The fix remov
Resending with clickable link to the webrev:
http://cr.openjdk.java.net/~aivanov/8179675/jdk8/webrev.0/
--
Alexey
On 12/06/2018 19:06, Alexey Ivanov wrote:
Hi,
Could you please review the following fix for 8u-dev?
JBS: https://bugs.openjdk.java.net/browse/JDK-8179675
webrev: http
Hi Ali,
Can the issue be resolved by using different call modifiers on the
affected functions?
Some build / link issues were resolved by adding / removing JNICALL
modifier, see
https://bugs.openjdk.java.net/browse/JDK-8201226
http://mail.openjdk.java.net/pipermail/build-dev/2018-April/021553
c#L99.
Any thoughts?
Regards,
Ali
On 15 Nov 2018, at 22:14, Alexey Ivanov wrote:
Hi Ali,
Can the issue be resolved by using different call modifiers on the affected
functions?
Some build / link issues were resolved by adding / removing JNICALL modifier,
see
https://bugs.openjdk.java.net/bro
M *vm, jdwpTransportCallback* cbTablePtr,
jint version, jdwpTransportEnv** env)
{
On 16 Nov 2018, at 23:03, Alexey Ivanov wrote:
Hi Ali,
It's exactly what I referred to.
Yes, it does change the calling convention.
Yet it's not a (big) problem because both p
te an
issue?
Regards,
Ali
On 19 Nov 2018, at 12:12, Alexey Ivanov wrote:
Hi Ali,
The fix looks good to me provided it resolves your problem.
I am not a reviewer so you'll have to get OK from reviewers, likely from
build-dev and from core-libs.
Have you submitted the issue in JBS?
Y
rt_OnLoad(JavaVM *vm, jdwpTransportCallback* cbTablePtr,
jint version, jdwpTransportEnv** env)
{
On 16 Nov 2018, at 23:03, Alexey Ivanov wrote:
Hi Ali,
It's exactly what I referred to.
Yes, it does change the calling convention.
Yet it's not a (big) problem because
On 21/11/2018 12:16, Magnus Ihse Bursie wrote:
On 2018-11-20 16:49, Alexey Ivanov wrote:
Hi Ali, Magnus,
I absolutely agree this change has to be reviewed by someone from
serviceability.
There are several options:
1. Add -export:jdwpTransport_OnLoad to LDFLAGS for Windows
http
9 Nov 2018, at 12:12, Alexey Ivanov wrote:
Hi Ali,
The fix looks good to me provided it resolves your problem.
I am not a reviewer so you'll have to get OK from reviewers, likely from
build-dev and from core-libs.
Have you submitted the issue in JBS?
You have to sign OCA to be able t
ssing is some expert
opinion from serviceability-dev if there is any problem with changing
the signature. I'd preferably have that.
If no one knows, I'd say, change it, and see if we still pass the
relevant tests, and if so, ship it.
/Magnus
22 nov. 2018 kl. 18:04 skrev Alexey Ivanov <
Hi,
Could you please review the following fix for jdk12?
bug: https://bugs.openjdk.java.net/browse/JDK-8215123
webrev: http://cr.openjdk.java.net/~aivanov/8215123/webrev.00/
The problem is that calling convention was changed on ZIP_InflateFully
function in zip.dll. Yet it hasn't been updated
an arbitrary function without knowing the size
of function parameters. Could it be the reason why most DLLs export
__stdcall functions undecorated?
Regards,
Alexey
/Magnus
-Simon Tooke
On 12/7/2018 2:09 PM, Alexey Ivanov wrote:
Hi Andrew,
Sorry for my belated reply.
Yes, it's also
Hi everyone,
I came up with the following patch:
http://cr.openjdk.java.net/~aivanov/8214122/webrev.00/
It specifically addresses the problem in JDK-8214122 where on 32 bit
Windows jdwpTransport_OnLoad can exported with its plain and
__stdcall-mangled name. I used conditional compilation so th
Hi Simon,
Thank you for your comments.
The updated webrev:
http://cr.openjdk.java.net/~aivanov/8214122/webrev.01/
Indeed, it looks much cleaner.
Regards,
Alexey
On 11/12/2018 16:43, Simon Tooke wrote:
On 2018-12-11 10:05 a.m., Alexey Ivanov wrote:
Hi everyone,
I came up with the following
On 12/12/2018 12:58, Magnus Ihse Bursie wrote:
On 2018-12-12 12:35, Alan Bateman wrote:
On 12/12/2018 11:14, Magnus Ihse Bursie wrote:
:
I searched the code for "jdwpTransport_On" to see of there was any
corresponding OnUnload function (or other), but could not find any.
That's right, an
Unload"}
#define AGENT_ONATTACH_SYMBOLS {"_Agent_OnAttach@12", “Agent_OnAttach”}
Bob.
On Dec 11, 2018, at 11:43 AM, Simon Tooke wrote:
On 2018-12-11 10:05 a.m., Alexey Ivanov wrote:
Hi everyone,
I came up with the following patch:
http://cr.openjdk.java.net/~aivanov/821412
Hi Simon,
I'd like to clarify some points…
Please see my comments inline:
On 11/12/2018 17:16, Alexey Ivanov wrote:
Hi Simon,
Thank you for your comments.
The updated webrev:
http://cr.openjdk.java.net/~aivanov/8214122/webrev.01/
Indeed, it looks much cleaner.
Regards,
Alexey
On
Ali has scanned the code base, he says, “couldn’t find (hopefully tbh)
other occurrences of such mismatches.”
On 10/12/2018 10:45, Magnus Ihse Bursie wrote:
It might be worthwhile to scan the entire code base for JNICALL and
verify that we have no more mismatches. In general, JNICALL should be
Thank you, Ali, for doing this!
On 10/12/2018 21:13, Ali İnce wrote:
Hi Alexey,
I’ve searched for |GetProcAddress| usages across source code and
couldn’t find (hopefully tbh) other occurrences of such mismatches.
Regards,
Ali
Forgot to add the link:
On 12/12/2018 16:10, Alexey Ivanov wrote:
Ali has scanned the code base, he says, “couldn’t find (hopefully tbh)
other occurrences of such mismatches.”
http://mail.openjdk.java.net/pipermail/build-dev/2018-December/024358.html
On 10/12/2018 10:45, Magnus Ihse Bursie
://docs.microsoft.com/en-us/cpp/build/reference/decorated-names?view=vs-2017#FormatC
[2] https://docs.microsoft.com/en-ie/cpp/cpp/stdcall?view=vs-2017
On 12/12/2018 11:19, Magnus Ihse Bursie wrote:
On 2018-12-11 18:16, Alexey Ivanov wrote:
Hi Simon,
Thank you for your comments.
The updated
On 12/12/2018 16:52, Magnus Ihse Bursie wrote:
On 2018-12-12 16:34, Alexey Ivanov wrote:
On 12/12/2018 12:58, Magnus Ihse Bursie wrote:
On 2018-12-12 12:35, Alan Bateman wrote:
On 12/12/2018 11:14, Magnus Ihse Bursie wrote:
:
I searched the code for "jdwpTransport_On" to se
Any volunteers from core-libs and serviceability to review?
Regards,
Alexey
On 12/12/2018 16:43, Magnus Ihse Bursie wrote:
On 2018-12-12 17:38, Alexey Ivanov wrote:
Hi all,
I have updated the summary of JDK-8214122 and the subject accordingly.
Could you please review the following fix
Thank you, Daniel, for your quick review.
On 19/12/2018 15:05, Daniel D. Daugherty wrote:
On 12/19/18 9:23 AM, Alexey Ivanov wrote:
Any volunteers from core-libs and serviceability to review?
How about former Serviceability Team members? :-) Alan B. and I
both used to be on the
Hi Franco,
On 11/02/2019 02:03, David Holmes wrote:
On 8/02/2019 5:07 am, Franco Gastón Pellegrini wrote:
I tried compiling JDK 12 for 32 bits, and I get similar errors:
=== Output from failing command(s) repeated here ===
* For target hotspot_variant-client_libjvm_objs_classFileParser.obj:
cl
Hi David,
On 11/02/2019 11:33, David Holmes wrote:
Hi Alexey,
On 11/02/2019 7:12 pm, Alexey Ivanov wrote:
Hi Franco,
On 11/02/2019 02:03, David Holmes wrote:
On 8/02/2019 5:07 am, Franco Gastón Pellegrini wrote:
I tried compiling JDK 12 for 32 bits, and I get similar errors:
=== Output
On 12/02/2019 04:25, David Holmes wrote:
On 12/02/2019 1:45 pm, Franco Gastón Pellegrini wrote:
I just downloaded again (to be sure about my errors) JDK 12 and use
this command:
bash ./configure --enable-debug --disable-warnings-as-errors
--with-target-bits=32 --with-toolchain-version=2017
--w
On 12/02/2019 14:37, Magnus Ihse Bursie wrote:
There has been some fallout due to the mapfile/linking changes made in
JDK 12 that affected JNICALL. However, that should not be affecting
JDK 11.
Wasn't it done in JDK 11?
If my memory serves me right, it was done in JDK 11.
--
Alexey
Hi,
Please review the fix for jdk 13.
bug: https://bugs.openjdk.java.net/browse/JDK-8217707
webrev: http://cr.openjdk.java.net/~aivanov/8217707/webrev.0/
Description:
Splash screen functionality is broken in 32 bit Windows. It's because
the functions in splashscreen.dll are exported with decor
Any volunteers for review?
On 24/03/2019 19:18, Alexey Ivanov wrote:
Hi,
Please review the fix for jdk 13.
bug: https://bugs.openjdk.java.net/browse/JDK-8217707
webrev: http://cr.openjdk.java.net/~aivanov/8217707/webrev.0/
Description:
Splash screen functionality is broken in 32 bit Windows
On 28/03/2019 17:15, Philip Race wrote:
> I've run SplashScreen jtreg tests, all tests pass.
I assume you mean you did this for 32 AND 64 bit builds ?
Yes, I ran the tests for both 32 and 64 bit builds.
--
Alexey
If so, then +1
-phil.
On 3/28/19, 9:11 AM, Alexey Ivanov wro
Hi Dmitry,
Apple uses macOS to refer to its operating system, so should we also use
it instead of former OS X?
For HTML version, I would suggest using the following markup
Ctrl +F1 for the keyboard shortcut. [1]
I think using elements for instructions on how to disable
the shortcut is inc
Got it!
Then I'd just drop the quotes from the key names:
- `“CTRL” + “F1”`
+ `Ctrl + F1`
On 25/10/2019 16:52, Erik Joelsson wrote:
The HTML is generated from the markup and should not be edited by hand.
/Erik
--
Regards,
Alexey
Hi Dmitry,
Shall we drop hyphen in the header: “Client UI Tests”?
I think there should be no definite article in this sentence: “use -the-
key sequences”.
“…Turn off Windowss key hotkeys…”, there's an extra ‘s’ in Windows.
”Note: restart is required to make the settings take effect.”
Just to
,
Alexey
On 31/10/2019 10:56, Dmitry Markov wrote:
Hi Alexey,
I have updated the fix based on your recommendation. The new version
is located at: http://cr.openjdk.java.net/~dmarkov/8232880/webrev.02/
Also please find my answers inline.
Thanks,
Dmitry
On 29 Oct 2019, at 19:29, Alexey Ivanov <
Thank you, Dmitry!
The changes look good to me.
On 01/11/2019 13:09, Dmitry Markov wrote:
Hi Alexey,
I have updated the fix. Please find the new version here:
http://cr.openjdk.java.net/~dmarkov/8232880/webrev.03/
Thanks,
Dmitry
On 31 Oct 2019, at 16:27, Alexey Ivanov <mailto:alexey.
Hello,
Could you please review the fix for JDK-8147807 and approve push to 8u-dev?
JBS: https://bugs.openjdk.java.net/browse/JDK-8147807
Webrev: http://cr.openjdk.java.net/~aivanov/8147807/jdk8/webrev.00/
The issue is not relevant to jdk 9.
The fix just removes kcms service leaving lcms as the
I forgot to add jdk8u-dev list...
On 11.02.2016 17:19, Alexey Ivanov wrote:
Hello,
Could you please review the fix for JDK-8147807 and approve push to
8u-dev?
JBS: https://bugs.openjdk.java.net/browse/JDK-8147807
Webrev: http://cr.openjdk.java.net/~aivanov/8147807/jdk8/webrev.00/
The issue
eview.
Regards,
Sean.
On 12/02/2016 08:19, Alexey Ivanov wrote:
I forgot to add jdk8u-dev list...
On 11.02.2016 17:19, Alexey Ivanov wrote:
Hello,
Could you please review the fix for JDK-8147807 and approve push
to 8u-dev?
JBS: https://bugs.openjdk.java.net/browse/JDK-8147807
Webrev:
74 matches
Mail list logo
