Re: RFR: 8275512: Upgrade required version of jtreg to 6.1 [v2]

2021-10-22 Thread Daniel Jeliński
On Wed, 20 Oct 2021 09:28:30 GMT, Leslie Zhai wrote: > requires jtreg version 6.1 b1 or higher This confused me a bit too; I was using jtreg-6+1.tar.gz from [Adoption Group build](https://ci.adoptopenjdk.net/view/Dependencies/job/dependency_pipeline/lastSuccessfulBuild/artifact/jtreg/), and ap

RFR: 8281525: Enable Zc:strictStrings flag in Visual Studio build

2022-02-21 Thread Daniel Jeliński
Please review this PR that enables [Zc:strictStrings](https://docs.microsoft.com/en-us/cpp/build/reference/zc-strictstrings-disable-string-literal-type-conversion?view=msvc-170) compiler flag, which makes assigning a string literal to a non-const pointer a compile-time error. This type of assig

Re: RFR: 8281525: Enable Zc:strictStrings flag in Visual Studio build

2022-02-22 Thread Daniel Jeliński
On Tue, 22 Feb 2022 11:33:52 GMT, Magnus Ihse Bursie wrote: >> Please review this PR that enables >> [Zc:strictStrings](https://docs.microsoft.com/en-us/cpp/build/reference/zc-strictstrings-disable-string-literal-type-conversion?view=msvc-170) >> compiler flag, which makes assigning a string li

Re: RFR: 8281525: Enable Zc:strictStrings flag in Visual Studio build [v2]

2022-02-22 Thread Daniel Jeliński
d that the build passes both with and without `--enable-debug`, both > with VS2017 and VS2019. Daniel Jeliński has updated the pull request incrementally with one additional commit since the last revision: Move strictStrings to toolchain_cflags - Changes: - all: https://

Re: RFR: 8281525: Enable Zc:strictStrings flag in Visual Studio build [v2]

2022-02-22 Thread Daniel Jeliński
On Tue, 22 Feb 2022 16:35:09 GMT, Magnus Ihse Bursie wrote: >> Done > > Did you forget to push the fix? Push works better when connected... this time it's pushed for real. - PR: https://git.openjdk.java.net/jdk/pull/7565

Re: RFR: 8281525: Enable Zc:strictStrings flag in Visual Studio build [v2]

2022-02-24 Thread Daniel Jeliński
On Tue, 22 Feb 2022 16:43:28 GMT, Daniel Jeliński wrote: >> Please review this PR that enables >> [Zc:strictStrings](https://docs.microsoft.com/en-us/cpp/build/reference/zc-strictstrings-disable-string-literal-type-conversion?view=msvc-170) >> compiler flag, which makes

Integrated: 8281525: Enable Zc:strictStrings flag in Visual Studio build

2022-02-24 Thread Daniel Jeliński
On Mon, 21 Feb 2022 19:55:14 GMT, Daniel Jeliński wrote: > Please review this PR that enables > [Zc:strictStrings](https://docs.microsoft.com/en-us/cpp/build/reference/zc-strictstrings-disable-string-literal-type-conversion?view=msvc-170) > compiler flag, which makes assigning a strin

RFR: 8283519: Hsdis with capstone should annotate output

2022-03-22 Thread Daniel Jeliński
Sample output after the changes: [Stub Code] 0x01cd0a937e20: nopl(%rax, %rax); {no_reloc} 0x01cd0a937e25: movabsq $0x0, %rbx ; {static_stub} 0x01cd0a937e2f: jmp 0x1cd0a937e2f ; {runtime_call} [Exception Handler]

Re: RFR: 8283519: Hsdis with capstone should annotate output

2022-03-22 Thread Daniel Jeliński
On Tue, 22 Mar 2022 15:20:38 GMT, Daniel Jeliński wrote: > Sample output after the changes: > > [Stub Code] > 0x01cd0a937e20: nopl (%rax, %rax); {no_reloc} > 0x01cd0a937e25: movabsq $0x0, %rbx ; > {static_stub} >

RFR: 8284720: IntelliJ: JIRA integration

2022-04-11 Thread Daniel Jeliński
This patch adds clickable link to commit messages in IntelliJ's git log. Example result: ![image](https://user-images.githubusercontent.com/30433125/162882312-6a9c7666-075d-47b7-9db5-22670b885e7b.png) - Commit messages: - JIRA integration Changes: https://git.openjdk.java.net/jdk/p

Integrated: 8284720: IntelliJ: JIRA integration

2022-04-13 Thread Daniel Jeliński
On Tue, 12 Apr 2022 04:44:15 GMT, Daniel Jeliński wrote: > This patch adds clickable link to commit messages in IntelliJ's git log. > Example result: > ![image](https://user-images.githubusercontent.com/30433125/162882312-6a9c7666-075d-47b7-9db5-22670b885e7b.png) This pull reques

Re: RFR: 8284890: Support for Do not fragment IP socket options

2022-04-15 Thread Daniel Jeliński
On Thu, 14 Apr 2022 16:04:22 GMT, Michael McMahon wrote: > Hi, > > Could I get the following PR review please? It adds a new JDK specific > extended socket option > called IP_DONTFRAGMENT, which disables IP packet fragmentation in both IPv4 > and IPv6 > UDP sockets (NIO DatagramChannels). For