Re: RFR: JDK-8036003: Add --with-debug-symbols=[none|internal|external|zipped]

a-debug-symbols=none,all (or "none,internal" for consistency). Can I change this option to --enable-java-debug-symbols ? This value set to none or all. So I think that we should use AC_ARG_ENABLE for it. Thanks, Yasumasa On 2015/11/25 23:35, Magnus Ihse Bursie wrote: On 2015-11-21

Re: RFR 8043138: Attach API should not require jvmstat rmi protocol

On 2015-11-25 17:53, Jaroslav Bachorik wrote: On 25.11.2015 11:36, Magnus Ihse Bursie wrote: On 2015-11-25 10:39, Alan Bateman wrote: On 25/11/2015 09:25, Jaroslav Bachorik wrote: I don't think we can just repackage these interfaces - they are remote API and we would break compatibility

Re: RFR: 8139272: Add configure variable to set concurrency for jtreg tests

On 2015-10-20 16:05, Erik Helin wrote: On 2015-10-14, Magnus Ihse Bursie wrote: On 2015-10-09 14:09, Erik Helin wrote: Hi all, this patch adds a new configure variable: --with-test-jobs. The new variable configures how many tests jobs we run concurrently (aka the -concurrency flag to JTReg

Re: RFR: 8073139 PPC64: User-visible arch directory and os.arch value on ppc64le cause issues with Java tooling

On 2015-11-30 05:23, David Holmes wrote: Hi Sasha, Trying to trace through this is somewhat complex :) So ... At the top level if we see ppc64le then we set VAR_CPU to ppc64le instead of ppc64. However, once we get into hotspot build we want ARCH to be ppc64 again (in hotspot-spec.gmk.in)

Re: RFR: JDK-8142336: Convert the SA agent build to modular build-infra makefiles

11:39, Erik Joelsson wrote: Widening the distribution in the hopes of finding another reviewer. I've fixed the formatting in hotspot/make/bsd/makefiles/defs.make locally. Merge tool error. /Erik On 2015-11-11 17:43, Magnus Ihse Bursie wrote: On 2015-11-11 10:31, Erik Joelsson wrote: New

Re: RFR: JDK-8143236: Update devkit creation makefiles for linux

On 2015-11-18 15:26, Erik Joelsson wrote: The makefiles used to create the linux devkit have not been updated to what was actually used to create the current devkit. This patch contains those changes. Bug: https://bugs.openjdk.java.net/browse/JDK-8143236 Webrev:

Re: RFR: JDK-8143141: Bring in minor build changes from the jigsaw/jake forest

On 2015-11-24 12:13, Erik Joelsson wrote: On 2015-11-24 11:47, Magnus Ihse Bursie wrote: On 2015-11-18 14:00, Erik Joelsson wrote: After posting this, I started thinking and I realized the biggest change here is not needed. I was able to revert all of the GENSRC_OUTPUTDIR, HEADERS_OUTPUTDIR

Re: RFR: JDK-8143141: Bring in minor build changes from the jigsaw/jake forest

On 2015-11-18 14:00, Erik Joelsson wrote: After posting this, I started thinking and I realized the biggest change here is not needed. I was able to revert all of the GENSRC_OUTPUTDIR, HEADERS_OUTPUTDIR, NATIVE_OUTPUTDIR and MODULES_*_OUTPUTDIR variables in jigsaw/jake and subsequently those

Re: RFR 8141690: JDK-8133151 change to MakeJavaSecurity.java is not complete

On 2015-11-20 02:12, Wang Weijun wrote: Ding dong. Even though this code resides in the make directory, it is not really build code, so I cannot comment on it. /Magnus On Nov 9, 2015, at 3:35 PM, Wang Weijun wrote: Hi All Please review the code change at

Re: RFR: JDK-8143141: Bring in minor build changes from the jigsaw/jake forest

Bursie wrote: On 2015-11-24 12:13, Erik Joelsson wrote: On 2015-11-24 11:47, Magnus Ihse Bursie wrote: On 2015-11-18 14:00, Erik Joelsson wrote: After posting this, I started thinking and I realized the biggest change here is not needed. I was able to revert all of the GENSRC_OUTPUTDIR

Re: RFR: JDK-8143895: Fix LDFLAGS issues after JDK-8056925

On 2015-11-24 14:00, Erik Joelsson wrote: Please review this minor build fix. I'd prefer it if you use only lower case on the libs, as we do elsewhere, and also on the -stack flag (as we do elsewhere for pronouncable windows flags). /The Nit Picker :) Bug:

Re: RFR: JDK-8143895: Fix LDFLAGS issues after JDK-8056925

)/modules_cmds/jdk.accessibility, \ PROGRAM := jaccesswalker$1, \ Also noticed an extra '=' that I removed. It was causing warnings with cl.exe. Cool. :-) Looks good now. /Magnus /Erik On 2015-11-24 14:10, Magnus Ihse Bursie wrote: On 2015-11-24 14:00, Erik Joelsson wrote: Please

Re: RFR: JDK-8143296: javac-server/sjavac not compatible with LogFailures on Windows

On 2015-11-19 12:10, Erik Joelsson wrote: On Windows, when trying to use the new javac-server mode (or sjavac), each java compilation process that spawns a javac server ends up waiting for that server to shut down before shutting down itself. This behavior is caused by the new LogFailure

Re: RFR: JDK-8142983: Enable builds with icecc/icecream

On 2015-11-13 20:55, Erik Joelsson wrote: We should enable builds using icecc/icecream distributed native compilation. The setup is rather simple and the required changes to configure are no more complex than how we currently handle ccache. I have done some experiments and it seems to be

Re: JDK-8146091: Configure fails to configure icecc on OEL

Looks good to me. /Magnus On 2015-12-23 13:03, Erik Joelsson wrote: Hello, The icecc-create-env utility in older icecc distributions takes input parameters differently. On my Ubuntu: $ /usr/lib/icecc/icecc-create-env usage: /usr/lib/icecc/icecc-create-env --gcc usage:

Re: RFR: JDK-8146403: Windows build can be faster

Hi, In InitSupport.gmk, please restore the comment: # Only do this if make has not been restarted, and if we do not force it. In jdk/make/gensrc/GensrcExceptions.gmk: The old construct resulted in the output "Generating exceptions classes" (but a bit irregularly), could you please re-add it

Re: RFR: JDK-8146403: Windows build can be faster

cases. Typically when building more than one conf at a time or when doing a compare build. I added explicit calls to GenerateModuleDeps.gmk to fix this. /Erik On 2016-01-13 12:48, Magnus Ihse Bursie wrote: Hi, In InitSupport.gmk, please restore the comment: # Only do this if make has not been

Re: RFR: JDK-8147086: Excluding of copy files broken after JDK-8144226

On 2016-01-14 12:06, Erik Joelsson wrote: Since JDK-8144226, the java.desktop module is including more resource files than it used to. This is caused by a small bug in SetupJavaCompilation.gmk that fails to apply exclude patterns on files to be copied. The fix is simple: diff -r 4b01ea6c12c3

Re: RFR: JDK-8146403: Windows build can be faster

On 2016-01-14 12:01, Erik Joelsson wrote: On 2016-01-14 11:53, Magnus Ihse Bursie wrote: On 2016-01-14 11:43, Erik Joelsson wrote: Hello, Thinking more about the new bootstrap logic, I feel that I don't like the solution. Here is a new patch where I only changed that part. I reverted

Re: Is there any valid reason that a debug or fastdebug build should define PRODUCT and not ASSERT during compiles?

On 2016-01-08 23:07, Derek White wrote: [This is likely a bug, but thought I'd ask it as a question first]. I'm new to jdk builds on windows, and have spent way more time than I'd like to admit on figuring out why my fastdebug builds did not have asserts turned on. The TL;DR; answer is that

Re: RFR:

I agree. It seems better to collect all test output in a central place. /Magnus > 13 jan. 2016 kl. 16:15 skrev Roger Riggs : > > $.02, for testoutput/hotspot > > so that if other repos do something similar they are all under testoutput/... > > Roger > > >> On

RFR: JDK-8146995 Introduce named arguments in configure

Similar to how we use named argument in makefiles, we should support named arguments in the configure scripts. This is possible using some m4 black magic. My long-term goal with this is to provide readable functions for handling common patterns, like parsing --with arguments and doing proper

RFR: JDK-8147091 Remove debug output in basics.m4

Unfortunately a piece of debug output slipped into basics.m4 some time ago. That it hasn't been discovered until now is probably proof that nobody reads the output from configure. :-& Bug: https://bugs.openjdk.java.net/browse/JDK-8147091 Diff inline: diff --git a/common/autoconf/basics.m4

Re: RFR: JDK-8146403: Windows build can be faster

xplicit calls to > GenerateModuleDeps.gmk to fix this. > > /Erik > >> On 2016-01-13 12:48, Magnus Ihse Bursie wrote: >> Hi, >> >> In InitSupport.gmk, please restore the comment: >> # Only do this if make has not been restarted, and if we do not for

Re: Build errors on OS X "Failed module access verification"

On 2016-01-14 19:32, Scott Palmer wrote: I managed to get configure working by installing freetype via XQuartz and forcing it to be found with ./configure --with-freetype=/opt/X11 I'm building on OS X 10.11.2. The table in Appendix C: Build Environments or the README-builds.html file says

Re: RFR: JDK-8145549 Add support for Visual Studio 2015 Community edition

on the java side. Is the function useless now? Max, Is your intention here that you think the patch should remove the entire Java_sun_security_mscapi_KeyStore_getKeyLength function? /Magnus Thanks Max On Dec 16, 2015, at 9:50 PM, Magnus Ihse Bursie <magnus.ihse.bur...@oracle.com>

Re: RFR: JDK-8145549 Add support for Visual Studio 2015 Community edition

On 2016-01-05 03:25, Kim Barrett wrote: On Dec 18, 2015, at 7:41 PM, Kim Barrett <kim.barr...@oracle.com> wrote: On Dec 16, 2015, at 8:50 AM, Magnus Ihse Bursie <magnus.ihse.bur...@oracle.com> wrote: Bug: https://bugs.openjdk.java.net/browse/JDK-8145549 WebRev: http://cr.open

Re: Configure(still?) broken on OS X

On 2016-01-14 15:59, Scott Palmer wrote: I installed XQuartz, rebooted, and re-ran configure. Got the exact same error. Seems the path to freetype in XQuartz is not fixed. How did you install XQuartz? Can you check that you indeed have freetype installed on the system, and let us know

Re: RFR: JDK-8129395 Configure should verify that -fstack-protector is valid - take 2

/2016 8:48 PM, Magnus Ihse Bursie wrote: A previous fix to check if -fstack-protector is accepted by gcc failed, since when testing the option, gcc emitted a warning and not an error. The one thing I'm thinking here about is if the ssp-buffer-size option should be more tightly coupled with the -fstack

Re: RFR: JDK-8148929: Suboptimal code generated when setting sysroot include with Solaris Studio

On 2016-02-03 14:33, Erik Joelsson wrote: On 2016-02-03 13:59, David Holmes wrote: Hi Erik, On 3/02/2016 10:48 PM, Erik Joelsson wrote: Hello, Please review this small fix for building on Solaris using a devkit/sysroot. The Solaris Studio compiler does special inlining and intrinsics with

Re: RFR: JDK-8148929: Suboptimal code generated when setting sysroot include with Solaris Studio

. /Erik On 2016-02-04 13:43, Erik Joelsson wrote: I will investigate and report back. /Erik On 2016-02-04 13:29, David Holmes wrote: On 4/02/2016 9:27 PM, Magnus Ihse Bursie wrote: On 2016-02-03 14:33, Erik Joelsson wrote: On 2016-02-03 13:59, David Holmes wrote: Hi Erik, On 3/02/2016 10:48

Re: RFR: JDK-8031767 Support system or alternative implementations of zlib

On 2016-02-05 21:50, Alan Bateman wrote: On 05/02/2016 18:55, Xueming Shen wrote: Hi Please help codereview the change to build the jdk9 runtime to use the system zlib on Solaris and Linux platforms by default. Issue: https://bugs.openjdk.java.net/browse/JDK-8031767 Webrev:

Re: RFR(XS) : 8144695 : --disable-warnings-as-errors does not work for HotSpot build

On 2016-02-08 20:37, Kim Barrett wrote: On Feb 7, 2016, at 4:22 PM, Igor Ignatyev wrote: Hi Kim, could you please take a look at the updated webrev: http://cr.openjdk.java.net/~iignatyev/8144695/webrev.03 I agree that “+w” isn’t related to WARNINGS_ARE_ERRORS, so

Re: question on jigsaw build

On 2016-01-25 13:43, Maurizio Cimadamore wrote: Hi, the current build system in JDK 9 has a way to recover all the source dirs for a given module, by doing something like this: $(call ALL_SRC_DIRS,$(mod)) That is, the build system exports a function that can be passed a module name and will

Re: RFR: JDK-8149466: configure failed after JDK-8148351

On 2016-02-09 14:43, Yasumasa Suenaga wrote: > Hi all, > > After JDK-8148351, configure script failed as below: > > > configure: Using default toolchain gcc (GNU Compiler Collection) > checking for gcc... /usr/lib64/ccache/gcc > checking resolved symbolic links for CC... /usr/bin/ccache

Re: RFR: JDK-8149466: configure failed after JDK-8148351

o achieve this is to use --enable-ccache. If you just add --enable-ccache, you're not doing this "instead of". /Magnus > > Thus I think that we should fix to affect --enable-cache to these logic. > > > Thanks, > > Yasumasa > > > On 2016/02/09 23:14, Magn

Re: [9] RFR: 8147754: Configure fails to detect freetype installed by XQuartz on OSX 10.11

Looks good to me. /Magnus > 8 feb. 2016 kl. 19:39 skrev David DeHaven : > > > JBS link: > https://bugs.openjdk.java.net/browse/JDK-8147754 > > Please review this small fix for locating Freetype with the updated version > of XQuartz (for OSX 10.11): > > --- cut

RFR: JDK-8129395 Configure should verify that -fstack-protector is valid - take 2

A previous fix to check if -fstack-protector is accepted by gcc failed, since when testing the option, gcc emitted a warning and not an error. The one thing I'm thinking here about is if the ssp-buffer-size option should be more tightly coupled with the -fstack-protector flag. It does not

Re: RFR: JDK-8149647 Incremental enhancements from build-infra

l, as part of the patch. Hope you don't mind. :) /Magnus /Erik On 2016-02-11 12:20, Magnus Ihse Bursie wrote: Here is another batch of small fixes and enhancements from the build-infra project forest. * Compiler version framework: - Create a TOOLCHAIN_CHECK_COMPILER_VERSION macr

Re: RFR: 8149594 - Clean up Hotspot makefiles

On 2016-02-11 08:35, Jesper Wilhelmsson wrote: Den 11/2/16 kl. 03:07, skrev David Holmes: Jesper, Magnus is rewriting all of the hotspot build system. Are these cleanups really worthwhile at this stage? The cleanups are worthwhile to me since I work on mostly Mac and port all my changes

Re: RFR: 8149594 - Clean up Hotspot makefiles

On 2016-02-10 23:10, Jesper Wilhelmsson wrote: Sending again to include the build-dev list. /Jesper Den 10/2/16 kl. 21:31, skrev Jesper Wilhelmsson: Hi, Please review this cleanup of the Hotspot makefiles. Since I have been spending some time in the makefiles lately there were a few random

Re: [8u-dev] Request for review and approval for bug 8147807: crash in libkcms.so on linux-sparc

On 2016-02-12 10:15, Seán Coffey wrote: Approved for jdk8u-dev once you have a peer code review. Makefile change look good. /Magnus Regards, Sean. On 12/02/2016 08:19, Alexey Ivanov wrote: I forgot to add jdk8u-dev list... On 11.02.2016 17:19, Alexey Ivanov wrote: Hello, Could you

Re: RFR: JDK-8149479: Fix compare.sh to have a clean baseline with COMPARE_BUILD

On 2016-02-10 07:13, Tim Bell wrote: Erik: Please review these fixes for compare.sh and the COMPARE_BUILD flag for make. The rather new feature COMPARE_BUILD, which builds twice, applying some kind of change between them, is really neat. Especially when run through JPRT to check all

Re: RFR: JDK-8149479: Fix compare.sh to have a clean baseline with COMPARE_BUILD

On 2016-02-10 14:11, Erik Joelsson wrote: Hello Tim, New webrev: http://cr.openjdk.java.net/~erikj/8149479/webrev.02/ I agree about 1, so I started looking at it. Got confused why any changes to it didn't seem to have any effect until I realized the docs are no longer compared, which is what

RFR: JDK-8149647 Incremental enhancements from build-infra

Here is another batch of small fixes and enhancements from the build-infra project forest. * Compiler version framework: - Create a TOOLCHAIN_CHECK_COMPILER_VERSION macro - Test for minimum versions for certain compilers in configure * Start supporting mapfiles on all platforms (windows and

Re: RFR: JDK-8148629: Disable remaining warnings in awt/fontmanager

On 2016-02-05 10:41, Erik Joelsson wrote: Magnus pointed out that I mistakenly replaced fno-strict-aliasing with -Wno-strict-aliasing. Reverted that change. http://cr.openjdk.java.net/~erikj/8148629/webrev.jdk.02/ The new webrev looks good to me. However, the use of -w for individual files

Re: RFR: JDK-8148929: Suboptimal code generated when setting sysroot include with Solaris Studio

investigate and report back. >> >> /Erik >> >>> On 2016-02-04 13:29, David Holmes wrote: >>>> On 4/02/2016 9:27 PM, Magnus Ihse Bursie wrote: >>>>> On 2016-02-03 14:33, Erik Joelsson wrote: >>>>> >>>>> >>>

Re: RFR: JDK-8148929: Suboptimal code generated when setting sysroot include with Solaris Studio

On 2016-02-04 21:33, Magnus Ihse Bursie wrote: Blir det skillnader mot vårt gamla bygge med devkit men utan din nya fix, eller mellan devkit med din fix och en icke-devkit där man inte använder sysroot? Dvs kan din fix göra så att devkit blir identiskt med utan devkit? I apologize

RFR: JDK-8148416 Fix merge error in hotspot.m4 introduced in Merge changeset 8b46c6cecc37

A merge error occured in changeset 8b46c6cecc37 in the file hotspot.m4. Bug: https://bugs.openjdk.java.net/browse/JDK-8148416 Patch inline: diff --git a/common/autoconf/hotspot.m4 b/common/autoconf/hotspot.m4 --- a/common/autoconf/hotspot.m4 +++ b/common/autoconf/hotspot.m4 @@ -266,14 +266,3 @@

Re: 8035473: [javadoc] Revamp the existing Doclet APIs

On 2016-01-26 08:49, Jonathan Gibbons wrote: On 01/25/2016 06:20 AM, Magnus Ihse Bursie wrote: On 2016-01-23 00:49, Jonathan Gibbons wrote: On 01/22/2016 03:41 PM, Magnus Ihse Bursie wrote: In make/Javadoc.gmk: What's the story with all these old doclet duplication? The story

Re: RFR: JDK-8148416 Fix merge error in hotspot.m4 introduced in Merge changeset 8b46c6cecc37

On 2016-01-28 06:49, David Holmes wrote: On 28/01/2016 8:40 AM, Magnus Ihse Bursie wrote: A merge error occured in changeset 8b46c6cecc37 in the file hotspot.m4. Very odd given the file was brand new prior to the merge. I split out half the contents of the jdk-options.m4 into the new file

Re: RFR: JDK-8148655 LOG=cmdlines and other build-infra fixes

a WriteFileInRecipe version either. So I couldn't figure out a way to do that that I was happy with. But I'm open to suggestions (or even better, working code :-)). /Magnus /Erik On 2016-01-30 11:27, Magnus Ihse Bursie wrote: This is yet another collection of fixes from the build-infra hotspo

Re: RFR(M) 8069540: Remove universal binaries support from hotspot build

On 2016-01-29 18:04, Erik Joelsson wrote: (adding build-dev) Looks good enough to me. Looks good to me too. /Magnus /Erik On 2016-01-29 17:51, Gerard Ziemski wrote: Hi all (and especially the makefiles experts), This fix removes support for building hotspot universal libraries on Mac

RFR: JDK-8148655 LOG=cmdlines and other build-infra fixes

This is yet another collection of fixes from the build-infra hotspot project forest that has a stand-alone value. The most important change is the support of a new log option, cmdlines. This is, like the old "nofile", an option that can be added to a log level, e.g. "LOG=info,cmdlines" or

Re: RFR: JDK-8148655 LOG=cmdlines and other build-infra fixes

On 2016-02-02 09:49, Erik Joelsson wrote: On 2016-02-01 22:36, Magnus Ihse Bursie wrote: On 2016-02-01 16:01, Erik Joelsson wrote: Hello, InitSupport.gmk: The comment still refers to ",nofile". I'll fix. I would probably have made an effort to replace "$(ECHO) $(call

Re: RFR: 8148302: Initial Bringup of Android in mobile/dev

On 2016-01-27 17:15, Bob Vandette wrote: On Jan 27, 2016, at 4:56 AM, Magnus Ihse Bursie <magnus.ihse.bur...@oracle.com> wrote: On 2016-01-26 20:50, Bob Vandette wrote: Please review the changes for two improvements for the Mobile Dev Forest. With these changes, the mobile/dev fore

Re: RFR: 8148302: Initial Bringup of Android in mobile/dev

the right kind of semantics. The new webrev looks good to me. Thank you Bob for helping keeping the quality of the build system code high! /Magnus Thanks, Bob. On Jan 27, 2016, at 4:56 AM, Magnus Ihse Bursie <magnus.ihse.bur...@oracle.com> wrote: On 2016-01-26 20:50, Bob Vandette

Re: [rfc] Avoid failure when compiler is wrapped.

On 2016-01-27 17:54, Jiri Vanek wrote: On 01/27/2016 11:09 AM, Magnus Ihse Bursie wrote: On 2016-01-25 21:38, Andrew Hughes wrote: - Original Message - Hello! When compiler is wrapped, the configure phase of build fails: [...] checking for gcc... /usr/lib64/cscppc/gcc configure

Re: RFR: JDK-8150456: jdk 9 nightly build fails on Windows 32 bit

On 2016-02-23 23:50, Erik Joelsson wrote: The windows 32 bit build is currently DOA. In JDK-8150203, the following build warning on Windows x64 was eliminated: CRC32.c: warning LNK4197: export 'ZIP_CRC32' specified multiple times; using first specification This warning is emitted because

Re: RFR(S): JDK-8150197: Integrate AIX fixes from build-infra

On 2016-02-20 15:19, Erik Joelsson wrote: Looks good to me. Looks good to me to. I'll push it for you, Volker. /Magnus /Erik On 2016-02-19 09:20, Volker Simonis wrote: Hi, can I please have a reviewer and sponsor for this AIX build change:

Re: RFR: JDK-8150822: Fix typo in JDK-8150201

Looks good to me. /Magnus > 29 feb. 2016 kl. 11:19 skrev Erik Joelsson : > > In JDK-8150201, some debug flags were corrected. In one of the overrides, the > file name was misspelled so the debug flag correction is not in effect. > > Bug:

Re: sjavac problems continue

I've noted this as well. We should probably store the port file in /tmp, instead of in the build directory. /Magnus > 24 feb. 2016 kl. 19:17 skrev Andreas Lundblad : > >> On Wed, Feb 24, 2016 at 09:33:55AM +0100, Thomas Stüfe wrote: >> Just to add another small

Re: RFR: JDK-8147933: Configure check for number of cpus ignores HT on Macosx

then # Windows, but without cygwin /Erik On 2016-01-21 12:06, Magnus Ihse Bursie wrote: On 2016-01-21 11:45, Erik Joelsson wrote: On all other platforms except Macosx, the logic for detecting number of cpus includes hyperthreading in their count. We do see some speedup from setting the make

Re: Configure(still?) broken on OS X

On 2016-01-19 23:40, David DeHaven wrote: Thanks, looks like this does the trick: ./configure --with-freetype=/opt/X11 This came up a while back, probably on another list... XQuartz had to change the install location due to 10.11 not allowing installation to /usr/X11, so our configure script

Re: 8035473: [javadoc] Revamp the existing Doclet APIs

On 2016-01-22 23:50, Kumar Srinivasan wrote: Hi All, Please review the following build changes: JDK changes: * simple entry point change http://cr.openjdk.java.net/~ksrini/8035473/webrev.07/webrev.jdk.0/ Looks good. Top forest repo: * configuration changes to use the new javadoc/doclet

Re: 8035473: [javadoc] Revamp the existing Doclet APIs

On 2016-01-24 00:18, Kumar Srinivasan wrote: HI Magnus, In make/gensrc/Gensrc-jdk.javadoc.gmk: Did you mean to remove the old javadoc version.properties? If not, and you want two files from now on, you need to give them unique names as the first argument, e.g. OLD_JAVADOC_VERSION and

Re: 8035473: [javadoc] Revamp the existing Doclet APIs

On 2016-01-23 00:49, Jonathan Gibbons wrote: On 01/22/2016 03:41 PM, Magnus Ihse Bursie wrote: In make/Javadoc.gmk: What's the story with all these old doclet duplication? The story is that we're adding a completely new public API, and there are existing users of the existing API, both

Re: RFR: JDK-8148120 Incremental update from build-infra project

that the code I based it on had been simplified. Updated webrev: (only NativeCompilation.gmk changed) http://cr.openjdk.java.net/~ihse/JDK-8148120-incremental-updates-from-build-infra/webrev.02 /Magnus /Erik On 2016-01-24 09:56, Magnus Ihse Bursie wrote: This patch contains a series of small

Re: RFR: JDK-8147795 Build system support for BSD

On 2016-01-20 13:06, David Holmes wrote: On 20/01/2016 9:15 PM, Alan Bateman wrote: On 20/01/2016 10:54, Magnus Ihse Bursie wrote: During my spare time last autumn, and in the holidays, I've been playing around with the three major BSDs (FreeBSD, OpenBSD and NetBSD), trying to learn something

RFR: JDK-8148120 Incremental update from build-infra project

This patch contains a series of small fixes of general applicability that have been created in the build-infra project. These are: * Add missing llvm library dependency * Improve compare script for static libraries * Simplify LogFailures interface, and add support for storing command lines *

Re: RFR: JDK-8147449: sjavac builds of jdk9/dev with closed sources broken

On 2016-01-19 11:31, Erik Joelsson wrote: Hello, Please review this fix in the makefiles for using sjavac. The include/exclude mechanism in sjavac has changed. We used to sometimes exclude files using a full absolute path. This no longer works. The same thing can be achieved by splitting up

Re: RFR: JDK-8147795 Build system support for BSD

On 2016-01-20 11:54, Magnus Ihse Bursie wrote: During my spare time last autumn, and in the holidays, I've been playing around with the three major BSDs (FreeBSD, OpenBSD and NetBSD), trying to learn something new. (Yeah, I know, this proves that I have no life :-)). And what better way

Re: RFR: JDK-8147786: Building hotspot gives error message from find

On 2016-01-20 10:16, Erik Joelsson wrote: Due to a collision between two fixes (JDK-8146403 and JDK-8067194), whenever we build hotspot now we get the message: /usr/bin/find: `/localhome/hg/jdk9-dev-ALT/hotspot/agent': No such file or directory Bug:

RFR: JDK-8147795 Build system support for BSD

During my spare time last autumn, and in the holidays, I've been playing around with the three major BSDs (FreeBSD, OpenBSD and NetBSD), trying to learn something new. (Yeah, I know, this proves that I have no life :-)). And what better way to learn an operating system than to try and build

Re: [rfc] Avoid failure when compiler is wrapped.

On 2016-01-25 21:38, Andrew Hughes wrote: - Original Message - Hello! When compiler is wrapped, the configure phase of build fails: [...] checking for gcc... /usr/lib64/cscppc/gcc configure: Resolving CC (as /usr/lib64/cscppc/gcc) failed, using /usr/lib64/cscppc/gcc directly. checking

RFR: JDK-8148351 Only display resolved symlink for compiler, do not change path

During toolchain detection, if the found compiler (CC or CXX) is a symbolic link, we resolve it and point to the resolved binary. This was introduced to be able to debug systems with a broken setup, but it breaks use cases were a CC wrapper is used. A better solution is to just print the path

Re: RFR (L) JEP 280: Indify String Concatenation (integration)

On 2016-01-27 14:55, Aleksey Shipilev wrote: Hi again, This is a formal pre-integration review thread for JEP 280 ("Indify String Concatenation") integration: http://openjdk.java.net/jeps/280 The JEP is Targeted, the CCC is approved, the code reviews and pre-integration checks are clean.

Re: RFR: 8148302: Initial Bringup of Android in mobile/dev

On 2016-01-26 20:50, Bob Vandette wrote: Please review the changes for two improvements for the Mobile Dev Forest. With these changes, the mobile/dev forest can successfully build x86 and ARM Android JDK 9 binaries. The ARM binaries use the Zero ARM interpreter while the x86 implementation

Re: RFR: 8148361: Need to disable the thread local storage compiler option for ios

On 2016-01-27 13:42, Gary Adams wrote: When the sync with jdk9 b102 was pulled into mobile/dev repos a new feature for thread local storage was over looked. Most modern compilers include support for thread local declaration, but this feature is intentionally not supported by Apple's clang

Re: RFR: JDK-8149963: build errors during API docs build

On 2016-02-17 11:16, Erik Joelsson wrote: Hello, There is a dependency issue in the Javadoc makefile when building custom additions. Since the include of the custom Javadoc.gmk happens before the core api build rule declaration, the targets in the custom file cannot properly depend on the

RFR (S): JDK-8150201 Restore missing -g flags to files with OPT_CFLAGS/per-file

There seems to be a bit of confusion as to OPT_CFLAGS meant "CFLAGS for optimization" or "CFLAGS for optimized/product build". Some usages seems to suggest the first interpretation, while other usages seems to have made the second (where OPT_CFLAGS align with DEBUG_CFLAGS/FASTDEBUG_CFLAGS).

RFR: JDK-8150203 Incremental update from build-infra project

More incremental fixes from the build-infra project. The list of fixes include: * More ExecuteWithLog. * Native buildtools fixes. * Make DTDParser quiet. * LIBM cleanups. * Export LDFLAGS_HASH_STYLE. * Remove superfluous -export on LDFLAGS_windows. (JNIEXPORT used) * Don't let make reconfigure

RFR: JDK-8150257 Remove softfloat lib support

We have some quite ugly hacks in place to support injecting the softfloat lib on certain platforms. This is not needed anymore and should be removed. Bug: https://bugs.openjdk.java.net/browse/JDK-8150257 WebRev:

Re: Compile error on Solaris (Bad value 'wbadlkginit' for flag '-erroff')

On 2016-02-19 09:40, Volker Simonis wrote: On Thu, Feb 18, 2016 at 9:45 PM, Magnus Ihse Bursie <magnus.ihse.bur...@oracle.com> wrote: On 2016-02-18 11:17, Volker Simonis wrote: Thanks. Unfortunately, --disable-warnings-as-errors doesn't help in this case. If we want to still make it po

Re: RFR: JDK-8145789: Switch JDK 9 to use Jib in JPRT

On 2016-02-10 17:27, Erik Joelsson wrote: Accidentally left some debug lines. Also reverted the change to set --with-jobs. http://cr.openjdk.java.net/~erikj/8145789/webrev.top.03/ Looks good to me. Go jib! :) /Magnus /Erik On 2016-02-09 21:00, Erik Joelsson wrote: This never made it in

Re: RFR: JDK-8153969: Clean up module src dir logic

Looks great! Nice cleanup/abstraction. By "multiple" calls, you mean nested calls, not concatenated. This was not immediately clear to me. Maybe clarify that in the comment to PathList. Also, it mentions -classpath but this applies to modulepath as well. /Magnus > 12 apr. 2016 kl. 15:44

Re: RFR(S): 8154087: Fix AIX and Linux/ppc64le after the integration of the new hotspot build

Looks good to me. /Magnus > 12 apr. 2016 kl. 18:03 skrev Volker Simonis : > > Hi, > > can I please have a review for the following trivial changes to make > the build work again on AIX and Linux/ppc64le after the integration of > the new hotspot build system. The

Re: RFR: JDK-8149777: Enable enhanced failure handler for "make test"

Is the test-failure-handle used to test that the failure handler is correct? It seems a bit odd, since most other tests has their main purpose to be run, and the build part is just a necessary thing, but here I presume that the main thing is to build the handler so other tests can use it, and

Re: RFR: JDK-8152666: The new Hotspot Build System

On 2016-04-06 11:10, Erik Joelsson wrote: Hello Dan and thank you for the review! I know it's a lot to chew through. I have incorporated your changes and published a new webrev: http://cr.openjdk.java.net/~erikj/8152666/webrev.02/ I'm not sure if I'm formally allowed to be a reviewer, since

Re: RFR: JDK-8151973: Add Jib and JPRT configuration for linux-arm64 open only

On 2016-04-07 11:55, Erik Joelsson wrote: Any chance I could get a reivew for this? I think the profile should be named "linux-aarch64", since that's how the open platform port refers to itself, and also to avoid collision with the closed "arm64" port. Otherwise, the patch looks good.

Re: RFR: JDK-8150504: JIB profiles for reference implementation builds

On 2016-03-03 14:15, Erik Joelsson wrote: We need to define a couple of new Jib profiles specifically for builds of just open jdk. These are needed for our internal reference implementation builds. Bug: https://bugs.openjdk.java.net/browse/JDK-8150504 Webrev:

Re: problems with freetype.dll, jdk 8 and windows

On 2016-03-06 21:59, Hendrik Schreiber wrote: Hey there, I’m trying to build a 32 bit JDK8u with Windows. And hoorray! it’s building just fine. But when running some software I run into: java.lang.UnsatisfiedLinkError: C:\…\jre\bin\freetype.dll: %1 is not a valid Win32 application

Re: Provide zipped javadoc archive from make

Actually, RM is "rm -f" so $(RM) -f is redundant. /Magnus > 31 mars 2016 kl. 07:18 skrev Erik Joelsson : > > Hello, > > The comment has not been updated after the dependencies changed. > > Please use $(MKDIR), $(RM) -f and $(LN). > > There is no need for the dash

Re: RFR: JDK-8149777: Enable enhanced failure handler for "make test"

set of tests. The old makefile had a target for > running those so I felt I needed to keep that functionality. I agree the make > target can be confusing, but I couldn't find a better one. > > /Erik > >> On 2016-04-13 12:48, Magnus Ihse Bursie wrote: >> Is the test-fail

Re: RFR: JDK-8154326: bash >(...) construct causes race conditions

Looks ok. Going forward, do you think we would be helped by a specially crafted native binary that does this for us with a single call? Something like the Windows path converter, but available on all platforms? /Magnus > 20 apr. 2016 kl. 17:20 skrev Erik Joelsson : >

Re: RFR: JDK-8154326: bash >(...) construct causes race conditions

> 22 apr. 2016 kl. 10:35 skrev Erik Joelsson <erik.joels...@oracle.com>: > > > >> On 2016-04-22 10:12, Magnus Ihse Bursie wrote: >> Looks ok. >> >> Going forward, do you think we would be helped by a specially crafted native >> binary that doe

Re: RFR: JDK-8136777: Introduce bundle targets

Looks good to me. Just fix the indentation in MakeBase.gmk that got messed up. /Magnus > 9 maj 2016 kl. 19:18 skrev Erik Joelsson : > > Hello, > > This change introduces bundle targets for the OpenJDK build, which creates > the same tar.gz and zip bundles as the

Re: RFR: JDK-8154326: bash >(...) construct causes race conditions

Looks good to me. /Magnus > 19 apr. 2016 kl. 14:32 skrev Erik Joelsson : > > Hello, > > After switching to the new hotspot build, we have seen some sporadic build > errors related to the generation of dtrace JvmOffsets.h file on Solaris. The > errors look like a

Re: RFR(XXS): 8149519: Investigate implementation of java.specification.version

Some background on this: I initially introduced VERSION_SPECIFICATION as VERSION_MAJOR but had to revert it in the Verona branch since I was told that the specification number should be identical to the release version. My initial reaction was the same as yours, that the specification would

RFR: JDK-8174069 Verify that bash is at least version 3.2

The build system uses features in make that was not present before 3.2. Bash 3.2 was released in 2007 so only very old systems is on 3.1 or older. However, we fail with strange error messages on such old systems, so we should check the version in configure. Bug:

<    4   5   6   7   8   9   10   11   12   13   >