JDK 10 Review Request for JDK-8176583: Move currency data to /lib

2017-06-13 Thread Nishit Jain
-8176583 at i18n-dev: http://mail.openjdk.java.net/pipermail/i18n-dev/2017-June/002307.html Regards, Nishit Jain

Re: JDK 10 Review Request for JDK-8176583: Move currency data to /lib

2017-07-16 Thread Nishit Jain
. Regards, Nishit Jain On 14-07-2017 23:16, Roger Riggs wrote: Hi Nishit, I haven't seen any comments in the past month... From the code perspective, this looks ok. It should have a build Reviewer too. Thanks, Roger On 6/13/2017 12:57 PM, Nishit Jain wrote: Hi, Please review the fix fo

[10] RFR JDK-8177472: Remove hard-coded IANA Subtag Registry map in LocaleEquivalentMap.java

2017-07-19 Thread Nishit Jain
EquivMapsGenerator.java (if required) for the generated maps file. Regards, Nishit Jain

Re: [10] RFR JDK-8177472: Remove hard-coded IANA Subtag Registry map in LocaleEquivalentMap.java

2017-07-25 Thread Nishit Jain
A gentle reminder! Requesting for a build review Regards, Nishit Jain On 20-07-2017 23:36, Naoto Sato wrote: Looks good to me. Naoto On 7/19/17 10:33 PM, Nishit Jain wrote: Hi, Please review the fix for JDK-8177472 Bug: https://bugs.openjdk.java.net/browse/JDK-8177472 Webrev: http

Re: [10] RFR JDK-8177472: Remove hard-coded IANA Subtag Registry map in LocaleEquivalentMap.java

2017-07-25 Thread Nishit Jain
rds, Nishit Jain On 25-07-2017 21:28, Roger Riggs wrote: Hi Nishit, Can the hardcoded copyright be made more automatic? I see the make/src/classes/build/tools/cldrconverter has functions to create/convert copyrights. Can that be leveraged to generate the needed copyright and reduce some potent

Re: [10] RFR JDK-8177472: Remove hard-coded IANA Subtag Registry map in LocaleEquivalentMap.java

2017-07-25 Thread Nishit Jain
Thanks Roger, Made the suggested changes related to hardcoded copyright year. Please check the updated webrev http://cr.openjdk.java.net/~nishjain/8177472/webrev.06/ Regards, Nishit Jain On 25-07-2017 22:55, Roger Riggs wrote: Hi, I was focused mostly on *not *hardcoding the copyright text