Hello, newbie here
I picked JDK-8138732 to work on because it has a "starter" label and I believe
I understand what to do.
- I tried to update the copyright year to 2020 in every file.
- I decided to change `@since` from 9 to 16 since it is a new annotation name
in a new package.
- I tried to k
ss.
> - One jpackage/jlink tier2 test fails but I don't believe it is related.
> - Some tier3 Swing tests fail but I don't think they are related.
Philippe Marschall has refreshed the contents of this pull request, and
previous commits have been removed. The
incremental views will
On Mon, Sep 7, 2020 at 7:54 PM Alan Bateman wrote:
>
> On Mon, 7 Sep 2020 09:44:09 GMT, Philippe Marschall
> wrote:
>
> > Hello, newbie here
> >
> > I picked JDK-8138732 to work on because it has a "starter" label and I
> > believe I understa
ss.
> - One jpackage/jlink tier2 test fails but I don't believe it is related.
> - Some tier3 Swing tests fail but I don't think they are related.
Philippe Marschall has updated the pull request with a new target base due to a
merge or a rebase. The pull request now
con
ss.
> - One jpackage/jlink tier2 test fails but I don't believe it is related.
> - Some tier3 Swing tests fail but I don't think they are related.
Philippe Marschall has updated the pull request with a new target base due to a
merge or a rebase. The pull request now
con
ss.
> - One jpackage/jlink tier2 test fails but I don't believe it is related.
> - Some tier3 Swing tests fail but I don't think they are related.
Philippe Marschall has updated the pull request with a new target base due to a
merge or a rebase. The pull request now
con
ss.
> - One jpackage/jlink tier2 test fails but I don't believe it is related.
> - Some tier3 Swing tests fail but I don't think they are related.
Philippe Marschall has updated the pull request with a new target base due to a
merge or a rebase. The pull request now
contains t
On Wed, 23 Sep 2020 22:47:47 GMT, Vladimir Kozlov wrote:
>> Marked as reviewed by egahlin (Reviewer).
>
> @marschall I will sponsor it after you integrate the latest update.
@vnkozlov done, I hope I now made it correctly with a merge commit for the
latest merge conflict
-
PR: htt
On Mon, 7 Sep 2020 09:44:09 GMT, Philippe Marschall
wrote:
> Hello, newbie here
>
> I picked JDK-8138732 to work on because it has a "starter" label and I
> believe I understand what to do.
>
> - I tried to update the copyright year to 2020 in every file.
>
On 22.09.20 10:45, Erik Gahlin wrote:
On Sat, 12 Sep 2020 00:19:00 GMT, Vladimir Kozlov wrote:
Philippe Marschall has refreshed the contents of this pull request, and
previous commits have been removed. The
incremental views will show differences compared to the previous content of the
On 23.09.20 07:13, David Holmes wrote:
On Tue, 22 Sep 2020 08:43:04 GMT, Erik Gahlin wrote:
Marked as reviewed by kvn (Reviewer).
Have you run the JFR tests in test/jdk/jdk/jfr?
@marschall Please do not force-push anything as it breaks the commit history in
the PR and renders previous
11 matches
Mail list logo
