JDK-8281003 - MethodHandles::lookup throws NPE if caller is null
-
Commit messages:
- Merge branch 'master' into JDK-8281003
- Merge branch 'master' into JDK-8281003
- removed commented out code
- Moved null caller MethodHandles.lookup() test to a more reasonable location
- JDK-8
JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is null
-
Commit messages:
- Merge branch 'master' into JDK-8281000
- JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
null
Changes: https://git.openjdk.java.net/jdk/pull/7448/files
On Fri, 11 Feb 2022 20:36:26 GMT, Tim Prinzing wrote:
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
Yes, I like the IllegalCallerException.
-
PR: https://git.openjdk.java.net/jdk/pull/7448
> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
Changes from feedback.
- Improved javadoc.
- Single copyright date in new files.
- Informative string
> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
missing dot
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7447/files
- new: ht
> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
remove excess description
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7447/files
-
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
Changes from feedback.
- Copyright dates fixed
- IllegalCallerException thrown for no
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
More changes from feedback.
The javadoc is improved to reflect InvalidCallerException is
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
fix copyright date
-
Changes:
- all: https://git.openjdk.java.net/jdk/pul
> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
fix copyright date
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7447/files
- new: ht
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
Tim Prinzing has updated the pull request incrementally with three additional
commits since the last revision:
- reformat test summary
- reformat test summary
- improve test name and remove experimenta
On Fri, 11 Feb 2022 20:32:46 GMT, Tim Prinzing wrote:
> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null
This pull request has now been integrated.
Changeset: 67763df4
Author: Tim Prinzing
Committer: Mandy Chung
URL:
https://git.openjdk.java.net/jdk/com
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
fix test breakage from rename
-
Changes:
- all: https://git.openjdk.java.n
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
Tim Prinzing has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 10 commits:
- Merge master
- fix test breakage from rename
- reformat test s
On Fri, 11 Feb 2022 20:36:26 GMT, Tim Prinzing wrote:
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
This pull request has now been integrated.
Changeset: a6f8a386
Author: Tim Prinzing
Committer: Mandy Chung
URL:
https://git.openjdk.ja
The caller class returned by Reflection::getCallerClass was used to gain access
to it's module in most cases and class loader in one case. I added a method to
translate the caller class to caller module so that the decision of what module
represents the caller with no stack frame is made in a si
location added to the classpath, fetches a string out of the bundle and
> verifies it, and calls clearCache.
>
> The javadoc was updated for the caller sensitive methods changed.
Tim Prinzing has updated the pull request incrementally with one additional
commit since the
location added to the classpath, fetches a string out of the bundle and
> verifies it, and calls clearCache.
>
> The javadoc was updated for the caller sensitive methods changed.
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision
On Wed, 2 Mar 2022 22:21:03 GMT, Mandy Chung wrote:
>> Tim Prinzing has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> suggested changes
>
> test/jdk/java/util/ResourceBundle/exeNullCallerResourceBundle
location added to the classpath, fetches a string out of the bundle and
> verifies it, and calls clearCache.
>
> The javadoc was updated for the caller sensitive methods changed.
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revisi
location added to the classpath, fetches a string out of the bundle and
> verifies it, and calls clearCache.
>
> The javadoc was updated for the caller sensitive methods changed.
Tim Prinzing has updated the pull request with a new target base due to a merge
or a rebase. The increm
On Wed, 2 Mar 2022 18:56:40 GMT, Tim Prinzing wrote:
> The caller class returned by Reflection::getCallerClass was used to gain
> access to it's module in most cases and class loader in one case. I added a
> method to translate the caller class to caller module so that the decis
Created a test called NullCallerGetResource to test Module::getResourceAsStream
and Class::getResourceAsStream from the native level.
At the java level the test builds a test module called 'n' which opens the
package 'open' to everyone. There is also a package 'closed' which is neither
opened o
ream("test.txt") == null);
> assert(n.getResourceAsStream("closed/test.txt") == null);
>
> The test initially threw an NPE when trying to fetch the open resource. The
> Module class was fixed by removing the fragment with the (caller == null)
> test in getResourc
On Thu, 7 Apr 2022 05:52:24 GMT, Alan Bateman wrote:
> Tim - this creates a conflict between the spec and implementation, the
> changes to the 2-arg isOpen method need to be dropped so that it continues to
> throw NPE if module is null.
okay
-
PR: https://git.openjdk.java.net/jdk
ream("test.txt") == null);
> assert(n.getResourceAsStream("closed/test.txt") == null);
>
> The test initially threw an NPE when trying to fetch the open resource. The
> Module class was fixed by removing the fragment with the (caller == null)
> test in getResourc
ream("test.txt") == null);
> assert(n.getResourceAsStream("closed/test.txt") == null);
>
> The test initially threw an NPE when trying to fetch the open resource. The
> Module class was fixed by removing the fragment with the (caller == null)
> test in getResourc
ream("test.txt") == null);
> assert(n.getResourceAsStream("closed/test.txt") == null);
>
> The test initially threw an NPE when trying to fetch the open resource. The
> Module class was fixed by removing the fragment with the (caller == null)
> test in getResourc
On Thu, 7 Apr 2022 00:38:07 GMT, Tim Prinzing wrote:
> Created a test called NullCallerGetResource to test
> Module::getResourceAsStream and Class::getResourceAsStream from the native
> level.
>
> At the java level the test builds a test module called 'n' which opens
Created a test at test/jdk/jdk/nullCaller called NullCallerTest that creates a
test module with some resources in it for the actual tests that occur at the
native level. The native part was switched to c++ instead of c to make it
easier to create helper objects that reduce the redundant code per
he redundant code performing
> error checking. The two helper classes InstanceCall and StaticCall were
> placed in an include file called CallHelper.hpp. The main part of the tests
> are in exeNullCallerTest.cpp, and there is a separate function for each of
> the bug reports.
Tim
he redundant code performing
> error checking. The two helper classes InstanceCall and StaticCall were
> placed in an include file called CallHelper.hpp. The main part of the tests
> are in exeNullCallerTest.cpp, and there is a separate function for each of
> the bug reports.
Tim
he redundant code performing
> error checking. The two helper classes InstanceCall and StaticCall were
> placed in an include file called CallHelper.hpp. The main part of the tests
> are in exeNullCallerTest.cpp, and there is a separate function for each of
> the bug reports.
Tim
he redundant code performing
> error checking. The two helper classes InstanceCall and StaticCall were
> placed in an include file called CallHelper.hpp. The main part of the tests
> are in exeNullCallerTest.cpp, and there is a separate function for each of
> the bug reports.
Tim
On Wed, 1 Jun 2022 02:45:24 GMT, Tim Prinzing wrote:
>> Created a test at test/jdk/jdk/nullCaller called NullCallerTest that creates
>> a test module with some resources in it for the actual tests that occur at
>> the native level. The native part was switched to c++ in
he redundant code performing
> error checking. The two helper classes InstanceCall and StaticCall were
> placed in an include file called CallHelper.hpp. The main part of the tests
> are in exeNullCallerTest.cpp, and there is a separate function for each of
> the bug reports.
Tim
he redundant code performing
> error checking. The two helper classes InstanceCall and StaticCall were
> placed in an include file called CallHelper.hpp. The main part of the tests
> are in exeNullCallerTest.cpp, and there is a separate function for each of
> the bug reports.
Tim
he redundant code performing
> error checking. The two helper classes InstanceCall and StaticCall were
> placed in an include file called CallHelper.hpp. The main part of the tests
> are in exeNullCallerTest.cpp, and there is a separate function for each of
> the bug reports.
Tim
On Sat, 28 May 2022 11:50:19 GMT, Tim Prinzing wrote:
> Created a test at test/jdk/jdk/nullCaller called NullCallerTest that creates
> a test module with some resources in it for the actual tests that occur at
> the native level. The native part was switched to c++ instead of c t
Fixed JtregNativeJdk.gmk to include c++ libs for NullCallerTest
-
Commit messages:
- 8287745 Fix JtregNativeJdk.gmk to include c++ libs for NullCallerTest
Changes: https://git.openjdk.java.net/jdk/pull/9010/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=9010&range=00
On Fri, 3 Jun 2022 18:16:53 GMT, Mandy Chung wrote:
>> Fixed JtregNativeJdk.gmk to include c++ libs for NullCallerTest
>
> make/test/JtregNativeJdk.gmk line 67:
>
>> 65: BUILD_JDK_JTREG_EXECUTABLES_LIBS_exeNullCallerTest := $(LIBCXX) jvm.lib
>> 66: BUILD_JDK_JTREG_EXECUTABLES_LIBS_exerevokea
On Mon, 6 Jun 2022 07:45:16 GMT, David Holmes wrote:
> Hi Tim,
>
> Sorry but I have to ask why this test was created as a C++ program instead of
> keeping it as a C program likes it predecessors? No need for C++ libs or
> special exception handling flags in that case.
The idea was to reduce d
On Fri, 3 Jun 2022 07:56:38 GMT, Tim Prinzing wrote:
> Fixed JtregNativeJdk.gmk to include c++ libs for NullCallerTest
This pull request has now been integrated.
Changeset: 96641c0c
Author: Tim Prinzing
Committer: Mandy Chung
URL:
https://git.openjdk.java.net/jdk/com
43 matches
Mail list logo
