Re: Building hsdis?

Hi Ted! No blog to point you to, but building on non-Windows platforms should be pretty painless these days. > then tried again with the JDK source Yes, that is the one to use. The makefile had a number of issues that I fixed recently but have not (yet) backported to 8u-dev. I was able to

Re: Building hsdis?

hat stuff.) Ted Neward Author, Speaker, Mentor http://www.newardassociates.com t: @tedneward | m: (425) 647-4526 On 12/20/17, 12:13 AM, "David Buck" wrote: Hi Ted! No blog to point you to, but building on non-Windows platforms should be pretty painless these days. >

Re: Building hsdis?

ues/questions. Thanks! Ted Neward Author, Speaker, Mentor http://www.newardassociates.com t: @tedneward | m: (425) 647-4526 On 12/20/17, 12:54 AM, "David Buck" wrote: Hi Ted! > the version of binutils (I was using 2.32) Not sure what that is. Latest binutils is

Re: Building hsdis?

E mentions both Cygwin and Ming, so I'm not sure what setup you're expecting the Windows developer to have on their machine. Ted Neward Author, Speaker, Mentor http://www.newardassociates.com t: @tedneward | m: (425) 647-4526 On 12/20/17, 12:13 AM, "David Buck" wrote: H

[8u] RFR(S) 8187045: [linux] Not all libraries in the VM are linked with -z,noexecstack

Hi! May I please get a review of my backport of this small change: bug report: https://bugs.openjdk.java.net/browse/JDK-8187045 JDK 10 review thread: http://mail.openjdk.java.net/pipermail/build-dev/2017-September/019723.html JDK 10 changeset: http://hg.openjdk.java.net/jdk10/master/rev/8b5ed03

[8] RFR(XXS) 8203845: backport of JDK-8034788 inadvertently rolled back JDK-8187045 changes to toolchain.m4

Hi! Please review this very simple fix. The backport for JDK-8034788 [0] did a lot of refactoring and moved the some code from toolchain.m4 to flags.m4. Unfortunately, it also unintentionally rolled back my backport of JDK-8187045 [1] when it moved this chunk of code. As a result, this is onl

[8] RFR (XS) 8204053 : libsaproc.so not linked with -z,noexecstack

Hi! Please review this very small fix. It only applies to JDK 8. bug report: https://bugs.openjdk.java.net/browse/JDK-8204053 webrev: http://cr.openjdk.java.net/~dbuck/8204053.0/ JPRT hotspot testset run and passed. Efficacy of fix manually confirmed. Cheers, -Buck

Re: JDK 10 Build Issue(s)

Hi Rupplin! For JDK 10 and later, get_source.sh script is no longer required for getting all of the open source code. It is now all in a single repository that can be cloned in a single step. Please see the following JEP for details. http://openjdk.java.net/jeps/296 Cheers, -Buck On 2018/0

Re: Short Question - About javac.c where is it?

Hi Max! The compiler that compiles Java source code into Java bytecode is written entirely in Java itself. The only C code involved is the launcher executable, "javac" which (as explained by Erik) is simply a very small piece of JNI code that starts the JVM and points it to the main class. Ev

Re: JDK 8 Build Issue(s)

Hi Max! Not much to go on here [0]. For what it's worth, I was able to clone 8u-dev and build it on Mint 18.3 Cinnamon (w/ JDK 7u80 as the boot JDK) without any issues. The Mint VM image I used was new and the only thing I did before building the JDK was run an apt-get update/upgrade cycle an

Re: JDK Memory Allocation

Hi Max! Your question does not seem to be related to building OpenJDK, so I have BCCed build-dev from the thread and added gc-dev. That said, I am not sure any of the development lists are really an ideal place to ask general "code walk through" questions. If really necessary, memAllocator.c

[8] RFR (S) 8033251: Use DWARF debug symbols for Linux 32-bit as default

Hi! May I please get a review of this simple backport to replace stabs with DWARF for 32-bit Linux builds. This is needed as newer toolchains no longer support stabs. bug report: https://bugs.openjdk.java.net/browse/JDK-8033251 JDK 9 changeset: http://hg.openjdk.java.net/jdk9/jdk9/hotspot/re

Re: [8] RFR (S) 8033251: Use DWARF debug symbols for Linux 32-bit as default

Hi, Tim, thank you for the review! > Looks good. Your changes are in line with what JDK 9 did, only a bit > more specific to the ARCH that is building. > > In JDK 9 I see a check for $(FASTDEBUG_CFLAGS/$(BUILDARCH) but setting: > FASTDEBUG_CFLAGS += -g > > In JDK 8 you check $(FASTDEBUG_CFL

Re: RFR(XS): 8146979: Backport of 8046471 breaks ppc64 build in jdk8u because 8072383 was badly backported before

Approved with the condition that peer code review is approved before pushing. If the review is done on a different OpenJDK alias, please send a link for that review thread to this thread before pushing. Cheers, -Buck On 2016/01/13 20:40, Volker Simonis wrote: Hi, I please need an urgent revi

RFR(XXS): 8170954: non-ASCII characters in lcms and harfbuzz break Windows builds on some locales

Hi! Please review this trivial makefile change to disable a problematic warning. bug report: https://bugs.openjdk.java.net/browse/JDK-8170954 webrev: http://cr.openjdk.java.net/~dbuck/jdk8170954_ver00/ Cheers, -Buck

Re: RFR(XXS): 8170954: non-ASCII characters in lcms and harfbuzz break Windows builds on some locales

ot;, Unless something changed to affect that. -phil. On 12/8/16, 6:26 PM, David Buck wrote: Hi! Please review this trivial makefile change to disable a problematic warning. bug report: https://bugs.openjdk.java.net/browse/JDK-8170954 webrev: http://cr.openjdk.java.net/~dbuck/jdk8170954_ver00/ Cheers, -Buck

Re: RFR(XS): 8185567: fix hsdis cpu to architecture mapping on various Linux platforms

Hi! It was suggested that I also loop in build-dev to the review of this proposed change. Cheers, -Buck On 2017/07/31 22:06, David Buck wrote: Hi! Would you please review this small set of very simple build fixes to hsdis? bug report: https://bugs.openjdk.java.net/browse/JDK-8185567