Re: Boot JDK used with jdk7 builds

Phil Race wrote: Well .. we do not distribute binaries of 6-open so that's a bit of a stumbling block. Plus 6-open is relatively new in the great scheme of things and is more of a 6/7 hybrid. The OpenJDK 6 project has publicly existed for around three and a half years and IcedTea6 [1] and Ope

Code review request for 7052122: Update JDK_MINOR_VERSION for JDK 8

Hello. Please review this change to bump the JDK 8 version number from 1.7 to 1.8: 7052122: Update JDK_MINOR_VERSION for JDK 8 http://cr.openjdk.java.net/~darcy/7052122.0/ Patch below followed by post-GPL text of new langtools test. Thanks, -Joe --- old/make/common/shared/Defs.gmk2

Re: Different javac options for explicitly and automatically compiled files

Hi Sasha. This isn't the question you asked, but you can use javac -implicit:none to disable the compilation of implicitly referenced types. -Joe On 8/1/2011 11:07 AM, Alexandre Boulgakov wrote: Hello Kelly, Do you know the answer to this one? Thanks, Sasha On 7/29/2011 11:37 AM, Alex

Re: please review 7122061: enable -Werror in various jdk build steps

On 12/22/2011 3:52 AM, Alan Bateman wrote: On 22/12/2011 01:51, Stuart Marks wrote: I dug up a bit of background on this. Apparently Sasha ran across this problem back in July and asked about this on net-dev [1]. Discussion continued on build-dev [2]. Kurchi later picked up this work and aft

Re: 7140918: Remove dependency on apt and com.sun.mirror API

On 01/30/2012 07:08 AM, Alan Bateman wrote: The following webrev is a patch from Miran Kos and Martin Grebac (cc'ed) to remove the JAX-WS dependency on apt and the com.sun.mirror API: http://cr.openjdk.java.net/~alanb/7140918/webrev/ This is needed before Joe Darcy can wield his ma

Re: 7140918: Remove dependency on apt and com.sun.mirror API

eeded before Joe Darcy can wield his machete. Please cc'ed Miran and Martin on my review comments. One question: how does this change: jaxws_src.bundle.name=jdk8-jaxws-2_2-SNAPSHOT-2012_01_11.zip impact day to day builds? Do we need to have some internal locations updated with this ne

Re: jsr instructions in OpenJDK 6 classes

Hi Andrew, Whether or not the jsr instruction is used is -target specific; version 50.0 class files from -target 6 and later do not support jsr/ret since stackmaps are used. I haven't delved into the OpenJDK 6 build before writing this email, but I suspect some of the classes in rt.jar are c

Re: jsr instructions in OpenJDK 6 classes

On 02/02/2012 08:59 AM, Andrew Haley wrote: On 02/02/2012 04:52 PM, Joe Darcy wrote: stackmaps are used. I haven't delved into the OpenJDK 6 build before writing this email, but I suspect some of the classes in rt.jar are compiled with -target 5, but javac in OpenJDK 6 defaults to -target

Re: Need reviewer on addition of whitespace normalizer script

Looks fine Kelly; great to have this sort of script included with the JDK itself. -Joe On 3/1/2012 1:32 PM, Kelly O'Hair wrote: Need reviewer. Adding the whitespace normalizer script as a convenience to the jdk developers. 6625113: Add the normalize and rmkw perl script to the openjdk reposi

Re: Fwd: Need reviewer, 7150322: Stop using drop source bundles in jaxws

Looks fine, -Joe On 3/6/2012 9:24 AM, Kelly O'Hair wrote: Still need a reviewer or 2 on this. -kto Begin forwarded message: *From: *"Kelly O'Hair" > *Subject: **Need reviewer, 7150322: Stop using drop source bundles in jaxws * *Date: *March 2, 2012 15:49:28

Re: location of -source / -target in new build infrastructure

Actually the long-standing recommended practice is to explicitly set source, target, and encoding when compiling: https://blogs.oracle.com/darcy/entry/build_advice_set_source_target This means you get the language semantics you're asking for :-) This is appropriate when building the JDK t

Re: 2nd try: please, review the script for JDK license headers verification

Hello, I've suggested to Misha in the past a design where a basic and simple lic_check.sh script would live in the root repository and then each child repo (jdk, langtools, hotspot, etc.) would have a repo-specific license checking script that would encode all the expected values and per-repo

Re: Enhance jcheck for Copyright location on 0th line ?

Kumar, There is now a copyright-checking script in the repos which could/should be run before a push or during an integration. I think this is preferable to having jcheck do more semantic analysis of sources given all the special cases that can come about. -Joe On 10/18/2012 12:06 PM, Kuma

Re: RFR: 8013552: Add build support for different man pages for OpenJDK and OracleJDK

On 05/02/2013 09:38 AM, Jonathan Gibbons wrote: On 05/02/2013 08:58 AM, Andrew Hughes wrote: The man pages in the >jdk source tree are generated files that the docs team periodically updates. > Will the source files be added to the OpenJDK trees at some point? Purely from a curiosity poi

JDK 8 code review request of langtools build changes for JDK-8014365 Restore Objects.requireNonNull(T, Supplier)

Hello, Please review the patch below for JDK-8014365 "Restore Objects.requireNonNull(T, Supplier)" which addresses the issue tripped over during JDK-8012344 "Backout 8011800 until langtools genstubs updated." A full build with the below patch to langtools and the update JDK library succeeds

Re: Disable overrides during jdk build

Failure to have proper equals / hashCode behaviors can create hard to discover bugs if such objects are ever put in collections. By default, I would categorize these as real problems to be fixed and for a @SuppressWarning annotation to be wrong approach to resolve the warning. Since its init

Re: RFR: 8251549: Update docs on building for Git [v2]

> 8251549: Update docs on building for Git Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Update doc/building.md Co-authored-by: Magnus Ihse Bursie - Changes: - all: https://git.openjdk.java.net/jdk/pull/21/fi

Integrated: 8251549: Update docs on building for Git

On Sat, 5 Sep 2020 20:13:18 GMT, Joe Darcy wrote: > 8251549: Update docs on building for Git This pull request has now been integrated. Changeset: 042734cc Author: Joe Darcy URL: https://git.openjdk.java.net/jdk/commit/042734cc Stats: 68 lines in 1 file changed: 12 ins; 37

RFR: 8253753 Enable default constructor warning in client modules

With the default constructors warnings in java.desktop and jdk.accessibility now fixed, the warning should be enabled in the build for those modules. - Commit messages: - Merge branch 'JDK-8253753' of https://github.com/jddarcy/jdk into JDK-8253753 - Update build to enable default

Integrated: 8253753 Enable default constructor warning in client modules

On Tue, 24 Nov 2020 19:10:04 GMT, Joe Darcy wrote: > With the default constructors warnings in java.desktop and jdk.accessibility > now fixed, the warning should be enabled in the build for those modules. This pull request has now been integrated. Changeset: 65137ff0 Author: Joe Darc

Re: RFR: 8257450: Start of release updates for JDK 17

On Tue, 1 Dec 2020 07:33:25 GMT, David Holmes wrote: >> Start of JDK 17 updates. > > src/jdk.compiler/share/classes/com/sun/tools/javac/code/Source.java line 226: > >> 224: REIFIABLE_TYPES_INSTANCEOF(JDK16, >> Fragments.FeatureReifiableTypesInstanceof, DiagKind.PLURAL), >> 225:

RFR: 8257450: Start of release updates for JDK 17

Start of JDK 17 updates. - Commit messages: - Update tests. - Merge branch 'master' into JDK-8257450 - Merge branch 'JDK-8257450' of https://github.com/jddarcy/jdk into JDK-8257450 - Merge branch 'JDK-8257450' of https://github.com/jddarcy/jdk into JDK-8257450 - JDK-8257450 - JD

Re: RFR: 8257450: Start of release updates for JDK 17

On Tue, 1 Dec 2020 07:38:13 GMT, David Holmes wrote: >> Start of JDK 17 updates. > > Looks good - 99% sym stuff :) > > Doesn't look like the hotspot deprecated flag test will need updating this > time, as no newly deprecated flags marked for obsoletion in 17. Usual start of release update: *

Re: RFR: 8257450: Start of release updates for JDK 17 [v2]

> Start of JDK 17 updates. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision: - Me

Re: RFR: 8257450: Start of release updates for JDK 17 [v2]

On Mon, 7 Dec 2020 16:10:42 GMT, Jan Lahoda wrote: > > > The langtools changes look fine to me. There were additions/changes to jcod > files under `test/hotspot/jtreg/runtime/sealedClasses/` made under > JDK-8246778, so these may need an update. Sorry about that. After a merge, the tests in

Re: RFR: 8257450: Start of release updates for JDK 17 [v2]

On Mon, 7 Dec 2020 20:08:59 GMT, Jonathan Gibbons wrote: >> Joe Darcy has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contains eight

Re: RFR: 8257450: Start of release updates for JDK 17 [v2]

On Mon, 7 Dec 2020 20:20:58 GMT, Jesper Wilhelmsson wrote: >> Joe Darcy has updated the pull request with a new target base due to a merge >> or a rebase. The incremental webrev excludes the unrelated changes brought >> in by the merge/rebase. The pull request contain

Re: RFR: 8257450: Start of release updates for JDK 17 [v3]

> Start of JDK 17 updates. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision: - Merge bra

Re: RFR: 8257450: Start of release updates for JDK 17 [v4]

> Start of JDK 17 updates. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision: - Merge bra

Re: RFR: 8257450: Start of release updates for JDK 17 [v5]

> Start of JDK 17 updates. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision: - Merge bra

Re: RFR: 8257450: Start of release updates for JDK 17 [v6]

> Start of JDK 17 updates. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 14 additional commits since the last revision: - Get in JEP

Re: RFR: 8257450: Start of release updates for JDK 17 [v7]

> Start of JDK 17 updates. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 17 additional commits since the last revision: - Merge bra

Re: RFR: 8257450: Start of release updates for JDK 17 [v8]

> Start of JDK 17 updates. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 18 additional commits since the last revision: - Merge bra

Integrated: 8257450: Start of release updates for JDK 17

On Tue, 1 Dec 2020 06:22:51 GMT, Joe Darcy wrote: > Start of JDK 17 updates. This pull request has now been integrated. Changeset: 6be1f567 Author: Joe Darcy URL: https://git.openjdk.java.net/jdk/commit/6be1f567 Stats: 7607 lines in 77 files changed: 7548 ins; 0 del; 59

RFR: 8257457: Update --release 16 symbol information for JDK 16 build 28

Update symbol information for --release 16 to JDK 16 b28, includes updates for JEP 390. - Commit messages: - 8257457 Changes: https://git.openjdk.java.net/jdk/pull/1754/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=1754&range=00 Issue: https://bugs.openjdk.java.net

RFR: 8258143: Update --release 16 symbol information for JDK 16 build 30 or later

Updating to the symbol files for JDK 16 b30; change generated with the script make/scripts/generate-symbol-data.sh The change to the java.desktop module looks to be for JDK-8258373. - Commit messages: - 8258143: Update --release 16 symbol information for JDK 16 build 30 or later

Integrated: 8258143: Update --release 16 symbol information for JDK 16 build 30 or later

On Wed, 6 Jan 2021 02:19:51 GMT, Joe Darcy wrote: > Updating to the symbol files for JDK 16 b30; change generated with the script > > make/scripts/generate-symbol-data.sh > > The change to the java.desktop module looks to be for JDK-8258373. This pull request has now

RFR: 8259512: Update --release 16 symbol information for JDK 16 build 31

Using the symbol updating script, update the symbol files for API changes in JDK 16 build 31. - Commit messages: - 8259512: Update --release 16 symbol information for JDK 16 build 31 Changes: https://git.openjdk.java.net/jdk/pull/2010/files Webrev: https://webrevs.openjdk.java.net

Integrated: 8259512: Update --release 16 symbol information for JDK 16 build 31

On Fri, 8 Jan 2021 22:36:01 GMT, Joe Darcy wrote: > Using the symbol updating script, update the symbol files for API changes in > JDK 16 build 31. This pull request has now been integrated. Changeset: a6539282 Author: Joe Darcy URL: https://git.openjdk.java.net/jdk/commit/a6

RFR: 8262893: Enable more doclint checks in javadoc build

With recent cleanups, several doclint categories have been cleared across the JDK and should be enabled in the javadoc build to make sure they stay clean. Local docs build completes with this stricter set of checks. - Commit messages: - 8262893: Enable more doclint checks in javado

Integrated: 8262893: Enable more doclint checks in javadoc build

On Tue, 2 Mar 2021 22:41:38 GMT, Joe Darcy wrote: > With recent cleanups, several doclint categories have been cleared across the > JDK and should be enabled in the javadoc build to make sure they stay clean. > > Local docs build completes with this stricter set of checks. This

Re: RFR: 8257459: Bump minimum boot jdk to JDK 16

On Sat, 17 Apr 2021 07:20:21 GMT, Mikael Vidstedt wrote: > With JDK 16 having gone GA about a month ago it's time to bump the minimum > boot JDK version for mainline/JDK 17. > > Testing: tier1-5. Marked as reviewed by darcy (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/

Re: RFR: 8266459: Implement JEP 411: Deprecate the Security Manager for Removal

On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote: > Please review this implementation of [JEP > 411](https://openjdk.java.net/jeps/411). > > The code change is divided into 3 commits. Please review them one by one. > > 1. > https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28

Re: RFR: 8267630: Start of release updates for JDK 18

On Mon, 24 May 2021 22:35:04 GMT, Joe Darcy wrote: > 8267630: Start of release updates for JDK 18 JDK 18 is right around the corner, time for the usual start-of-release changeset for review. Typical structure for these kinds of changes. I'll update the symbol file information of JD

RFR: 8267630: Start of release updates for JDK 18

8267630: Start of release updates for JDK 18 - Commit messages: - Merge branch 'master' into 8267630 - Merge branch 'master' into 8267630 - Merge branch 'master' into 8267630 - Merge branch 'master' into 8267630 - Merge branch 'master' into 8267630 - Merge branch 'master' into 8

Re: RFR: 8267630: Start of release updates for JDK 18 [v2]

> 8267630: Start of release updates for JDK 18 Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revis

Re: RFR: 8267630: Start of release updates for JDK 18 [v3]

> 8267630: Start of release updates for JDK 18 Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revis

Re: RFR: 8267630: Start of release updates for JDK 18 [v4]

> 8267630: Start of release updates for JDK 18 Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 15 additional commits since the last revis

RFR: 8268299: jvms tag produces incorrect URL

The @jls and @jvms taglet share most of their functionality. A JLS URL looks like https://docs.oracle.com/javase/specs/jls/se16/html/**jls**-8.html#jls-8.1 and a JVMS URL looks like https://docs.oracle.com/javase/specs/jvms/se16/html/**jvms**-4.html#jvms-4.3.2 The current taglet inc

Integrated: 8268299: jvms tag produces incorrect URL

On Sun, 6 Jun 2021 22:03:46 GMT, Joe Darcy wrote: > The @jls and @jvms taglet share most of their functionality. A JLS URL > looks like > > https://docs.oracle.com/javase/specs/jls/se16/html/**jls**-8.html#jls-8.1 > > and a JVMS URL looks like > > > htt

Re: RFR: 8267630: Start of release updates for JDK 18 [v5]

> 8267630: Start of release updates for JDK 18 Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 17 additional commits since the last revis

Re: RFR: 8267630: Start of release updates for JDK 18 [v6]

> 8267630: Start of release updates for JDK 18 Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 18 additional commits since the last revis

Re: RFR: 8267630: Start of release updates for JDK 18 [v7]

> 8267630: Start of release updates for JDK 18 Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 19 commits: - Merge branch 'master' into 8267630 - Merge branch 'master' into 8267630 - Merge branc

Re: RFR: 8267630: Start of release updates for JDK 18 [v8]

> 8267630: Start of release updates for JDK 18 Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 21 commits: - Merge branch 'master' into 8267630 - Merge branch 'master' into 8267630 - Merge branc

Re: RFR: 8267630: Start of release updates for JDK 18 [v9]

> 8267630: Start of release updates for JDK 18 Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 22 commits: - Merge branch 'master' into 8267630 - Merge branch 'master' into 8267630 - Merge branc

Re: RFR: 8267630: Start of release updates for JDK 18 [v10]

> 8267630: Start of release updates for JDK 18 Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 24 commits: - Update copyright year. - Merge branch 'master' into 8267630 - Merge branch 'master'

Re: RFR: 8267630: Start of release updates for JDK 18 [v11]

> 8267630: Start of release updates for JDK 18 Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 25 commits: - Merge branch 'master' into 8267630 - Update copyright year. - Merge branch 'master'

Integrated: 8267630: Start of release updates for JDK 18

On Mon, 24 May 2021 22:35:04 GMT, Joe Darcy wrote: > 8267630: Start of release updates for JDK 18 This pull request has now been integrated. Changeset: b018c450 Author: Joe Darcy URL: https://git.openjdk.java.net/jdk/commit/b018c450e5e4737ccd08ed505fd06cee16c42648 Stats: 5

Re: RFR: 8266036: class file for sun.misc.Contended not found

On Wed, 9 Jun 2021 11:05:37 GMT, Jan Lahoda wrote: > The ct.sym may contain classfiles referring to annotations that are not > present in ct.sym (liek JDK's internal annotation `sun.misc.Contended`). If > javac will try to load them (while discovering annotations for the purpose of > detecting

Re: [jdk17] RFR: 8266036: class file for sun.misc.Contended not found

On Fri, 11 Jun 2021 13:09:55 GMT, Jan Lahoda wrote: > [this is an improved version of openjdk/jdk PR: > https://github.com/openjdk/jdk/pull/4428 > ] > > The ct.sym may contain classfiles referring to annotations that are not > present in ct.sym (liek JDK's internal annotation sun.misc.Contended

RFR: 8267634: Update --release 17 symbol information for JDK 17 build 26

Update symbol files in JDK 18 for changes in JDK 17 b26. - Commit messages: - 8267634: Update --release 17 symbol information for JDK 17 build 26 Changes: https://git.openjdk.java.net/jdk/pull/4477/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4477&range=00 Issue: h

Integrated: 8267634: Update --release 17 symbol information for JDK 17 build 26

On Fri, 11 Jun 2021 22:44:03 GMT, Joe Darcy wrote: > Update symbol files in JDK 18 for changes in JDK 17 b26. This pull request has now been integrated. Changeset: a466b49e Author: Joe Darcy URL: https://git.openjdk.java.net/jdk/commit/a466b49e71b0d235294e17faba47ed4fd3fb8f6e St

RFR: 8268637: Update --release 17 symbol information for JDK 17 build 28

JDK 17 b28 had two fixes which updated the symbol information. A CallerSensitive annotation was removed as part of JDK-8268349 and API changes in JDK-826. These should be reflected in the JDK 18 symbol information for 17. - Commit messages: - 8268637: Update --release 17 symbo

Integrated: 8268637: Update --release 17 symbol information for JDK 17 build 28

On Wed, 30 Jun 2021 16:54:57 GMT, Joe Darcy wrote: > JDK 17 b28 had two fixes which updated the symbol information. A > CallerSensitive annotation was removed as part of JDK-8268349 and API changes > in JDK-826. > > These should be reflected in the JDK 18 symbol informatio

RFR: 8269689: Update --release 17 symbol information for JDK 17 build 31

Usual kind of updates for the symbol information in JDK 18 to reflect changes in the JDK 17 API. Bug fixes with API changes since JDK 17 b28 include JDK-8266313, JDK-8268972, and JDK-8266269. - Commit messages: - 8269689: Update --release 17 symbol information for JDK 17 build 31

Re: RFR: 8272067: Initial nroff manpage generation for JDK 18

On Fri, 6 Aug 2021 01:53:51 GMT, David Holmes wrote: > Please review this trivial update to the generated manpages that updates > their version from "JDK 17" to "JDK 18-ea". > > Thanks, > David Marked as reviewed by darcy (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/50

Re: RFR: JDK-8272667: substandard error messages from the docs build

On Wed, 18 Aug 2021 22:06:13 GMT, Jonathan Gibbons wrote: > Please review a small (delete one character) change to improve the error > messages reported when bad HTML is detected when post-processing the output > from pandoc to generate the docs. > > The change is just to pass the filename as

Re: RFR: 8267636: Bump minimum boot jdk to JDK 17

On Wed, 22 Sep 2021 20:03:55 GMT, Mikael Vidstedt wrote: > With the JDK 17 GA out it's time to bump the minimum boot JDK version for > mainline/JDK 18. > > Testing: tier1-5, GHA builds Marked as reviewed by darcy (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/5639

RFR: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields

This is an initial PR for expanded lint warnings done under two bugs: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields 8160675: Issue lint warning for non-serializable non-transient instance fields in serializable type to get feedback on

Re: RFR: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields [v2]

") or other changes in place. > For one module, I temporarily disabled the Xlint:serial check. > > In terms of performance, I have not done benchmarks of the JDK build with and > without these changes, but informally the build seems to take about as long > as before. Joe Darc

Re: RFR: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields [v3]

") or other changes in place. > For one module, I temporarily disabled the Xlint:serial check. > > In terms of performance, I have not done benchmarks of the JDK build with and > without these changes, but informally the build seems to take about as long > as before. Joe Darc

Re: RFR: 8202056: Expand serial warning to check for bad overloads of serial-related methods and ineffectual fields [v4]

") or other changes in place. > For one module, I temporarily disabled the Xlint:serial check. > > In terms of performance, I have not done benchmarks of the JDK build with and > without these changes, but informally the build seems to take about as long > as before. Joe Dar

Re: RFR: 8276400: openjdk image Jars, Zips and Jmods built from the same source are not reproducible

On Thu, 4 Nov 2021 20:56:45 GMT, Andrew Leonard wrote: > This PR enables reproducible Jars, Jmods and openjdk image zip files > (eg.src.zip). > It provides support for SOURCE_DATE_EPOCH for Jar, Jmod and underlying > ZipOutputStream's. > It fixes the following keys issues relating to reproducib

RFR: JDK-8273146: Start of release updates for JDK 19

The time to get JDK 19 underway draws nigh, please review this usual set of start-of-release updates, including CSRs for the javac and javax.lang.model updates: JDK-8277512: Add SourceVersion.RELEASE_19 https://bugs.openjdk.java.net/browse/JDK-8277512 JDK-8277514: Add source 19 and target 19 to

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v2]

K-8277514: Add source 19 and target 19 to javac > https://bugs.openjdk.java.net/browse/JDK-8277514 > > Clean local tier 1 test runs for langtools, jdk, and hotspot. Joe Darcy has updated the pull request incrementally with one additional commit since the last revisi

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v2]

On Mon, 22 Nov 2021 04:17:44 GMT, David Holmes wrote: > Hi Joe, > > I looked at all the non-sym file changes. Only one potential issue spotted. > > Thanks, David *sigh* Yep; cut and paste error -- corrected in next push. Well spotted! Thanks David - PR: https://git.openjdk.java.

Re: RFR: 8275063: Implementation of Foreign Function & Memory API (Second incubator) [v26]

On Mon, 22 Nov 2021 12:09:30 GMT, Maurizio Cimadamore wrote: >> This PR contains the API and implementation changes for JEP-419 [1]. A more >> detailed description of such changes, to avoid repetitions during the review >> process, is included as a separate comment. >> >> [1] - https://openjd

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v3]

K-8277514: Add source 19 and target 19 to javac > https://bugs.openjdk.java.net/browse/JDK-8277514 > > Clean local tier 1 test runs for langtools, jdk, and hotspot. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v4]

K-8277514: Add source 19 and target 19 to javac > https://bugs.openjdk.java.net/browse/JDK-8277514 > > Clean local tier 1 test runs for langtools, jdk, and hotspot. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v5]

K-8277514: Add source 19 and target 19 to javac > https://bugs.openjdk.java.net/browse/JDK-8277514 > > Clean local tier 1 test runs for langtools, jdk, and hotspot. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Update

Re: RFR: 8275771: JDK source code contains redundant boolean operations in jdk.compiler and langtools

On Mon, 29 Nov 2021 19:05:59 GMT, Vicente Romero wrote: > Hi, > > Please review this PR which is basically rewriting some redundant boolean > expressions in the compiler. > > TIA make/langtools/tools/compileproperties/CompileProperties.java line 187: > 185: } > 186:

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v6]

K-8277514: Add source 19 and target 19 to javac > https://bugs.openjdk.java.net/browse/JDK-8277514 > > Clean local tier 1 test runs for langtools, jdk, and hotspot. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now conta

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v7]

K-8277514: Add source 19 and target 19 to javac > https://bugs.openjdk.java.net/browse/JDK-8277514 > > Clean local tier 1 test runs for langtools, jdk, and hotspot. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12

RFR: JDK-8278175: Enable all doclint warnings for build of java.desktop

In JDK 18, JDK-8189591 added the ability to suppress doclint warnings. Therefore, it is now possible to enable the full doclint checks for the java.desktop module if the instances of warnings are suppressed. This patch does this; it would be preferable to address the doc warnings directly, but

RFR: JDK-8278179: Enable all doclint warnings for build of java.naming

An exploratory build indicates that it is not necessary to disable the accessibility doclint check for the java.naming module. - Commit messages: - JDK-8278179: Enable all doclint warnings for build of java.naming Changes: https://git.openjdk.java.net/jdk/pull/6688/files Webrev: h

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v8]

K-8277514: Add source 19 and target 19 to javac > https://bugs.openjdk.java.net/browse/JDK-8277514 > > Clean local tier 1 test runs for langtools, jdk, and hotspot. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:

Integrated: JDK-8278179: Enable all doclint warnings for build of java.naming

On Fri, 3 Dec 2021 03:28:46 GMT, Joe Darcy wrote: > An exploratory build indicates that it is not necessary to disable the > accessibility doclint check for the java.naming module. This pull request has now been integrated. Changeset: 780b8b10 Author: Joe Darcy URL:

Integrated: JDK-8278175: Enable all doclint warnings for build of java.desktop

On Fri, 3 Dec 2021 01:18:20 GMT, Joe Darcy wrote: > In JDK 18, JDK-8189591 added the ability to suppress doclint warnings. > Therefore, it is now possible to enable the full doclint checks for the > java.desktop module if the instances of warnings are suppressed. This patch > d

Re: RFR: JDK-8278175: Enable all doclint warnings for build of java.desktop

On Fri, 3 Dec 2021 01:18:20 GMT, Joe Darcy wrote: > In JDK 18, JDK-8189591 added the ability to suppress doclint warnings. > Therefore, it is now possible to enable the full doclint checks for the > java.desktop module if the instances of warnings are suppressed. This patch > d

RFR: JDK-8278273: Remove unnecessary exclusion of doclint accessibility checks

Exploratory builds indicate it is not currently necessary to exclude the doclint accessibility checks; this patch enables them. (Enabling the reference checks is left for future work.) - Commit messages: - JDK-8278273: Remove unnecessary exclusion of doclint accessibility checks C

Integrated: JDK-8278273: Remove unnecessary exclusion of doclint accessibility checks

On Sun, 5 Dec 2021 23:45:32 GMT, Joe Darcy wrote: > Exploratory builds indicate it is not currently necessary to exclude the > doclint accessibility checks; this patch enables them. > > (Enabling the reference checks is left for future work.) This pull request has now bee

Re: RFR: 8278251: Enable "missing-explicit-ctor" check in the jdk.unsupported.desktop module

On Fri, 3 Dec 2021 20:55:23 GMT, Sergey Bylokhov wrote: > The "missing-explicit-ctor" check was disabled by the > [JDK-8071961](https://bugs.openjdk.java.net/browse/JDK-8071961) and later was > fixed by the [JDK-8250853](https://bugs.openjdk.java.net/browse/JDK-8250853). > So we can re-enable

Re: RFR: JDK-8273146: Start of release updates for JDK 19 [v9]

K-8277514: Add source 19 and target 19 to javac > https://bugs.openjdk.java.net/browse/JDK-8277514 > > Clean local tier 1 test runs for langtools, jdk, and hotspot. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 17

Integrated: JDK-8273146: Start of release updates for JDK 19

On Mon, 22 Nov 2021 03:15:51 GMT, Joe Darcy wrote: > The time to get JDK 19 underway draws nigh, please review this usual set of > start-of-release updates, including CSRs for the javac and javax.lang.model > updates: > > JDK-8277512: Add SourceVersion.REL

RFR: JDK-8277515: Update --release 18 symbol information for JDK 18 build 29

Usual update to the JDK 19 symbol files for changes in JDK 18; this time JDK-8276660 in JDK 18 build 28. - Commit messages: - JDK-8277515: Update --release 18 symbol information for JDK 18 build 29 Changes: https://git.openjdk.java.net/jdk/pull/6948/files Webrev: https://webrevs.o

Integrated: JDK-8277515: Update --release 18 symbol information for JDK 18 build 29

On Mon, 3 Jan 2022 18:26:24 GMT, Joe Darcy wrote: > Usual update to the JDK 19 symbol files for changes in JDK 18; this time > JDK-8276660 in JDK 18 build 28. This pull request has now been integrated. Changeset: 9a0e8900 Author: Joe Darcy URL: https://git.openjdk.java.n

RFR: JDK-8279397: Update --release 18 symbol information for JDK 18 build 32

Update of JDK 18 symbol information for build 32. @lahodaj , can you take a look at the diff? Given the code changes for JDK-8270416: "Enhance construction of Identity maps" (https://github.com/openjdk/jdk/commit/5832a3440489d0967dc3b0542c1ace51eed292d6), I didn't see why the symbol update was

Integrated: JDK-8279397: Update --release 18 symbol information for JDK 18 build 32

On Thu, 20 Jan 2022 19:03:36 GMT, Joe Darcy wrote: > Update of JDK 18 symbol information for build 32. > > @lahodaj , can you take a look at the diff? Given the code changes for > JDK-8270416: "Enhance construction of Identity maps" > (https://gith

Re: RFR: JDK-8279397: Update --release 18 symbol information for JDK 18 build 32

On Fri, 21 Jan 2022 18:39:02 GMT, Jan Lahoda wrote: > I believe this is an artifact of limited optimization of the InnerClasses > attribute: if the InnerClasses attribute refers to a class that is not part > of `ct.sym`, then it is stripped, but if the class is part of ct.sym, the > code does

Re: RFR: 8282657: Code cleanup: removing double semicolons at the end of lines

On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote: > Hi > > I have reviewed the code for removing double semicolons at the end of lines > > all the best > matteo Marked as reviewed by darcy (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/7268

  1   2   3   >