Re: Build Group Membership vote

Vote: yes On Wed, May 11, 2011 at 10:20 AM, Kelly O'Hair wrote: > > Should the following person be added as a member of the OpenJDK Build Group? > David Katleman http://db.openjdk.java.net/people/katleman > David is a member of the Release Engineering team in Santa Clara. > (And should have been

Re: Build Group Membership vote

Vote: yes On Wed, May 11, 2011 at 10:55 AM, Kelly O'Hair wrote: > [Sorry about all these emails, but the build-dev alias is the group alias > too.] > Should the following person be added as a member of the OpenJDK Build Group? > Phil Race http://db.openjdk.java.net/people/prr > David is a member

Re: Should the Build Group sponsor the Build Infrastructure Project?

Vote: Yes On Wed, May 11, 2011 at 8:23 AM, Kelly O'Hair wrote: > > Should the Build Group sponsor the Build Infrastructure Project [1]? > > Please cast your vote by replying to this message with either > Vote: yes > or > Vote: no > as the first line of the message body.

Re: Should the Build Group sponsor the JDK 8 Project?

Vote: yes - Tim

Re: Should the Build Group sponsor the "JDK 7 Update" project?

Vote: yes Tim

Re: Confused about Windows build

://blogs.oracle.com/TimBell/entry/building_openjdk7_on_32_bit http://blogs.oracle.com/TimBell/entry/building_openjdk7_on_32_bit2 http://blogs.oracle.com/TimBell/entry/building_openjdk7_on_32_bit3 Tim Bell On Sun, Oct 16, 2011 at 9:07 PM, Phil Race wrote: > I concur. Out of the box, 32 bit builds with even

Re: Need reviewer: corba changes for build infra

Hi Kelly > Need a reviewer for these build-infra changes to the strip properties utility > in the corba repository. > > 7153266: Adjustments to corba strip property utility (neutral to builds) > http://cr.openjdk.java.net/~ohair/openjdk8/infra-corba/webrev/ Looks good overall. I find this is a

Re: Need reviewer: corba changes for build infra

I wrote: > I find this is a bit alarming - won't it overwrite the input file with > the output file? > >  120             String infile = inIter.next(); >  121             String outfile = outIter.next(); Sorry, I meant to pick on these lines, and also mention that args.length should be an even n

Re: Need reviewer: corba changes for build infra

> This is all as expected, although perhaps questionable style. > > Given Fredrik's comments too, are you ok with the changes? Thanks for the back-story on this corner of the build. I am fine with the changes. Tim

Re: Review Request: Build-infra update

Looks good to me. Line 314 of CompileJavaClasses.gmk is an 'order-only' prerequisite - I had to look it up as I have only seen it used one other time. http://www.gnu.org/software/make/manual/make.html#Prerequisite-Types Tim On 06/04/12 07:15, Erik Joelsson wrote: I have created a (hopefu

RFR (7152336): Enable OpenJDK builds on Windows with MinGW/MSYS

The 5 error tests are all ignored until bug xxx (for some value of x) is resolved. Thanks in advance for your review and feedback - Tim Bell [1] http://openjdk.java.net/projects/code-tools/

Re: Mercurial error: No module named HTMLParser

On 06/16/12 09:36, Pete Brunet wrote: When using hg commands I always get: *** failed to import extension defpath from C:\Users\Pete\hg-extensions\defpath\defpath.py: No module named HTMLParser I am using cygwin 1.7.0 (instead of the latest due to needing to run on Windows 7). Did this hg and

Re: README-builds.html

On 06/18/12 10:25, Andrew Haley wrote: The README-builds.html instructions say... Slow Builds: ... Creating the javadocs can be very slow, if you are running javadoc, consider skipping that step. But there is no information I can find about how to skip that step: I think it's N

Round two - RFR (7152336): Enable OpenJDK builds on Windows with MinGW/MSYS

. jtreg test runs of the '-automatic -noshell' tests under test/java/lang test/java/math test/java/util ran as expected (2 failures, both known bugs). Thanks in advance for your review and feedback - I'd like to get these changes in soon. Tim Bell On 06/13/12 22:31, Tim Bel

Re: Round two - RFR (7152336): Enable OpenJDK builds on Windows with MinGW/MSYS

On 06/27/12 15:26, John Coomes wrote: I only looked at the hotspot changes, which are fine. One minor request. In hotspot/make/windows/makefiles/defs.make: 215 else 216 ifeq ($(USING_MINGW), true) 217 ABS_OUTPUTDIR := $(shell $(CD) $(OUTPUTDIR);$(PWD)) 218 ABS_BOOTDIR :

Re: Round two - RFR (7152336): Enable OpenJDK builds on Windows with MinGW/MSYS

et, I will run jcheck to be sure. But overall, I see no reason to block this work from being integrated. As long as the current RE MKS builds are ok. JPRT build jobs are going through OK. Thanks for the review- Tim -kto On Jun 27, 2012, at 9:45 AM, Tim Bell wrote: I went over the open

RFR: 7181175 Enable hotspot builds on Windows with MinGW/MSYS

. glad to do it if it is OK). Thanks in advance- Tim Bell [1] http://cr.openjdk.java.net/~tbell/7152336/webrev.02/

Re: RFR: 7181175 Enable hotspot builds on Windows with MinGW/MSYS

Additional comments inline: On 07/03/12 00:40, Volker Simonis wrote: Hi, please see my comments inline.. On Tue, Jul 3, 2012 at 7:07 AM, David Holmes wrote: Hi Tim, On 3/07/2012 1:52 PM, Tim Bell wrote: All- This is the hotspot-only portion of the changes to allow building on Windows

Re: Need reviewer

On 07/16/12 10:52, Kelly O'Hair wrote: Minor change to the get_source/hgforest scripts to allow for trailing // Plus adding the whitespace normalizer perl script to the openjdk7updates forest. 7184406: Adjust get_source/hgforest script to allow for trailing // characters http://cr.openjdk.java.n

Re: RFR: 7181175 Enable hotspot builds on Windows with MinGW/MSYS

On 07/17/12 17:16, David Holmes wrote: I'm not sure if you are agreeing with me :) so to be clear. We have: Thanks for the clarification. I think we all agree here, but best to be sure. COMPILE_JAVAC="$(BootStrapDir)\bin\javac" $(BOOTSTRAP_JAVAC_FLAGS) COMPILE_RMIC="$(BootStrapDir)\bin\rm

Re: RFR: 7181175 Enable hotspot builds on Windows with MinGW/MSYS

On 07/18/12 10:48, Kelly O'Hair wrote: Notes below... just chatted with Tim in his office... (snip...) I would have expected a whole bunch of stuff here as the VM is built... but it goes to SA next? Is that right? I checked the RE build log from yesterday, and sa really is the first thing

Re: RFR: 7181175 Enable hotspot builds on Windows with MinGW/MSYS

I wrote: Testing a hunch: I renamed my source tree to shorten the length of the file paths. I have restarted my build in verbose mode, so I should know more soon. The problem was self-inflicted. It was not the path length this time. It also was not related to the"$(COMPILE_RMIC)" in sa.ma

Re: RFR: 7181175 Enable hotspot builds on Windows with MinGW/MSYS

I wrote: My test build is running now. I'll update the webrev and send out a new URL. The test builds were successful. I also ran full hotspot builds on JPRT using '-release jdk8' and '-release jdk7u6', so there is no regression in the old builds. I believe I have addressed the review feed

Re: RFR: 7181175 Enable hotspot builds on Windows with MinGW/MSYS

work. Thanks in advance- Tim On 07/19/12 15:35, Tim Bell wrote: I wrote: My test build is running now. I'll update the webrev and send out a new URL. The test builds were successful. I also ran full hotspot builds on JPRT using '-release jdk8' and '-release jdk7u6

Re: RFR: 7181175 Enable hotspot builds on Windows with MinGW/MSYS

les/shared.make Let me know if there is anything I can do to help you out. Tim On 08/02/12 10:46, Daniel D. Daugherty wrote: Tim, I'm the RT_Baseline gatekeeper this month so I'll take a look at the changes and shepherd them into RT_Baseline. Dan On 8/2/12 11:30 AM, Tim Bell wro

Re: RFR: 7181175 Enable hotspot builds on Windows with MinGW/MSYS

On 08/02/12 14:20, Daniel D. Daugherty wrote: http://cr.openjdk.java.net/~tbell/7181175/webrev.01/ Thanks for the review, Dan. make/windows/makefiles/defs.make No comments. make/windows/makefiles/rules.make lines 28-33: Might want to comment on why these paths still use back

Re: RFR: 7181175 Enable hotspot builds on Windows with MinGW/MSYS

:45, Daniel D. Daugherty wrote: Thumbs up on this version. Do you have a commit message ready for this patch? Dan On 8/3/12 1:26 PM, Tim Bell wrote: On 08/02/12 14:20, Daniel D. Daugherty wrote: http://cr.openjdk.java.net/~tbell/7181175/webrev.01/ Thanks for the review, Dan. make/windows

Re: RFR: 7181175 Enable hotspot builds on Windows with MinGW/MSYS

On 08/03/12 15:09, Daniel D. Daugherty wrote: Gotta put 'tbell' in there some where... Can I add you as a reviewer? Oh - that's right. Sure, add me as a reviewer. Tim Dan On 8/3/12 3:58 PM, Tim Bell wrote: Thanks, Dan How about this for a commit message: 7181175: E

Re: RFR: 7181175 Enable hotspot builds on Windows with MinGW/MSYS

fix that in a minute. Dan -kto On Aug 3, 2012, at 4:21 PM, Daniel D. Daugherty wrote: Added you to the reviewer list. You're also the "user" for the changeset. The job is in the JPRT-hotspotwest queue heading to RT_Baseline. Dan On 8/3/12 5:08 PM, Tim Bell wrote: On 08/03/

RFR: 7190512 Fix for 7181175 broke hotspot/make/windows/create.bat builds.

Hello all- After the fixes for 7181175 hit the hotspot-rt forest, users noticed that hotspot/make/windows/create.bat builds were broken. This is a supplemental fix that restores building using that .bat file. Note that this is not on the 'product' build path at all - this is something HotSp

Re: RFR: 7190512 Fix for 7181175 broke hotspot/make/windows/create.bat builds.

I wrote: Hello all- After the fixes for 7181175 hit the hotspot-rt forest, users noticed that hotspot/make/windows/create.bat builds were broken. This is a supplemental fix that restores building using that .bat file. Note that this is not on the 'product' build path at all - this is somet

Re: RFR: 7190512 Fix for 7181175 broke hotspot/make/windows/create.bat builds.

On 08/10/12 14:08, Daniel D. Daugherty wrote: On 8/10/12 3:07 PM, Tim Bell wrote: I wrote: Hello all- After the fixes for 7181175 hit the hotspot-rt forest, users noticed that hotspot/make/windows/create.bat builds were broken. This is a supplemental fix that restores building using that

Re: RFR: 7190512 Fix for 7181175 broke hotspot/make/windows/create.bat builds.

On 08/11/12 12:12, Daniel D. Daugherty wrote: On 8/11/12 3:49 AM, Dmitry Samersoff wrote: Dan, On 2012-08-11 01:08, Daniel D. Daugherty wrote: One-line addition of two double quotes... Gotta love Windows. It's not about windows. Unpack workspace to "mypath with spaces" and try to build hotspo

Re: Need reviewers: more predictable binaries

On 09/05/12 21:08, Kelly O'Hair wrote: Need a reviewer for this change. http://cr.openjdk.java.net/~ohair/openjdk8/jdk8-this-file/webrev/ It does change source, but it's effectively a build change. The goal here is to try and create more predictable binary files and remove the possibility

Re: RFR: 8000461 Top level build doesn't pass OPENJDK=true through to the hotspot build

On 10/07/12 16:36, David Holmes wrote: This is a simple fix contributed by Mark Weilaard to add the OPENJDK=true make variable to COMMON_BUILD_ARGUMENTS so that it gets passed down to the component builds - in particular hotspot: http://cr.openjdk.java.net/~dholmes/8000461/webrev/ Looks good

Re: Fwd: Re: How to decrease size of j2sdk_image

Hi Jon: Is there, should there be a FAQ for the new build, along the lines of a series of "How do I ..." questions? -- Jon Have you been through "README for the New Build System"? http://openjdk.java.net/projects/build-infra/guide.html Section 9 of that doc is a FAQ. We can certainly up

hg: jdk8/build/corba: 7152336: Enable builds on Windows with MinGW/MSYS

Changeset: 0a5931be9176 Author:tbell Date: 2012-10-23 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/build/corba/rev/0a5931be9176 7152336: Enable builds on Windows with MinGW/MSYS Summary: Minimal makefile changes to enable building OpenJDK using MSYS on Windows7 Reviewed-by: oha

hg: jdk8/build/jdk: 7152336: Enable builds on Windows with MinGW/MSYS

Changeset: a0a2b186ae28 Author:tbell Date: 2012-10-23 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/a0a2b186ae28 7152336: Enable builds on Windows with MinGW/MSYS Summary: Minimal makefile changes to enable building OpenJDK using MSYS on Windows7 Reviewed-by: ohair

hg: jdk8/build: 7152336: Enable builds on Windows with MinGW/MSYS

Changeset: c12e759ac4e8 Author:tbell Date: 2012-10-23 10:10 -0700 URL: http://hg.openjdk.java.net/jdk8/build/rev/c12e759ac4e8 7152336: Enable builds on Windows with MinGW/MSYS Summary: Minimal makefile changes to enable building OpenJDK using MSYS on Windows7 Reviewed-by: ohair, tb

Re: Build changes for 7176225: Remove JDBC-ODBC Bridge

Looks good to me also. Always good to see code deletion take place. Tim On 10/26/12 09:31, Kelly O'Hair wrote: Looks ok to me. We may need to do some builds both ways to make sure. -kto On Oct 26, 2012, at 9:16 AM, Alan Bateman wrote: We're jettisoning the legacy JDBC-ODBC bridge from Ora

Re: [8] Review request for 8001764: vsvars.sh should support VS2012

Anthony: Please review a fix for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8001764 at: http://cr.openjdk.java.net/~anthony/8-46-full-vs2012.0/ These changes look fine. We're not yet switching JDK builds to VS2012. However, the vsvars.sh script is useful for other applications in o

Re: [8] Review request for 8001764: vsvars.sh should support VS2012

On 10/29/12 12:06, Anthony Petrov wrote: That's correct. Currently we don't have any plans to change compilers for JDK 8. It will be discussed with the release team when need arises. OK, thanks. Sorry if I sounded a bit fussy, but I want to avoid last minute surprises if we can, and it is bet

Re: XS RFR: 8002040 Allow Full Debug Symbols when cross-compiling

On 11/06/12 21:08, David Holmes wrote: webrev: http://cr.openjdk.java.net/~dholmes/8002040/webrev/ This is a simplified variant of the change just made to Hotspot. Instead of disabling FDS when cross-compiling we change the default location of objcopy, and just as with native compilation eith

Re: Review request: 8002365: build-infra: Build-infra fails on solaris 11.1 on sparc

On 11/07/12 06:38, Erik Joelsson wrote: This is essentially the patch from Vincent to make build-infra work on Solaris 11.1 with some minor adjustments to keep the new and old build equal. http://cr.openjdk.java.net/~erikj/8002365/webrev.01/

Re: Review Request: 8002028: build-infra: need no-hotspot partial build

Looks good to me. Tim On 11/08/12 06:27, Erik Joelsson wrote: New webrev for root: http://cr.openjdk.java.net/~erikj/8002028/webrev.root.02/ Changed to conditional as David suggested. Improved the description and fail message i

Re: CFV: Nomination of Erik Joelsson to OpenJDK Build Group

Vote: yes On 11/07/12 09:52, Kelly O'Hair wrote: Please cast your vote or veto by replying to this message

hg: jdk8/build: 8002028: build-infra: need no-hotspot partial build

Changeset: 78bb27faf889 Author:tbell Date: 2012-11-12 12:34 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/78bb27faf889 8002028: build-infra: need no-hotspot partial build Summary: Added configure option --with-import-hotspot=/path/to/j2sdkimage Reviewed-by: dholmes, tbell Con

hg: jdk8/build/jdk: 3 new changesets

Changeset: 170e8ccfbc4f Author:tbell Date: 2012-11-12 10:20 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/170e8ccfbc4f 8002365: build-infra: Build-infra fails on solaris 11.1 on sparc. Summary: Add '-lc' to LDFLAGS for native libraries in CompileNativeLibraries.gmk Review

Re: Review Request: 8002026: build-infra: deploy repository building

Hi Erik: This is the open part of this change. It only changes the compare script to handle the deploy build artifacts. http://cr.openjdk.java.net/~erikj/8002026/webrev.root.01/ I was getting ready to push this for you when I not

hg: jdk8/build: 8003274: build-infra: Makefile changes needed for sjavac

Changeset: f2ac4d0edaae Author:tbell Date: 2012-11-13 15:54 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/f2ac4d0edaae 8003274: build-infra: Makefile changes needed for sjavac Summary: changes left in build-infra that are related to sjavac Reviewed-by: ohair, tbell Contribute

hg: jdk8/build/jdk: 8001965: build-infra: Large compare diffs between new and old on mac

Changeset: 84f0439ccaab Author:tbell Date: 2012-11-13 13:46 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/84f0439ccaab 8001965: build-infra: Large compare diffs between new and old on mac Summary: The wrong icon source file was used when building closed Reviewed-by: ohair

Re: Review Request: 8002026: build-infra: deploy repository building

On 11/14/12 01:22, Erik Joelsson wrote: Yes, it's intended. What I really would like to express is (in pseudo code): if (OS=windows AND BIN_FILE in ACCEPTED_SIZE_DIFF AND (DIFF_SIZE_NUM = 512 OR DIFF_SIZE_NUM = -512)) I wasn't sure I could write this in bash, but maybe I'm wrong. I figured th

Re: invalid bug IDs aborting my pull

In the incoming changesets those are the only two with IDs above 80. Off the top of my head (I'm on a concall at the moment)- Do you have the latest version of jcheck? http://hg.openjdk.java.net/code-tools/jcheck Specifically, this changeset to "Allow bugids of the form 8xx"? http:

hg: jdk8/build: 6 new changesets

Changeset: a2df4ee40ecb Author:tbell Date: 2012-11-14 10:05 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/a2df4ee40ecb 8002026: build-infra: deploy repository building Summary: Change the compare script to handle deploy build artifacts. Reviewed-by: ohair, tbell Contributed-b

hg: jdk8/build/jdk: 2 new changesets

Changeset: ccff3b663797 Author:tbell Date: 2012-11-14 10:21 -0800 URL: http://hg.openjdk.java.net/jdk8/build/jdk/rev/ccff3b663797 8001906: build-infra: warning: [path] bad path element on Solaris Summary: Remove unnecesary -cp parameter from compile line Reviewed-by: ohair, tbell Co

Re: Build of jdk-7udev: Error occurred during initialization of VM

See below for the 'flag day' message related to this, sent to the hotspot and 7u dev lists. On 11/14/12 21:24, David Holmes wrote: As general advice yes you need matching jdk and hotspot builds in 7u now (and 8), but this error in itself seems unrelated to invokeDynamic. [snip...] Pete Brun

Re: Fwd: Review Request: 8003300: build-infra: fails on solaris when objcopy is not found

On 11/19/12 08:56, Erik Joelsson wrote: This is a simple fix for when objcopy is missing. http://cr.openjdk.java.net/~erikj/8003300/webrev.root.01/ /Erik Looks good to me. Tim

hg: jdk8/build: 8003300: build-infra: fails on solaris when objcopy is not found

Changeset: ecf751a69f6a Author:tbell Date: 2012-11-19 14:06 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/ecf751a69f6a 8003300: build-infra: fails on solaris when objcopy is not found Summary: Only call BASIC_FIXUP_EXECUTABLE() if objcopy was found. Reviewed-by: tbell Contrib

Re: Review Request: 8001541: Cannot build on Solaris using softlinks

On 12/03/12 03:30, Erik Joelsson wrote: http://cr.openjdk.java.net/~erikj/8001541/webrev.root.01/ Looks good. Tim This change fixes issues with the source root being in a symlinked directory path. This has been tweaked before but now I think I've finally nailed it. When configure runs in

Re: Review Request: 8004281: build-infra: Move all jar creation to images target and put jars in images/lib

Looks good to me as well. (I forgot to CC the list on my reply). Tim On 12/03/12 04:57, Erik Joelsson wrote: Good catch! New webrev: http://cr.openjdk.java.net/~erikj/8004281/webrev.02/ /Erik On 2012-12-03 12:57, David Holmes wrote: In CreateJars.gmk there is a typo: 654 $(isntal

Re: Review Request: 8003414: build-infra: fails on on windows

Looks good. Tim On 12/05/12 00:54, Erik Joelsson wrote: Found a mistake in the previous patch. Here is an update. http://cr.openjdk.java.net/~erikj/8003414/webrev.02/ /Erik On 2012-11-30 13:34, Erik Joelsson wrote: This patch adds an extra check for validating that the windows sdk found by

Re: Review Request: 8004045: build-infra: Error 12 from zip when updating src.zip

Looks good to me. Tim On 12/07/12 00:28, Erik Joelsson wrote: Reminder to review this, please. /Erik On 2012-11-27 16:01, Erik Joelsson wrote: Small fix for common annoyance when rebuilding images. The zip utility returns 12 when it has nothing to do. This happens because we run it multiple

Re: Review Request: 8004803: build-infra: Cannot use icedtea as boot for closed build.

See the message thread on build-infra with subject "Problems with non Oracle boot JDKs and class file version 52" http://mail.openjdk.java.net/pipermail/build-infra-dev/2012-December/002601.html The issue appears if the bootstrap VM uses a class file version older than what the current build

Re: code review request for 7153050 remove crufty '_g' support

This looks fine to me from a build and build-infra perspective. Thanks for taking this on - code deletion is all good. Tim On 12/13/12 15:33, Daniel D. Daugherty wrote: Trying again... now my e-mail client is complaining... Adding back in the other OpenJDK aliases... Ron's e-mail has gone of

Re: Review Request: 8005178: build-infra: Dependency on libfdlibm on mac is broken

Looks good to me- Tim On 12/19/12 01:16, Erik Joelsson wrote: Oh, I will explain it. So, on all other platforms, this is the dependency chain (simplified, skipping the actual recipe rules): BUILD_LIBFDLIBM:=/path/to/libfdlibm.a BUILD_LIBJAVA:=/path/to/libjava.so $(BUILD_LIBJAVA): $(BUILD_LI

Re: Review Request: 8001942: build-infra: General permission problems on Windows/cygwin

Erik: Small change, adding a configure check making sure the source has read permission. If not, an error message explaining the likely cause in cygwin is printed. http://cr.openjdk.java.net/~erikj/8001942/webrev.01/ /Erik Looks good. Thank you for this - a number of users on this list ha

Re: Review Request: 8005548: build-infra: Fix docs target on windows

Erik: Small fix for making docs target work on windows. Corrects path separator. http://cr.openjdk.java.net/~erikj/8005548/webrev.01/ Looks good! Tim

Re: Review Request: 8005549: build-infra: Merge NewMakefile.gmk and common/makefiles/Makefile

Looks good. Tim On 12/27/12 12:50, Erik Joelsson wrote: Merged NewMakefile.gmk and common/makefiles/Makefile and removed redundant functionality. * The bridgebuild and jprt specific stuff was moved to a separate file common/makefiles/Jprt.gmk. * Default targets changed a bit. Default is basi

Re: Review Request: 8004490: build-infra: mac: hotspot is always built in product, regardless of --with-debug-level setting

Looks good to me. Tim On 12/28/12 04:39, Erik Joelsson wrote: I picked the variable that will have the values that match the targets in hotspot. The difference is jvmg vs debug. For other platforms, the target list will look something like: jvmg jvmg1 docs export_debug For mac it's just: u

Re: Review Request: 8001895: build-infra: Make JDK_BUILD_NUMBER and MILESTONE customizable

Hi Erik: I've added configure options for milestone and build number so that they can be customized. http://cr.openjdk.java.net/~erikj/8001895/webrev.root.01/ Looks good. Tim

Re: Review Request: 8005347: build-infra: Verify 'gnumake source' at the top level works ok

Hi Erik: Open part of this review. Configure needs to supply a couple of more utilities and version string variations. http://cr.openjdk.java.net/~erikj/8005347/webrev.root.01/ Looks good. Tim

Re: Review Request: 8005355: build-infra: Java security signing (need a top-level make target).

Erik wrote: * Changed Createjars.gmk so that all the security jars are always built, just like in the old build. The unsigned jars end up in images/unsigned/*.jar. For solaris ucrypto.jar, this also required turning on compiling the classes and excluding them from rt.jar. * Added SignJars.gmk

Re: Review Request: 8005694: build-infra: Cleanup of misc changes in build-infra

Erik: There are a couple of minor changes in build-infra that haven't been merged to jdk8/build yet. All are small and insignificant on their own. * Removal of redundant package entries in jar exclude lists. Also sorting the lists to make it easier to spot redundant packages in the future.

Re: Review Request: 8005692: build-infra: Target "all" should do the right thing

Erik: Small patch for adding overlay-images to the all target on solaris 64-bit platforms. http://cr.openjdk.java.net/~erikj/8005692/webrev.root.01/ Looks good. Tim

Re: Review Request: 8005654: build-infra: Create sec-bin.zip

Erik: This patch adds building of sec-bin.zip to images target. Building using this zip will be solved later in a different bug. Had to add INCLUDE_FILES option to SetupZipArchive. Also added comparison of sec-bin.zip to compare script. http://cr.openjdk.java.net/~erikj/8005654/webrev.01/

Re: Review Request: 8005597: build-infra: bridgeBuild broken for pure openjdk build

Erik: Looks good. Ideally I would like the custom hooks in configure and the makefiles guarded with checks for OPENJDK (in the closed part of the hook). I have added them to some parts that I know will affect the build, but haven't done a full audit yet. Feel free to file another bug report

Re: Review Request: 8005575: build-infra: Three JCK tests fails on Solaris with new RE Autoconf-Based build

Hi Erik Looks good. Is there an issue open for the future "unified functionality in JavaCompilation.gmk" Tim On 01/04/13 02:29, Erik Joelsson wrote: Had to add LANG=C to the nawk line to make this work on my linux workstation, otherwise one comment wouldn't get matched because it containe

Re: Review Request: 8005723: build-infra: in new infra build, sec-windows-bin-zip and jgss-windows-*-bin.zip are missing

Erik: Adding support for two more zip files that weren't created in build-infra. Also adding compare support. http://cr.openjdk.java.net/~erikj/8005723/webrev.01/ Looks good. Thanks. Tim

Re: jdk8 Build changes

Hi Volker: I always thought that the MinGW build would be the default for the new build systems but reading your mail this apparently isn't true. Will the MinGW build just not be the default one or will it not work / not be supported at all? If not, will the MinGW changes just get lost in the o

hg: jdk8/build: 8005442: autogen.sh sets DATE_WHEN_GENERATED to empty string on Solaris version 11 or later

Changeset: 7a3c6ffdf1fb Author:tbell Date: 2013-01-07 14:01 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/7a3c6ffdf1fb 8005442: autogen.sh sets DATE_WHEN_GENERATED to empty string on Solaris version 11 or later Reviewed-by: ohair ! common/autoconf/autogen.sh

Re: Review Request: 8005794: in new infra, how do we change java -version?

Hi Erik Joelsson: Adding a configure parameter --with-user-release-suffix which acts as the USER_RELEASE_SUFFIX variable used to do. If build number isn't set or is set to b00, this gets added to the full version string, overriding the default value _. It's also possible to override this vari

Re: Review Request: 8005850: build-infra: Make --enable-openjdk-only really disable custom

Erik: The open part of this review. Move handling of --enable-openjdk-only to before the first custom hook call. http://cr.openjdk.java.net/~erikj/8005850/webrev.root.01/ Looks good. Tim

Re: Review Request: 8005855: build-infra: Remove -R flag when cross compiling

Hi Erik: Filter away -R flags from X_LIBS variable in configure. http://cr.openjdk.java.net/~erikj/8005855/webrev.root.01/ common/autoconf/libraries.m4: 143 X_LIBS=`$ECHO $X_LIBS | $SED 's/-R.*//g'` If I am reading this correctly, sed will delete everything from -R to end of line. Is that

Re: Review Request: 8005856: build-infra: Remove special handling of base module classes header generation

On 01/08/13 06:17, Alan Bateman wrote: On 08/01/2013 14:07, Erik Joelsson wrote: Five classes which in jigsaw will be located in the base module currently have their native headers generated in a special way (explicitly with javah). This was because the base module could not be made dependent

Re: Review Request: 8005858: build-infra: Add missed comparison of sec-windows-bin.zip and friends to compare.sh

Erik: When submitting JDK-8005723 to jdk8/build, I missed adding the comparisons of these files to compare.sh. The implementation was already done in build-infra. http://cr.openjdk.java.net/~erikj/8005858/webrev.root.01/ Looks good. Tim

hg: jdk8/build: 8005794: in new infra, how do we change java -version?

Changeset: b284980b7d9a Author:tbell Date: 2013-01-08 16:23 -0800 URL: http://hg.openjdk.java.net/jdk8/build/rev/b284980b7d9a 8005794: in new infra, how do we change java -version? Summary: Added configure parameter --with-user-release-suffix Reviewed-by: ohair, tbell ! common/auto

Re: Review Request: 8005903: build-infra: bad symlink: j2sdk-bundle/jdk1.8.0.jdk/Contents/MacOS/libjli.dylib

Hi Erik: Correcting the symlink to libjli in the macosx jdk bundle. http://cr.openjdk.java.net/~erikj/8005903/webrev.jdk.01/ Looks good. Tim

Re: Request for review: 8004834: Add doclint support into javadoc

Jon: We will soon want to push changes into TL to enable doclint support in javadoc. This will require a minor build change until we can fix up (lots of) errors in our javadoc comments. The problem is that because of the many errors in our doc comments, javadoc will now exit with a non-zero

Re: Review Request: 8005850: build-infra: Make --enable-openjdk-only really disable custom

On 01/10/13 03:09, Erik Joelsson wrote: Fixed the spelling error http://cr.openjdk.java.net/~erikj/8005850/webrev.root.02/ Looks good to me. Tim /Erik On 2013-01-09 03:44, David Holmes wrote: On 8/01/2013 10:56 PM, Erik Joelsson wrote: The open part of this review. Move handling of --e

Re: Review Request: 8006074: build-infra: Configure fails to find SetEnv.Cmd in microsoft sdk

Erik: This small patch fixes a problem with configure, Cygwin and Microsoft SDK SetEnv.Cmd as reported in this mail: http://mail.openjdk.java.net/pipermail/build-infra-dev/2013-January/002911.html http://cr.openjdk.java.net/~erikj/8006074/webrev.root.01/ Looks good. Thanks for fixing th

Re: Review Request: 8006100: build-infra: Bundle up the correct images in jprt

Erik: This fixes the bundles target for jprt so that overlay images are bundled up for solaris 64bit. http://cr.openjdk.java.net/~erikj/8006100/webrev.root.01/ Looks good. Even if several people would like to do away with the overlay images, that change should be separate to switching to b

Re: Review Request: 8006100: build-infra: Bundle up the correct images in jprt

Erik: This didn't quite work as I expected. Found the issue in needing to include SPEC before Jprt.gmk so that variables from SPEC would be available in Jprt.gmk at parse time. http://cr.openjdk.java.net/~erikj/8006100/webrev.root.02/ Looks good. Tim /Erik On 2013-01-11 17:25, Erik Joe

Re: Review Request: 8006296: build-infra: Unsigned sunmscapi.jar is missing manifest.

On 01/15/13 03:33, Alan Bateman wrote: On 15/01/2013 11:13, Erik Joelsson wrote: This fix adds the missing manifest to sunmscapi.jar. This should fix javax/crypto/sanity/CheckManifestForRelease.java which is currently failing for build-infra builds. http://cr.openjdk.java.net/~erikj/8006296/w

Re: javadocs with NEWBUILD

On 01/15/13 14:17, Deneau, Tom wrote: Is there a way to build javadocs with NEWBUILD=true. I get the following :~/lambda$ make NEWBUILD=true javadocs cd common/makefiles && make -f MakefileJavadoc.gmk make[1]: Entering directory `lambda/common/makefiles' make[1]: MakefileJavadoc.gmk: No such fil

Re: Review Request: 8006385: build-infra: linux and solaris *-debuginfo-*.zip file created from the new makefile has extra HUDSON direcotry in jre/lib/i386/server

Hi Erik: Fix for the jre/lib/i386/server/libjsig.diz file which in build-infra contained the path to the file relative to the file system root instead of the directory of the file. http://cr.openjdk.java.net/~erikj/8006385/webrev.jdk.01/ Looks good. Tim

Re: Review Request: 8006520: build-infra: Fix sparkle-framework configure parameter

Erik: Adding sparkle-framework to bridgeBuild. http://cr.openjdk.java.net/~erikj/8006520/webrev.root.01/ Looks good. Tim

Re: Review Request: 8006567: jre/lib/applet missing from Mac JDK installation

Erik: When copying the j2*-image dirs to j2*-bundle, empty directories weren't included. This caused jre/lib/applet to be missing. This patch makes sure empty directories are also copied over. http://cr.openjdk.java.net/~erikj/8006567/webrev.jdk.01/ Looks good. Tim

Re: Review Request: 8003693: build-infra: bridgeBuild should allow for partial build (no hotspot)

Erik: Making it possible to use --with-import-hotspot through bridgeBuild and jprt. Also converted check for open only to use same wildcard construction as the new HOTSPOT_AVAILABLE to avoid unneeded shell expressions. http://cr.openjdk.java.net/~erikj/8003693/webrev.root.01/ Looks good-

Re: Review Request: 8006579: build-infra: In jvm.cfg, alias -server to -client when no server jvm is built.

Erik: Small patch to fix a minor difference between new and old build. In jvm.cfg, alias -server to -client when no server jvm is built. http://cr.openjdk.java.net/~erikj/8006579/webrev.jdk.01/ Looks good. Tim

Re: Review Request: 8006583: build-infra: Remove /javax/swing/SwingBeanInfoBase.java from src.zip

Hi Erik- Cleanup after JDK-8005096, which accidentally added /javax/swing/SwingBeanInfoBase.java to src.zip for build-infra but not for old build. http://cr.openjdk.java.net/~erikj/8006583/webrev.jdk.01/ Looks good. Tim

  1   2   3   4   5   6   7   8   9   10   >