Re: Documenting options; was Re: RFR: JDK-8220639 Need a way to augment JTREG_LAUNCHER_OPTIONS from command-line

2020-06-25 Thread Erik Joelsson
Looks good, thanks for cleaning up the whole file! /Erik On 2020-06-24 15:39, Magnus Ihse Bursie wrote: On 2020-06-15 23:23, Erik Joelsson wrote: The makefile test documentation is in the repo, so you could link directly to it:

Re: Documenting options; was Re: RFR: JDK-8220639 Need a way to augment JTREG_LAUNCHER_OPTIONS from command-line

2020-06-24 Thread Magnus Ihse Bursie
On 2020-06-15 23:23, Erik Joelsson wrote: The makefile test documentation is in the repo, so you could link directly to it: https://hg.openjdk.java.net/jdk/jdk/raw-file/87828d2e32fe/doc/testing.html Which reminds me that Magnus should update that documentation with these new options. Ok,

Re: Documenting options; was Re: RFR: JDK-8220639 Need a way to augment JTREG_LAUNCHER_OPTIONS from command-line

2020-06-16 Thread Magnus Ihse Bursie
On 2020-06-16 16:45, Magnus Ihse Bursie wrote: On 2020-06-16 16:35, Jonathan Gibbons wrote: On 6/16/20 5:26 AM, Magnus Ihse Bursie wrote: On 2020-06-16 04:33, Jonathan Gibbons wrote: Thanks; I'll link to that page from the jtreg FAQ. ... but please use the tip URL:

test defaults: was Re: Documenting options; was Re: RFR: JDK-8220639 Need a way to augment JTREG_LAUNCHER_OPTIONS from command-line

2020-06-16 Thread Jonathan Gibbons
On defaults for running jtreg tests ... In my experience, and given the separate recent discussion with Stefan Karlsson, there are two significant modalities for running tests: running lots of tests, and just running a single test, typically while developing or debugging the test. With that

Re: Documenting options; was Re: RFR: JDK-8220639 Need a way to augment JTREG_LAUNCHER_OPTIONS from command-line

2020-06-16 Thread Jonathan Gibbons
Magnus, There's a mild ambiguity in the use of the phrase "JTReg keywords" which is used to describe both the mechanism in the run-test framework, and the jtreg test selection mechanism. That aside, while reading the file, I noticed the following typo (kewords): KEYWORDS JTReg

Re: Documenting options; was Re: RFR: JDK-8220639 Need a way to augment JTREG_LAUNCHER_OPTIONS from command-line

2020-06-16 Thread Magnus Ihse Bursie
On 2020-06-16 16:35, Jonathan Gibbons wrote: On 6/16/20 5:26 AM, Magnus Ihse Bursie wrote: On 2020-06-16 04:33, Jonathan Gibbons wrote: Thanks; I'll link to that page from the jtreg FAQ. ... but please use the tip URL: https://hg.openjdk.java.net/jdk/jdk/raw-file/tip/doc/testing.html

Re: Documenting options; was Re: RFR: JDK-8220639 Need a way to augment JTREG_LAUNCHER_OPTIONS from command-line

2020-06-16 Thread Jonathan Gibbons
On 6/16/20 5:26 AM, Magnus Ihse Bursie wrote: On 2020-06-16 04:33, Jonathan Gibbons wrote: Thanks; I'll link to that page from the jtreg FAQ. ... but please use the tip URL: https://hg.openjdk.java.net/jdk/jdk/raw-file/tip/doc/testing.html Actually, that link is going to get stale in just

Re: Documenting options; was Re: RFR: JDK-8220639 Need a way to augment JTREG_LAUNCHER_OPTIONS from command-line

2020-06-16 Thread Magnus Ihse Bursie
On 2020-06-16 14:31, Lance Andersen wrote: Hi Magnus, Can we update this page to include an example of how to run a JTREG manual test via the make infrastructure? For the record: After some off-list discussion, Lance opened https://bugs.openjdk.java.net/browse/JDK-8247690 for supporting

Re: Documenting options; was Re: RFR: JDK-8220639 Need a way to augment JTREG_LAUNCHER_OPTIONS from command-line

2020-06-16 Thread Lance Andersen
Hi Magnus, Can we update this page to include an example of how to run a JTREG manual test via the make infrastructure? Best Lance > On Jun 16, 2020, at 8:26 AM, Magnus Ihse Bursie > wrote: > > On 2020-06-16 04:33, Jonathan Gibbons wrote: >> Thanks; I'll link to that page from the jtreg

Re: Documenting options; was Re: RFR: JDK-8220639 Need a way to augment JTREG_LAUNCHER_OPTIONS from command-line

2020-06-16 Thread Magnus Ihse Bursie
On 2020-06-16 04:33, Jonathan Gibbons wrote: Thanks; I'll link to that page from the jtreg FAQ. ... but please use the tip URL: https://hg.openjdk.java.net/jdk/jdk/raw-file/tip/doc/testing.html Actually, that link is going to get stale in just a few months time. Probably better to link here

Re: Documenting options; was Re: RFR: JDK-8220639 Need a way to augment JTREG_LAUNCHER_OPTIONS from command-line

2020-06-15 Thread Jonathan Gibbons
Thanks; I'll link to that page from the jtreg FAQ. -- Jon On 6/15/20 2:23 PM, Erik Joelsson wrote: The makefile test documentation is in the repo, so you could link directly to it: https://hg.openjdk.java.net/jdk/jdk/raw-file/87828d2e32fe/doc/testing.html Which reminds me that Magnus

Re: Documenting options; was Re: RFR: JDK-8220639 Need a way to augment JTREG_LAUNCHER_OPTIONS from command-line

2020-06-15 Thread Erik Joelsson
The makefile test documentation is in the repo, so you could link directly to it: https://hg.openjdk.java.net/jdk/jdk/raw-file/87828d2e32fe/doc/testing.html Which reminds me that Magnus should update that documentation with these new options. /Erik On 2020-06-15 14:19, Jonathan Gibbons

Documenting options; was Re: RFR: JDK-8220639 Need a way to augment JTREG_LAUNCHER_OPTIONS from command-line

2020-06-15 Thread Jonathan Gibbons
Magnus, Would it be worth while adding something to the jtreg documentation, such as a new page describing these options for the JDK makefile support, giving due deference to the makefile (like "If in doubt, consult `make test JTREG=help`") I can write the page, with your help, if you think