Looks good!
/Erik
On 2018-02-23 11:39, Lois Foltan wrote:
On 2/23/2018 2:31 PM, Erik Joelsson wrote:
On 2018-02-23 11:16, Lois Foltan wrote:
On 2/23/2018 1:05 PM, Erik Joelsson wrote:
Hello Lois,
This looks good, but I would suggest to also add 1900 for VS2015,
for completeness.
Thanks
On 2/23/2018 2:31 PM, Erik Joelsson wrote:
On 2018-02-23 11:16, Lois Foltan wrote:
On 2/23/2018 1:05 PM, Erik Joelsson wrote:
Hello Lois,
This looks good, but I would suggest to also add 1900 for VS2015,
for completeness.
Thanks for the review Erik! I have updated the webrev to add 1900,
Thanks again for the review Erik!
Lois
On 2/23/2018 2:44 PM, Erik Joelsson wrote:
Looks good!
/Erik
On 2018-02-23 11:39, Lois Foltan wrote:
On 2/23/2018 2:31 PM, Erik Joelsson wrote:
On 2018-02-23 11:16, Lois Foltan wrote:
On 2/23/2018 1:05 PM, Erik Joelsson wrote:
Hello Lois,
This
On 2018-02-23 11:16, Lois Foltan wrote:
On 2/23/2018 1:05 PM, Erik Joelsson wrote:
Hello Lois,
This looks good, but I would suggest to also add 1900 for VS2015, for
completeness.
Thanks for the review Erik! I have updated the webrev to add 1900,
however, I couldn't find a release # for
On 2/23/2018 1:05 PM, Erik Joelsson wrote:
Hello Lois,
This looks good, but I would suggest to also add 1900 for VS2015, for
completeness.
Thanks for the review Erik! I have updated the webrev to add 1900,
however, I couldn't find a release # for VS2015, since all documentation
I could
Hello Lois,
This looks good, but I would suggest to also add 1900 for VS2015, for
completeness.
/Erik
On 2018-02-23 09:54, Lois Foltan wrote:
Please review this small fix to set HOTSPOT_BUILD_COMPILER correctly
for VS2017.
open webrev at