On 2020-03-28 10:34, Weijun Wang wrote:
On Mar 24, 2020, at 3:03 AM, Magnus Ihse Bursie
wrote:
I have also moved the build tools to the org.openjdk.buildtools.* package name
space (inspired by Skara), instead of the strangely named build.tools.* name
space.
Is this really necessary?
> On Mar 24, 2020, at 3:03 AM, Magnus Ihse Bursie
> wrote:
>
> I have also moved the build tools to the org.openjdk.buildtools.* package
> name space (inspired by Skara), instead of the strangely named build.tools.*
> name space.
Is this really necessary? Skara is a standalone tool that have
Hi Magnus,
On 3/24/20 4:16 AM, Magnus Ihse Bursie wrote:
At the core, we'd like to "invert" the current structure where we have
files like:
make/lib/Lib-java.base.gmk
make/lib/Lib-java.desktop.gmk
make/gensrc/Gensrc-java.base.gmk
make/gensrc/Gensrc-java.desktop.gmk
... etc
and instead have
On 2020-03-23 23:15, naoto.s...@oracle.com wrote:
Hi Magnus,
I looked at i18n related changes:
make/CopyInterimTZDB.gmk
make/ToolsJdk.gmk
make/gendata/Gendata-java.base.gmk
make/gendata/GendataBreakIterator.gmk
make/gendata/GendataTZDB.gmk
make/gensrc/GensrcCharacterData.gmk
On 2020-03-23 21:19, Mandy Chung wrote:
Hi Magnus,
Modularizing the build tools is a good move.
Thanks!
This patch suggests to place the build tools under
src/$MODULE/share/tools/$PACKAGE/*.java
I think the modular source location of the build tools needs more
discussion, including
Hi Magnus,
I looked at i18n related changes:
make/CopyInterimTZDB.gmk
make/ToolsJdk.gmk
make/gendata/Gendata-java.base.gmk
make/gendata/GendataBreakIterator.gmk
make/gendata/GendataTZDB.gmk
make/gensrc/GensrcCharacterData.gmk
make/gensrc/GensrcEmojiData.gmk
They look ok to me.
The *.java
On 23/03/2020 19:03, Magnus Ihse Bursie wrote:
The build tools (small java tools that are run during the build to
generate source code, or data, needed in the JDK) have historically
been placed in the "make" directory. This maybe made sense long time
ago, but does not do so anymore.
Hi Magnus,
Modularizing the build tools is a good move. This patch suggests to
place the build tools under
src/$MODULE/share/tools/$PACKAGE/*.java
I think the modular source location of the build tools needs more
discussion, including jigsaw-dev for this discussion.
The JDK source
Looks good.
/Erik
On 2020-03-23 12:03, Magnus Ihse Bursie wrote:
The build tools (small java tools that are run during the build to
generate source code, or data, needed in the JDK) have historically
been placed in the "make" directory. This maybe made sense long time
ago, but does not do so