Re: [10] RFR(S): 8189761: COMPANY_NAME, IMPLEMENTOR, BUNDLE_VENDOR, VENDOR, but no configure flag

2018-01-17 Thread Erik Joelsson
I can just adjust that before I push. I'm running it through internal testing now. Regarding quoting, make doesn't really do quotes. When you see quoted strings in make, it's generally done for shell consumption. /Erik On 2018-01-17 13:55, David Holmes wrote: Hi Volker, Changes seem okay

Re: [10] RFR(S): 8189761: COMPANY_NAME, IMPLEMENTOR, BUNDLE_VENDOR, VENDOR, but no configure flag

2018-01-17 Thread Volker Simonis
David Holmes schrieb am Mi. 17. Jan. 2018 um 22:55: > Hi Volker, > > Changes seem okay to me too. > Thanks David! > spec.gmk.in: > > ! # Only export VENDOR_URL, VENDOR_URL_BUG and VENDOR_VM_URL_BUG tot he > build if they > > Typo: tot he -> to the > Will fix tomorrow

Re: [10] RFR(S): 8189761: COMPANY_NAME, IMPLEMENTOR, BUNDLE_VENDOR, VENDOR, but no configure flag

2018-01-17 Thread David Holmes
Hi Volker, Changes seem okay to me too. spec.gmk.in: ! # Only export VENDOR_URL, VENDOR_URL_BUG and VENDOR_VM_URL_BUG tot he build if they Typo: tot he -> to the I'm also surprised this doesn't need any quoting: ifneq ($(COMPANY_NAME), N/A) Thanks, David On 18/01/2018 2:03 AM, Volker

Re: [10] RFR(S): 8189761: COMPANY_NAME, IMPLEMENTOR, BUNDLE_VENDOR, VENDOR, but no configure flag

2018-01-17 Thread Volker Simonis
Erik Joelsson schrieb am Mi. 17. Jan. 2018 um 20:16: > Looks good to me. I can sponsor it. Thanks a lot Erik! Regards, Volker > > /Erik > > > On 2018-01-17 08:03, Volker Simonis wrote: > > Hi, > > > > can I please have a review and sponsor for this change which

Re: [10] RFR(S): 8189761: COMPANY_NAME, IMPLEMENTOR, BUNDLE_VENDOR, VENDOR, but no configure flag

2018-01-17 Thread Erik Joelsson
Looks good to me. I can sponsor it. /Erik On 2018-01-17 08:03, Volker Simonis wrote: Hi, can I please have a review and sponsor for this change which finally exposes the various "vendor*" properties: java.vendor java.vm.vendor java.vendor.url java.vendor.url.bug as configure arguments:

[10] RFR(S): 8189761: COMPANY_NAME, IMPLEMENTOR, BUNDLE_VENDOR, VENDOR, but no configure flag

2018-01-17 Thread Volker Simonis
Hi, can I please have a review and sponsor for this change which finally exposes the various "vendor*" properties: java.vendor java.vm.vendor java.vendor.url java.vendor.url.bug as configure arguments: http://cr.openjdk.java.net/~simonis/webrevs/2018/8189761