Re: [ping] [11u] RFR 8234535: Cross compilation fails due to missing CFLAGS for the BUILD_CC

2020-08-26 Thread Christoph Göttschkes 

Thank you for the quick review, Severin.

-- Christoph

On 2020-08-26 12:10, Severin Gehwolf wrote:

On Wed, 2020-08-26 at 11:29 +0200, Christoph Göttschkes wrote:

Webrev: https://cr.openjdk.java.net/~cgo/8234535/webrev-11u.00/


This looks fine to me.

Thanks,
Severin

Re: [ping] [11u] RFR 8234535: Cross compilation fails due to missing CFLAGS for the BUILD_CC

2020-08-26 Thread Severin Gehwolf 
On Wed, 2020-08-26 at 11:29 +0200, Christoph Göttschkes wrote:
> > Webrev: https://cr.openjdk.java.net/~cgo/8234535/webrev-11u.00/

This looks fine to me.

Thanks,
Severin

[ping] [11u] RFR 8234535: Cross compilation fails due to missing CFLAGS for the BUILD_CC

2020-08-26 Thread Christoph Göttschkes 

Hi,

the webrev below still applies cleanly to jdk11u-dev. Could someone 
please review this downport?


Thanks,
Christoph

On 2020-07-20 15:48, Christoph Göttschkes wrote:

Hi,

please review this downport of JDK-8234535 to jdk11u-dev.

The changeset does not apply cleanly because of unrelated differences in 
the flags-cflags.m4 file surrounding the patch. Manually applying the 
patch was trivial.


Bug: https://bugs.openjdk.java.net/browse/JDK-8234535
Commit: https://hg.openjdk.java.net/jdk/jdk/rev/eef0bf57357c
Webrev: https://cr.openjdk.java.net/~cgo/8234535/webrev-11u.00/

Thanks,
Christoph