Re: 8193503: javah launcher was not removed by JDK-8191054

2017-12-14 Thread Jonathan Gibbons
Alan, Thanks for catching and handling this. Sorry for the scramble. I'm surprised it wasn't caught by the jdk-tier1 tests I ran before pushing the changeset. -- Jon On 12/14/2017 01:12 AM, Alan Bateman wrote: Jon removed the code for javah from the jdk.compiler module with JDK-8191054 but

Re: 8193503: javah launcher was not removed by JDK-8191054

2017-12-14 Thread Alan Bateman
On 14/12/2017 09:21, Erik Joelsson wrote: Looks good! /Erik I'll get this in now and also create another issue to remove the other remnants of javah from the build (they won't impact the build output but will need to be cleaned up). -Alan

Re: 8193503: javah launcher was not removed by JDK-8191054

2017-12-14 Thread joe darcy
On 12/14/2017 1:12 AM, Alan Bateman wrote: Jon removed the code for javah from the jdk.compiler module with JDK-8191054 but the build still creates a launcher that is now DOA with "Error: Could not find or load main class com.sun.tools.javah.Main in module jdk.compiler". This is caught by one

Re: 8193503: javah launcher was not removed by JDK-8191054

2017-12-14 Thread Erik Joelsson
Looks good! /Erik On 2017-12-14 10:12, Alan Bateman wrote: Jon removed the code for javah from the jdk.compiler module with JDK-8191054 but the build still creates a launcher that is now DOA with "Error: Could not find or load main class com.sun.tools.javah.Main in module jdk.compiler".

8193503: javah launcher was not removed by JDK-8191054

2017-12-14 Thread Alan Bateman
Jon removed the code for javah from the jdk.compiler module with JDK-8191054 but the build still creates a launcher that is now DOA with "Error: Could not find or load main class com.sun.tools.javah.Main in module jdk.compiler". This is caught by one of the launcher tests that checks the