5
> > To: Thomas Stüfe
> > Cc: Erik Joelsson ; Baesken, Matthias
> > ; Chris Hegarty ;
> > build-dev ; Maurizio Cimadamore
> >
> > Subject: Re: RFR: 8213591 : running bin/idea.sh in Cygwin: generated project
> > cannot be imported - was : RE: bin/idea.sh and
; Maurizio Cimadamore
>
> Subject: Re: RFR: 8213591 : running bin/idea.sh in Cygwin: generated project
> cannot be imported - was : RE: bin/idea.sh and Cygwin
>
> Hi Thomas,
>
> thanks! I've tested on Windows 2012, vs2013.
>
> Anyone with latest Windows 10 to test th
Hi Thomas,
thanks for offering a sponsoring.
@Matthias: can you please test this patch, so we can commit?
On 11/12/18 7:16 AM, Thomas Stüfe wrote:
Hi Michal,
I can sponsor for you.
@Matthias: yould you test on your Box too if this patch works?
Best Regards, Thomas
On Mon, Nov 12, 2018 at
Hi Michal,
I can sponsor for you.
@Matthias: yould you test on your Box too if this patch works?
Best Regards, Thomas
On Mon, Nov 12, 2018 at 5:24 AM Michal Vala wrote:
>
> Hi Thomas,
>
> thanks! I've tested on Windows 2012, vs2013.
>
> Anyone with latest Windows 10 to test this?
>
> Also I'd
Hi Thomas,
thanks! I've tested on Windows 2012, vs2013.
Anyone with latest Windows 10 to test this?
Also I'd like to ask someone to sponsor this, as I'm just an author.
On 11/9/18 7:09 PM, Thomas Stüfe wrote:
Hi Michal,
I tested this and it now works nicely for me (win7, vs2017, with
Hi Michal,
I tested this and it now works nicely for me (win7, vs2017, with
current jdk/jdk).
Change looks fine to me to.
Best Regards, Thomas
On Fri, Nov 9, 2018 at 7:23 PM Michal Vala wrote:
>
> I got valid idea project even with empty JT_HOME as placeholder was correctly
> replaced by
I got valid idea project even with empty JT_HOME as placeholder was correctly
replaced by empty string. Sure that it's not acceptable.
Anyway, JT_HOME should be only variable that can be empty.
new webrev: http://cr.openjdk.java.net/~mvala/jdk/jdk/JDK-8213591/webrev.02/
On 11/9/18 5:42 PM,
On Fri, Nov 9, 2018 at 5:35 PM Thomas Stüfe wrote:
>
> Hi Michal,
>
> does not yet work for me. I get cygpath Usage output:
>
> $ bash ./bin/idea.sh
> Usage: cygpath (-d|-m|-u|-w|-t TYPE) [-f FILE] [OPTION]... NAME...
>cygpath [-c HANDLE]
>cygpath [-ADHOPSW]
>cygpath [-F
Hi Michal,
does not yet work for me. I get cygpath Usage output:
$ bash ./bin/idea.sh
Usage: cygpath (-d|-m|-u|-w|-t TYPE) [-f FILE] [OPTION]... NAME...
cygpath [-c HANDLE]
cygpath [-ADHOPSW]
cygpath [-F ID]
Convert Unix and Windows format paths, or output system path
You're right, sorry. Updated webrev:
http://cr.openjdk.java.net/~mvala/jdk/jdk/JDK-8213591/webrev.01/
On 11/9/18 5:42 PM, Erik Joelsson wrote:
Hello Michal,
It looks like the "dirname" calls are omitted in the cygpath case, so BUILD_DIR
ends up pointing to the spec file instead of the
Hello Michal,
It looks like the "dirname" calls are omitted in the cygpath case, so
BUILD_DIR ends up pointing to the spec file instead of the directory the
file is in.
/Erik
On 2018-11-09 05:58, Michal Vala wrote:
Hi,
I've looked into this. Please review the patch:
11 matches
Mail list logo
