Thanks .
May I have a second review please ?
Best regards, Matthias
From: Doerr, Martin
Sent: Dienstag, 29. Oktober 2019 13:48
To: Baesken, Matthias ;
'hotspot-...@openjdk.java.net'
Cc: 'build-dev@openjdk.java.net'
Subject: RE: RFR: 8233078 : fix minimal VM build on Linux ppc64(le)
Hi
ent: Dienstag, 29. Oktober 2019 13:25
To: Doerr, Martin ; 'hotspot-...@openjdk.java.net'
Cc: 'build-dev@openjdk.java.net'
Subject: RE: RFR: 8233078 : fix minimal VM build on Linux ppc64(le)
Hi Martin, thanks for the input .
I did the adjustments you suggested; new webrev :
http://cr.openjdk.java.
Hi Martin, thanks for the input .
I did the adjustments you suggested; new webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8233078.1/
Regarding : stubGenerator_ppc.cpp: "Code should better be protected by #ifdef
COMPILER2 than commenting out."
Currently the if (OptimizeFill) { ... }
Hi Matthias,
thanks for fixing it. I have a few requests:
disassembler_ppc.cpp:
Please remove includes completely if no longer needed (instead of commenting
out).
sharedRuntime_ppc.cpp:
I think it's better to remove the 2 align(InteriorEntryAlignment). Succeeding
code is not performance
