Re: RFR: 8166189: Fix for Bug 8165524 breaks AIX build

2016-11-30 Thread Volker Simonis
On Wed, Nov 30, 2016 at 6:18 AM, Kumar Srinivasan wrote: > Hi Volker et. al., > > Was a bug opened to track this ? I still see these files around > http://hg.openjdk.java.net/jdk9/dev/jdk/file/ff45c582ca8a/src/java.base/aix/native/libjli > Hi Kumar, no, as far as

Re: RFR: 8166189: Fix for Bug 8165524 breaks AIX build

2016-09-29 Thread Kumar Srinivasan
+1. Kumar On 29/09/2016 16:25, Erik Joelsson wrote: Volker's comment above was directed at the suggestion of taking the problematic AIX specific code out of the OpenJDK repositories and create a separate library with a separate lifecycle somewhere else that OpenJDK for AIX would then need

Re: RFR: 8166189: Fix for Bug 8165524 breaks AIX build

2016-09-29 Thread Alan Burlison
On 29/09/2016 16:25, Erik Joelsson wrote: Volker's comment above was directed at the suggestion of taking the problematic AIX specific code out of the OpenJDK repositories and create a separate library with a separate lifecycle somewhere else that OpenJDK for AIX would then need to depend on.

Re: RFR: 8166189: Fix for Bug 8165524 breaks AIX build

2016-09-29 Thread Volker Simonis
On Thu, Sep 29, 2016 at 5:25 PM, Erik Joelsson wrote: > > > On 2016-09-29 16:54, Alan Burlison wrote: >> >> On 29/09/2016 08:03, Volker Simonis wrote: >> >>> Sorry, but that doesn't sound like a solution to me at all. I think we >>> should keep the OpenJDK sources

Re: RFR: 8166189: Fix for Bug 8165524 breaks AIX build

2016-09-29 Thread Chris Bensen
A lot of ideas have been thrown around so solve the problem of duplicated code in this situation. And there are other cases that are nearly identical so we need a general solution. The fact is this code should be moved to a common location. Since OpenJDK depends on Posix, Windows API and a few

Re: RFR: 8166189: Fix for Bug 8165524 breaks AIX build

2016-09-29 Thread Erik Joelsson
On 2016-09-29 16:54, Alan Burlison wrote: On 29/09/2016 08:03, Volker Simonis wrote: Sorry, but that doesn't sound like a solution to me at all. I think we should keep the OpenJDK sources self-contained. I don't want to depend on yet another non-standard, third party library which doesn't

Re: RFR: 8166189: Fix for Bug 8165524 breaks AIX build

2016-09-29 Thread Alan Burlison
On 29/09/2016 08:03, Volker Simonis wrote: Sorry, but that doesn't sound like a solution to me at all. I think we should keep the OpenJDK sources self-contained. I don't want to depend on yet another non-standard, third party library which doesn't even exist now. Unless I'm completely

Re: RFR: 8166189: Fix for Bug 8165524 breaks AIX build

2016-09-29 Thread Erik Joelsson
Hello, From my point of view, now that I better understand what aix/porting actually was/is, I would say go for it. Put something together the way you would like it. I doubt there will ever be much code needed in this new entity so it can go in the top level repo without problems. There is

Re: RFR: 8166189: Fix for Bug 8165524 breaks AIX build

2016-09-29 Thread Volker Simonis
On Wed, Sep 28, 2016 at 8:54 PM, Chris Bensen wrote: > > On Sep 28, 2016, at 11:50 AM, Thomas Stüfe wrote: > > > > On Wed, Sep 28, 2016 at 7:33 PM, Martin Buchholz > wrote: >> >> On Wed, Sep 28, 2016 at 9:33 AM, Volker

Re: RFR: 8166189: Fix for Bug 8165524 breaks AIX build

2016-09-28 Thread Chris Bensen
> On Sep 28, 2016, at 11:50 AM, Thomas Stüfe wrote: > > > > On Wed, Sep 28, 2016 at 7:33 PM, Martin Buchholz > wrote: > On Wed, Sep 28, 2016 at 9:33 AM, Volker Simonis

Re: RFR: 8166189: Fix for Bug 8165524 breaks AIX build

2016-09-28 Thread Thomas Stüfe
On Wed, Sep 28, 2016 at 7:33 PM, Martin Buchholz wrote: > On Wed, Sep 28, 2016 at 9:33 AM, Volker Simonis > wrote: > > > > > I don't think this can be easily done with the current build system. > > Remember for example that even such a sensitive

Re: RFR: 8166189: Fix for Bug 8165524 breaks AIX build

2016-09-28 Thread Martin Buchholz
On Wed, Sep 28, 2016 at 9:33 AM, Volker Simonis wrote: > > I don't think this can be easily done with the current build system. > Remember for example that even such a sensitive part like jni.h is > still duplicated between the hotspot and the jdk repository: > >

Re: RFR: 8166189: Fix for Bug 8165524 breaks AIX build

2016-09-28 Thread Volker Simonis
On Wed, Sep 28, 2016 at 3:03 PM, Kumar Srinivasan wrote: > > Hello Thomas, Volker, > > > Hi Kumar, > >> >> On 9/16/2016 10:34 AM, Volker Simonis wrote: >>> >>> Hi Christoph, >>> >>> I think your change is fine as a quick-fix to fix the build. But >>> you're