Re: RFR: 8254177: (tz) Upgrade time-zone data to tzdata2020b
On Tue, 13 Oct 2020 18:43:18 GMT, Andrew John Hughes wrote: >> Thanks for the review everyone, I have added a release note to the bug. I >> will integrate the changes > > Looks like we both reached the same patch for this one independently :) > systemv was removed from tzdata some time ago and wasn't even being read by > the JDK as far as I could see. Its contents > are duplicated in jdk11_backward anyway. Good to see both it and pacificnew > being removed. In the unlikely event the > removal of Pacific_New is problematic, it could be added to jdk11_backward as > well, but it seems very unlikely. Thanks for the comment, Andrew. I agree - PR: https://git.openjdk.java.net/jdk/pull/602
Re: RFR: 8254177: (tz) Upgrade time-zone data to tzdata2020b
On Tue, 13 Oct 2020 11:32:54 GMT, Kiran Sidhartha Ravikumar wrote: >> Looks good. I think we should release-note the removal of the >> "US/Pacific-New" Link on the off chance that some >> production/testing system is looking for such a zone. > > Thanks for the review everyone, I have added a release note to the bug. I > will integrate the changes Looks like we both reached the same patch for this one independently :) systemv was removed from tzdata some time ago and wasn't even being read by the JDK as far as I could see. Its contents are duplicated in jdk11_backward anyway. Good to see both it and pacificnew being removed. In the unlikely event the removal of Pacific_New is problematic, it could be added to jdk11_backward as well, but it seems very unlikely. - PR: https://git.openjdk.java.net/jdk/pull/602
Re: RFR: 8254177: (tz) Upgrade time-zone data to tzdata2020b
On Tue, 13 Oct 2020 11:07:13 GMT, Sean Coffey wrote: >> Hi Guys, >> >> Please review the patch for tzdata2020b integration into JDK. >> >> Release details can be found here: >> >> https://mm.icann.org/pipermail/tz-announce/2020-October/59.html >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8254177 >> >> I had the pacificnew, systemv files removed from JDK repo and so >> TimeZoneName classes, make file and few test files >> need to be updated to incorporate the change. >> The patch has passed all the related testing including JCK. >> >> Thanks, >> Kiran > > Looks good. I think we should release-note the removal of the > "US/Pacific-New" Link on the off chance that some > production/testing system is looking for such a zone. Thanks for the review everyone, I have added a release note to the bug. I will integrate the changes - PR: https://git.openjdk.java.net/jdk/pull/602
Re: RFR: 8254177: (tz) Upgrade time-zone data to tzdata2020b
On Mon, 12 Oct 2020 09:32:38 GMT, Kiran Sidhartha Ravikumar wrote: > Hi Guys, > > Please review the patch for tzdata2020b integration into JDK. > > Release details can be found here: > > https://mm.icann.org/pipermail/tz-announce/2020-October/59.html > > Bug: https://bugs.openjdk.java.net/browse/JDK-8254177 > > I had the pacificnew, systemv files removed from JDK repo and so TimeZoneName > classes, make file and few test files > need to be updated to incorporate the change. > The patch has passed all the related testing including JCK. > > Thanks, > Kiran Looks good. I think we should release-note the removal of the "US/Pacific-New" Link on the off chance that some production/testing system is looking for such a zone. - Marked as reviewed by coffeys (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/602
Re: RFR: 8254177: (tz) Upgrade time-zone data to tzdata2020b
On Mon, 12 Oct 2020 09:32:38 GMT, Kiran Sidhartha Ravikumar wrote: > Hi Guys, > > Please review the patch for tzdata2020b integration into JDK. > > Release details can be found here: > > https://mm.icann.org/pipermail/tz-announce/2020-October/59.html > > Bug: https://bugs.openjdk.java.net/browse/JDK-8254177 > > I had the pacificnew, systemv files removed from JDK repo and so TimeZoneName > classes, make file and few test files > need to be updated to incorporate the change. > The patch has passed all the related testing including JCK. > > Thanks, > Kiran Looks good to me. I was wondering about the consequence of removing the "US/Pacific-New" zone names, but since the time zone should never have been introduced in the first place (it didn't become the law), I think no real world application would have used it. - Marked as reviewed by naoto (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/602
Re: RFR: 8254177: (tz) Upgrade time-zone data to tzdata2020b
On Mon, 12 Oct 2020 09:32:38 GMT, Kiran Sidhartha Ravikumar wrote: > Hi Guys, > > Please review the patch for tzdata2020b integration into JDK. > > Release details can be found here: > > https://mm.icann.org/pipermail/tz-announce/2020-October/59.html > > Bug: https://bugs.openjdk.java.net/browse/JDK-8254177 > > I had the pacificnew, systemv files removed from JDK repo and so TimeZoneName > classes, make file and few test files > need to be updated to incorporate the change. > The patch has passed all the related testing including JCK. > > Thanks, > Kiran Build changes look good. - Marked as reviewed by erikj (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/602
Re: RFR: 8254177: (tz) Upgrade time-zone data to tzdata2020b
On Mon, 12 Oct 2020 09:32:38 GMT, Kiran Sidhartha Ravikumar
wrote:
> Hi Guys,
>
> Please review the patch for tzdata2020b integration into JDK.
>
> Release details can be found here:
>
> https://mm.icann.org/pipermail/tz-announce/2020-October/59.html
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8254177
>
> I had the pacificnew, systemv files removed from JDK repo and so TimeZoneName
> classes, make file and few test files
> need to be updated to incorporate the change.
> The patch has passed all the related testing including JCK.
>
> Thanks,
> Kiran
test/jdk/sun/util/calendar/zi/TestZoneInfo310.java line 221:
> 219: zids_old = ZoneInfoOld.getAvailableIDs(-8 * 60 * 60 * 1000);
> 220: Arrays.sort(zids_old);
> 221: System.out.println("new and old length = " + zids_new.length + " " +
> zids_old.length);
Missed to remove the instrumentation.
-
PR: https://git.openjdk.java.net/jdk/pull/602
RFR: 8254177: (tz) Upgrade time-zone data to tzdata2020b
Hi Guys, Please review the patch for tzdata2020b integration into JDK. Release details can be found here: https://mm.icann.org/pipermail/tz-announce/2020-October/59.html Bug: https://bugs.openjdk.java.net/browse/JDK-8254177 I had the pacificnew, systemv files removed from JDK repo and so TimeZoneName classes, make file and few test files need to be updated to incorporate the change. The patch has passed all the related testing including JCK. Thanks, Kiran - Commit messages: - Merge remote-tracking branch 'origin/master' into JDK-8254177 - 8254177: Resolving whitespaces in TestZoneInfo310.java - 8254177: (tz) Upgrade time-zone data to tzdata2020b Changes: https://git.openjdk.java.net/jdk/pull/602/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=602=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8254177 Stats: 480 lines in 27 files changed: 138 ins; 133 del; 209 mod Patch: https://git.openjdk.java.net/jdk/pull/602.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/602/head:pull/602 PR: https://git.openjdk.java.net/jdk/pull/602
