Re: RFR: 8276025: Hotspot's libsvml.so may conflict with user dependency [v2]
On Fri, 5 Nov 2021 00:56:05 GMT, Vladimir Kozlov wrote: >> Thanks a lot @vnkozlov. > > @sviswa7 testing passed you can integrate. Thanks a lot @vnkozlov for testing and review. Thanks @erikj79 @PaulSandoz @magicus for the review. - PR: https://git.openjdk.java.net/jdk/pull/6265
Re: RFR: 8276025: Hotspot's libsvml.so may conflict with user dependency [v2]
On Thu, 4 Nov 2021 18:15:08 GMT, Sandhya Viswanathan wrote: >> Looks good. I will run tests. > > Thanks a lot @vnkozlov. @sviswa7 testing passed you can integrate. - PR: https://git.openjdk.java.net/jdk/pull/6265
Re: RFR: 8276025: Hotspot's libsvml.so may conflict with user dependency [v2]
On Thu, 4 Nov 2021 19:49:08 GMT, Sandhya Viswanathan wrote: >> This patch removes conflicts with libsvml.so distributed with Intel's MKL >> library: >> Renames exported symbols from __svml to __jsvml. >> Renames library from libsvml.so to libjsvml.so. >> Updates the stubGenerator_x86_64.cpp accordingly to load libjsvml.so and >> the renamed symbols. >> Updates tests to look for the new library. >> >> Please review. >> >> Best Regards, >> Sandhya > > Sandhya Viswanathan has updated the pull request incrementally with one > additional commit since the last revision: > > change filename to jsvml* Marked as reviewed by ihse (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/6265
Re: RFR: 8276025: Hotspot's libsvml.so may conflict with user dependency [v2]
On Thu, 4 Nov 2021 19:49:08 GMT, Sandhya Viswanathan wrote: >> This patch removes conflicts with libsvml.so distributed with Intel's MKL >> library: >> Renames exported symbols from __svml to __jsvml. >> Renames library from libsvml.so to libjsvml.so. >> Updates the stubGenerator_x86_64.cpp accordingly to load libjsvml.so and >> the renamed symbols. >> Updates tests to look for the new library. >> >> Please review. >> >> Best Regards, >> Sandhya > > Sandhya Viswanathan has updated the pull request incrementally with one > additional commit since the last revision: > > change filename to jsvml* I did a case insensitive regex search `[^j]svml` over the checked out PR and did not find anything relevant that was missed. - Marked as reviewed by psandoz (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6265
Re: RFR: 8276025: Hotspot's libsvml.so may conflict with user dependency [v2]
On Thu, 4 Nov 2021 19:49:08 GMT, Sandhya Viswanathan wrote: >> This patch removes conflicts with libsvml.so distributed with Intel's MKL >> library: >> Renames exported symbols from __svml to __jsvml. >> Renames library from libsvml.so to libjsvml.so. >> Updates the stubGenerator_x86_64.cpp accordingly to load libjsvml.so and >> the renamed symbols. >> Updates tests to look for the new library. >> >> Please review. >> >> Best Regards, >> Sandhya > > Sandhya Viswanathan has updated the pull request incrementally with one > additional commit since the last revision: > > change filename to jsvml* There is also need to update one closed test we have before integration. - PR: https://git.openjdk.java.net/jdk/pull/6265
Re: RFR: 8276025: Hotspot's libsvml.so may conflict with user dependency [v2]
On Thu, 4 Nov 2021 19:49:08 GMT, Sandhya Viswanathan wrote: >> This patch removes conflicts with libsvml.so distributed with Intel's MKL >> library: >> Renames exported symbols from __svml to __jsvml. >> Renames library from libsvml.so to libjsvml.so. >> Updates the stubGenerator_x86_64.cpp accordingly to load libjsvml.so and >> the renamed symbols. >> Updates tests to look for the new library. >> >> Please review. >> >> Best Regards, >> Sandhya > > Sandhya Viswanathan has updated the pull request incrementally with one > additional commit since the last revision: > > change filename to jsvml* Build changes look good. - Marked as reviewed by erikj (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6265
Re: RFR: 8276025: Hotspot's libsvml.so may conflict with user dependency [v2]
On Thu, 4 Nov 2021 19:49:08 GMT, Sandhya Viswanathan wrote: >> This patch removes conflicts with libsvml.so distributed with Intel's MKL >> library: >> Renames exported symbols from __svml to __jsvml. >> Renames library from libsvml.so to libjsvml.so. >> Updates the stubGenerator_x86_64.cpp accordingly to load libjsvml.so and >> the renamed symbols. >> Updates tests to look for the new library. >> >> Please review. >> >> Best Regards, >> Sandhya > > Sandhya Viswanathan has updated the pull request incrementally with one > additional commit since the last revision: > > change filename to jsvml* Good. - Marked as reviewed by kvn (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6265
Re: RFR: 8276025: Hotspot's libsvml.so may conflict with user dependency [v2]
> This patch removes conflicts with libsvml.so distributed with Intel's MKL > library: > Renames exported symbols from __svml to __jsvml. > Renames library from libsvml.so to libjsvml.so. > Updates the stubGenerator_x86_64.cpp accordingly to load libjsvml.so and > the renamed symbols. > Updates tests to look for the new library. > > Please review. > > Best Regards, > Sandhya Sandhya Viswanathan has updated the pull request incrementally with one additional commit since the last revision: change filename to jsvml* - Changes: - all: https://git.openjdk.java.net/jdk/pull/6265/files - new: https://git.openjdk.java.net/jdk/pull/6265/files/7c488c10..70d962ae Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jdk=6265=01 - incr: https://webrevs.openjdk.java.net/?repo=jdk=6265=00-01 Stats: 0 lines in 72 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jdk/pull/6265.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6265/head:pull/6265 PR: https://git.openjdk.java.net/jdk/pull/6265
Re: RFR: 8276025: Hotspot's libsvml.so may conflict with user dependency
On Thu, 4 Nov 2021 17:48:56 GMT, Sandhya Viswanathan wrote: > This patch removes conflicts with libsvml.so distributed with Intel's MKL > library: > Renames exported symbols from __svml to __jsvml. > Renames library from libsvml.so to libjsvml.so. > Updates the stubGenerator_x86_64.cpp accordingly to load libjsvml.so and > the renamed symbols. > Updates tests to look for the new library. > > Please review. > > Best Regards, > Sandhya For completeness may be rename files too: jsvml_*.S and jsvml_*.S.inc - PR: https://git.openjdk.java.net/jdk/pull/6265
Re: RFR: 8276025: Hotspot's libsvml.so may conflict with user dependency
On Thu, 4 Nov 2021 18:11:41 GMT, Vladimir Kozlov wrote: >> This patch removes conflicts with libsvml.so distributed with Intel's MKL >> library: >> Renames exported symbols from __svml to __jsvml. >> Renames library from libsvml.so to libjsvml.so. >> Updates the stubGenerator_x86_64.cpp accordingly to load libjsvml.so and >> the renamed symbols. >> Updates tests to look for the new library. >> >> Please review. >> >> Best Regards, >> Sandhya > > Looks good. I will run tests. Thanks a lot @vnkozlov. - PR: https://git.openjdk.java.net/jdk/pull/6265
Re: RFR: 8276025: Hotspot's libsvml.so may conflict with user dependency
On Thu, 4 Nov 2021 17:48:56 GMT, Sandhya Viswanathan wrote: > This patch removes conflicts with libsvml.so distributed with Intel's MKL > library: > Renames exported symbols from __svml to __jsvml. > Renames library from libsvml.so to libjsvml.so. > Updates the stubGenerator_x86_64.cpp accordingly to load libjsvml.so and > the renamed symbols. > Updates tests to look for the new library. > > Please review. > > Best Regards, > Sandhya Looks good. I will run tests. - Marked as reviewed by kvn (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6265
RFR: 8276025: Hotspot's libsvml.so may conflict with user dependency
This patch removes conflicts with libsvml.so distributed with Intel's MKL library: Renames exported symbols from __svml to __jsvml. Renames library from libsvml.so to libjsvml.so. Updates the stubGenerator_x86_64.cpp accordingly to load libjsvml.so and the renamed symbols. Updates tests to look for the new library. Please review. Best Regards, Sandhya - Commit messages: - load svml test fixes - update tests - 8276025: Hotspot's libsvml.so may conflict with user dependency Changes: https://git.openjdk.java.net/jdk/pull/6265/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk=6265=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276025 Stats: 391989 lines in 123 files changed: 192755 ins; 192755 del; 6479 mod Patch: https://git.openjdk.java.net/jdk/pull/6265.diff Fetch: git fetch https://git.openjdk.java.net/jdk pull/6265/head:pull/6265 PR: https://git.openjdk.java.net/jdk/pull/6265
