Re: RFR: JDK-8055735: JDK_FILTER is broken

2016-06-09 Thread Tim Bell
Erik: On 06/09/16 05:23, Alan Bateman wrote: On 09/06/2016 13:18, Claes Redestad wrote: On 2016-06-09 14:11, Erik Joelsson wrote: You have a point, we should avoid relying on uninitialized variables being empty. http://cr.openjdk.java.net/~erikj/8055735/webrev.top.02/ Thanks, looks

Re: RFR: JDK-8055735: JDK_FILTER is broken

2016-06-09 Thread Alan Bateman
On 09/06/2016 13:18, Claes Redestad wrote: On 2016-06-09 14:11, Erik Joelsson wrote: You have a point, we should avoid relying on uninitialized variables being empty. http://cr.openjdk.java.net/~erikj/8055735/webrev.top.02/ Thanks, looks good to me! This looks okay to me too. -Alan.

Re: RFR: JDK-8055735: JDK_FILTER is broken

2016-06-09 Thread Claes Redestad
On 2016-06-09 14:11, Erik Joelsson wrote: You have a point, we should avoid relying on uninitialized variables being empty. http://cr.openjdk.java.net/~erikj/8055735/webrev.top.02/ Thanks, looks good to me! /Claes /Erik On 2016-06-09 13:06, Claes Redestad wrote: Looks OK to me,

Re: RFR: JDK-8055735: JDK_FILTER is broken

2016-06-09 Thread Erik Joelsson
You have a point, we should avoid relying on uninitialized variables being empty. http://cr.openjdk.java.net/~erikj/8055735/webrev.top.02/ /Erik On 2016-06-09 13:06, Claes Redestad wrote: Looks OK to me, although I'd somehow be happier if FAIL_NO_SRC was explicitly set to true when

Re: RFR: JDK-8055735: JDK_FILTER is broken

2016-06-09 Thread Claes Redestad
Looks OK to me, although I'd somehow be happier if FAIL_NO_SRC was explicitly set to true when JDK_FILTER isn't set. /Claes On 2016-06-09 12:40, Erik Joelsson wrote: After the source code restructure, the JDK_FILTER functionality is not working well. The first module that needs to be

RFR: JDK-8055735: JDK_FILTER is broken

2016-06-09 Thread Erik Joelsson
After the source code restructure, the JDK_FILTER functionality is not working well. The first module that needs to be recompiled gets the filter applied, but then the dependents also get it and the macro finds zero files and fails the build. I have created a fix for this that makes the build